July 2011 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] wineoss.drv: Attempt to verify that the system is actually running OSS
by Vitaliy Margolen July 25, 2011

July 25, 2011

On 07/22/2011 08:35 AM, Andrew Eikum wrote: > > This is really crude, but does seem to work. I tested it correct with just > ALSA 1.0.24; ALSA 1.0.24's snd-pcm-oss and snd-pcm-mixer modules; and on > OSS4.2. It was also tested by Gerald Pfeifer on FreeBSD 8.2 and 9.0. > > This lets us attempt to load the OSS driver, and if that fails, then try the > ALSA driver. Automatic driver selection! You forgetting, that users can select multiple drivers in winecfg now. And that's what some people have in their registry. The actual approach is seems fishy to me as well. The reason ALSA driver is 1st is because most systems has it as the main sound subsystem. Putting something [oss] first in the list, and failing if it wasn't explicitly asked for defeats the whole idea about something being default, and having alternate fallback(s). With same logic one would add all other sound drivers and make them fail, unless explicitly asked for. Vitaliy.

2 1

Statur of DIB Engine
by Massimo Del Fedele July 25, 2011

July 25, 2011

Having seen many patches related to DIB engine lately, I built latest sources and tried it.... No speed enhancements on AutoCAD, my test app. So, I wonder if the engine is already working, at least partially, or not. If yes, there's some switch/environment variable to enable it ? Sorry for asking here but, besides of git commits I've seen no explanation about what's happening. Also some users of my old engine, which are blocked to an old wine version (it is no more applicable to git tree since some time, because of recent changes....) would like to know what's going on. Ciao Max

4 6

Re: cmd: mkdir should complain if directory already exists
by Frédéric Delanoy July 25, 2011

July 25, 2011

On Sun, Jul 24, 2011 at 20:58, Dan Kegel <dank(a)kegel.com> wrote: > Fixes bug 27383. There's trailing whitespace on the line preceding "if (!create_full_path(param1)) {" Seems ok otherwise

1 0

Re: [PATCH 3/4] ntdll: implement the NamedPipeConfiguration value for the FilePipeLocalInformation class of NtQueryInformati
by Marvin July 25, 2011

July 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12778 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: [PATCH 2/4] kernel32, ntdll, server: implement permission checks for named pipes
by Marvin July 25, 2011

July 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12777 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Re: [PATCH 1/4] server, ntdll: get rid of the blocking parameter for ioctls. blockingness depends on the overlapped flag for
by Marvin July 25, 2011

July 25, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12776 Your paranoid android. === WNT4WSSP6 (32 bit pipe) === Timeout

1 0

Need help at collecting ActionMapping data
by Lucas Zawacki July 24, 2011

July 24, 2011

Hello everyone. As you may know I'm working on the dinput8 action mapping support and at the moment I've pretty much finished the mouse and keyboard and just need to get my patches in. For the next part, however, I'm going to need to analyze lot's of data generated by different joysticks to figure out how the mapping works. Some things are already clear for me, but I have only some simple USB joysticks here and thus would like your help to collect more useful data. If any of you has any sort of joystick (simple gamepads, driving wheels and whatnot) and would like to help, I've set up a little app that uses the DI8 action mapping API to construct a mapping for every connected joystick and outputs it to the terminal. You just need to run it, redirect the output to a file and email it back to me. Telling me which version of windows you're running would be nice. If you want to help but can't use windows, wine with native dinput8.dll is fine too. The program can be found here: https://github.com/downloads/lfzawacki/dinput-samples/devices_test.exe The code is here: https://github.com/lfzawacki/dinput-samples/blob/master/devices_test.cpp Thanks in advance Cheers

2 3

re: urlmon: Fix various typos/misspellings
by Dan Kegel July 24, 2011

July 24, 2011

Hi Frédéric, >-/* List of 3 character top level domain names Windows seems to recognize. >+/* List of 3 characters top level domain names Windows seems to recognize. That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.) The other changes seem ok. - Dan

5 6

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)
by Jacek Caban July 23, 2011

July 23, 2011

Hi Hans, On 07/23/11 09:52, Hans Leidekker wrote: > @@ -2107,7 +2107,7 @@ static void test_IWinHttpRequest(void) > HRESULT hr; > IWinHttpRequest *req; > BSTR method, url, response = NULL, status_text = NULL; > - VARIANT async, empty, timeout; > + VARIANT async, empty, timeout, body; > VARIANT_BOOL succeeded; > LONG status; > > @@ -2241,6 +2241,13 @@ static void test_IWinHttpRequest(void) > ok( hr == S_OK, "got %08x\n", hr ); > SysFreeString( response ); > > + VariantInit( &body ); > + V_VT( &body ) = VT_ERROR; > + hr = IWinHttpRequest_get_ResponseBody( req, &body ); > + ok( hr == S_OK, "got %08x\n", hr ); > + ok( V_VT( &body ) == (VT_ARRAY|VT_UI1), "got %08x\n", V_VT( &body ) ); > + > + ok( hr == S_OK, "got %08x\n", hr ); This duplicates the above test. Did you mean to test the result of VariantClear here (otherwise there is a leak)? Thanks, Jacek

2 1

Re: [2/3] winhttp: Implement IWinHttpRequest::get_ResponseBody. (try 2)
by Marvin July 23, 2011

July 23, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12710 Your paranoid android. === W2K8SE (32 bit winhttp) === winhttp.c:926: Test failed: failed to receive response 12152 winhttp.c:933: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019 winhttp.c:937: Test failed: failed unexpectedly 12019 winhttp.c:938: Test failed: unexpected size 0 winhttp.c:943: Test failed: failed unexpectedly 12019

2 1