July 2011 - Wine-Devel - list.winehq.org

Re: use Lithuanian letter in my name
by Frédéric Delanoy July 19, 2011

July 19, 2011

On Mon, Jul 18, 2011 at 23:53, Nerijus Baliunas <nerijus(a)users.sourceforge.net> wrote: > --- > AUTHORS | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Maybe you should ensure that the name you commit your patches with (foo in 'foo <email>') is correctly spelled as well. I believe the authors list is generated from wine git's patch authors Frédéric

3 2

Re: [PATCH 2/5] d3dx9_36: Improved constant table handle support (try 3)
by Alexandre Julliard July 18, 2011

July 18, 2011

Travis Athougies <iammisc(a)gmail.com> writes: > +static ctab_constant *is_valid_constant(ID3DXConstantTableImpl *This, D3DXHANDLE parameter) > +{ > + UINT i; > + > + for (i = 0; i < This->desc.Constants; i++) > + if ((ctab_constant *)parameter == &This->constants[i]) > + return (ctab_constant *)parameter; This doesn't look like an improvement. -- Alexandre Julliard julliard(a)winehq.org

2 1

Rejected or commited?
by wylda＠volny.cz July 18, 2011

July 18, 2011

Hi, I just noticed that patch 76524 is "Rejected". But there is the same patch commited as 48d03555a7a6931ee8ba0952ccb92c70925c6bed. Duno, if some other patch should not be merged instead. Regards, W. -- Sháníte letenky na pracovní cestu, dovolenou či jen na výlet? Na http://letenky.volny.cz si zajisté vyberete.

2 1

Re: jscript: Properly handle aggregation attempt
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12575 Your paranoid android. === W2KPROSP4 (32 bit jscript) === jscript.c:615: Test failed: CoCreateInstance failed: 80070057, expected CLASS_E_NOAGGREGATION

1 0

Re: [PATCH 3/3] vbscript: Added creation tests
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12573 Your paranoid android. === WNT4WSSP6 (32 bit vbscript) === vbscript.c:38: Test failed: CoCreateInstance failed: 80040154 vbscript: unhandled exception c0000005 at 004012F2

1 0

Re: mshtml: Added IHTMLStyle::pageBreakAfter property implementation
by Marvin July 18, 2011

July 18, 2011

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12568 Your paranoid android. === WXPPROSP3 (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null) === WVISTAADM (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null) === W2K8SE (32 bit dom) === dom.c:5716: Test failed: put_pageBreakAfter failed: 80070057 dom.c:5721: Test failed: pageBreakAfter = (null)

1 0

Re: [PATCH 02/10] ntdll/tests: add a test for STATUS_OBJECT_TYPE_MISMATCH
by Alexandre Julliard July 18, 2011

July 18, 2011

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > @@ -774,6 +775,28 @@ static void test_query_object(void) > pNtClose( handle ); > } > > +static void test_type_mismatch(void) > +{ > + HANDLE h; > + NTSTATUS res; > + OBJECT_ATTRIBUTES attr; > + > + attr.Length = sizeof(attr); > + attr.RootDirectory = 0; > + attr.ObjectName = NULL; > + attr.Attributes = 0; > + attr.SecurityDescriptor = NULL; > + attr.SecurityQualityOfService = NULL; > + Please avoid messing up the indentation. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/4] dsound/tests: Add tests to check notifications after duplicate.
by Alexandre Julliard July 18, 2011

July 18, 2011

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > --- > dlls/dsound/tests/dsound.c | 178 ++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 178 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M dsound.dll -T ../../.. -p dsound_test.exe.so dsound.c && touch dsound.ok dsound.c:1066: Test succeeded inside todo block: expected 1. got 1 make[1]: *** [dsound.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] user32: handle %I... formats in user32.wsprintf* (try 2)
by Alexandre Julliard July 18, 2011

July 18, 2011

Dan Kegel <dank(a)kegel.com> writes: > + i64 = 0x100000000LL; Don't use LL constants. > @@ -257,14 +282,25 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, > case WPR_SIGNED: > len = sprintf( number, "%d", arg->int_view ); > break; > + case WPR_SIGNED64: > + len = sprintf( number, "%lld", arg->int64_view ); > + break; Don't use %ll formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 01/11] wscript: fixed running script from outside its directory (resend)
by Alexandre Julliard July 18, 2011

July 18, 2011

Michał Ziętek <smierc.w.wenecji(a)gmail.com> writes: > @@ -347,7 +347,7 @@ int WINAPI wWinMain(HINSTANCE hInst, HINSTANCE hPrevInst, LPWSTR cmdline, int cm > return 1; > } > > - ext = strchrW(filename, '.'); > + ext = strrchrW(filename, '.'); That's not much better. -- Alexandre Julliard julliard(a)winehq.org

1 0