January 2012 - Wine-Devel - list.winehq.org

Re: jscript: Fixed continue inside for..in statement
by Marvin Jan. 10, 2012

Jan. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16361 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: gdi32: GetGlyphIndices doesn't substitute glyph.
by Marvin Jan. 10, 2012

Jan. 10, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16359 Your paranoid android. === WNT4WSSP6 (32 bit font) === Timeout

1 0

Re: [PATCH] programs/explorer: Fix explorer's command line parsing (try 2)
by Vitaliy Margolen Jan. 10, 2012

Jan. 10, 2012

On 01/08/2012 08:45 PM, Jay Yang wrote: > Fixed some small formatting issues from last time. > Your patch strips spaces all over the place. For example: + LPWSTR *argv; + if(commandline[0]=='\0') Need an empty line after variable declarations. No space after "if". No space around equal operator. + for(i=0;i<argc;i++) No spaces after semi-colon. + copy_path_string(parameters->root,curr); No space after coma. Some other issues - you will parse over parameters given to the program. Ex: explorer /desktop=foo,800x600 program.exe /n /e Parsing inside parameters is incorrect: + LPWSTR end=strchrW(curr,','); + LPWSTR next; + if(end==NULL) + next=(end=strchrW(curr,'\0')); + else + next=end+1; ... + curr=next; You end up parsing something like this as a valid param: /n,/e,/select,c:\\ Vitaliy.

2 2

Re: [4/5] dinput: Device username being assigned at creation time (try 2)
by Vitaliy Margolen Jan. 10, 2012

Jan. 10, 2012

On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki<lfzawacki(a)gmail.com> You leaking FindFile handle. Need to use FindClose() to close it. This is on top of more unchecked returns from HappAlloc. Vitaliy.

1 0

Re: [3/5] dinput: SetActionMap setting username
by Vitaliy Margolen Jan. 10, 2012

Jan. 10, 2012

On 01/09/2012 10:18 AM, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki<lfzawacki(a)gmail.com> > > + /* Set username in device */ > + HeapFree(GetProcessHeap(), 0, This->username); > + This->username = HeapAlloc(GetProcessHeap(), 0, sizeof(WCHAR) * (lstrlenW(username) + 1)); > + lstrcpyW(This->username, username); No error checking if allocation fails. > + > + /* Free username */ > + HeapFree(GetProcessHeap(), 0, This->username); > + Comment is kind of redundant the property already called "username". Vitaliy.

1 0

UTF-7
by Alex Henrie Jan. 10, 2012

Jan. 10, 2012

Hello, I have been thinking about implementing UTF-7 support in MultiByteToWideChar and WideCharToMultiByte. The guts of the code that needs to be added have already been posted to bug 27388. What more needs to be done? Should a libs/wine/utf7.c file be created for the new functions, similar to libs/wine/utf8.c? -Alex

1 0

Re: [1/5] dinput: Added DI_SETTINGSNOTSAVED flag
by Francois Gouget Jan. 9, 2012

Jan. 9, 2012

On Mon, 9 Jan 2012, Lucas Fialho Zawacki wrote: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > --- > include/dinput.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/dinput.h b/include/dinput.h > index 353ec55..cf99ecc 100644 > --- a/include/dinput.h > +++ b/include/dinput.h > @@ -134,6 +134,7 @@ DECL_WINELIB_TYPE_AW(LPDIRECTINPUTDEVICE8) > #define DI_DOWNLOADSKIPPED ((HRESULT)0x00000003) > #define DI_EFFECTRESTARTED ((HRESULT)0x00000004) > #define DI_TRUNCATED ((HRESULT)0x00000008) > +#define DI_SETTINGSNOTSAVED ((HRESULT)0x0000000BL) > #define DI_TRUNCATEDANDRESTARTED ((HRESULT)0x0000000C) I'm not sure the 'L' modifier is needed or makes sense (although the PSDK does have it). In anycase there's clearly an inconsistency in the above patch and we normally avoid the 'L' modifier nowadays, see for instance __MSABI_LONG() in include/ddeml.h. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Good judgment comes from experience, and experience comes from bad judgment -- Barry LePatner

1 0

Re: [6/6] d3drm: Implement GetParent
by Nikolay Sivov Jan. 9, 2012

Jan. 9, 2012

On 1/8/2012 20:47, André Hentschel wrote: > --- > dlls/d3drm/frame.c | 11 +++++++---- > dlls/d3drm/tests/d3drm.c | 16 ++++++++-------- > 2 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c > index 212f7dd..b72700c 100644 > --- a/dlls/d3drm/frame.c > +++ b/dlls/d3drm/frame.c > @@ -33,6 +33,7 @@ typedef struct { > IDirect3DRMFrame2 IDirect3DRMFrame2_iface; > IDirect3DRMFrame3 IDirect3DRMFrame3_iface; > LONG ref; > + LPVOID parent; > } IDirect3DRMFrameImpl; Parent is store as another frame interface pointer, right? Why void* here? > > static const struct IDirect3DRMFrame2Vtbl Direct3DRMFrame2_Vtbl; > @@ -336,9 +337,10 @@ static HRESULT WINAPI IDirect3DRMFrame2Impl_GetParent(IDirect3DRMFrame2* iface, > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > > - FIXME("(%p/%p)->(%p): stub\n", iface, This, frame); > + TRACE("(%p/%p)->(%p)\n", iface, This, frame); > > - return E_NOTIMPL; > + *frame = This->parent; > + return D3DRM_OK; > } What looks suspicious is reference counting handling, or absence of it in other words. I'm not familiar with d3d, but this needs tests for parent refcount - is it increased when it's stored? is it properly freed? is it increased after GetParent()?

3 5

Re: [PATCH 1/6] ieframe: Added support for SID_SHTMLWindow in WebBrowser::QueryService
by Marvin Jan. 9, 2012

Jan. 9, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16341 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3093: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3170: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2754: Test failed: expected TranslateUrl webbrowser.c:2755: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2756: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2762: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3129: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2847: Test failed: expected RequestUIActivate webbrowser.c:2939: Test failed: Got 0x80004002 webbrowser.c:3137: Test failed: doc != doc2 webbrowser.c:3034: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040CB02

1 0

Re: user32: Add GetListBoxInfo
by Nikolay Sivov Jan. 9, 2012

Jan. 9, 2012

On 1/9/2012 01:28, Louis Lenders wrote: > This should fix http://bugs.winehq.org/show_bug.cgi?id=27385 > > (See also Remarks on http://msdn.microsoft.com/en-us/library/windows/desktop/bb775208%28v=vs.85%… : This message is equivalent to GetListBoxInfo. > +DWORD WINAPI GetListBoxInfo(HWND hwnd) > +{ > + TRACE("(%p)\n", hwnd); > + return SendMessageW( hwnd, LB_GETLISTBOXINFO, 0, 0); > +} > + Please add a test showing that it really sends a message.

1 0