January 2012 - Wine-Devel - list.winehq.org

Re: user32: Add GetListBoxInfo
by Dmitry Timoshkov Jan. 9, 2012

Jan. 9, 2012

Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > +DWORD WINAPI GetListBoxInfo(HWND hwnd) > +{ > + TRACE("(%p)\n", hwnd); > + return SendMessageW( hwnd, LB_GETLISTBOXINFO, 0, 0); > +} The spacing is not consistent. > -# @ stub GetListBoxInfo > +@ stdcall GetListBoxInfo(ptr) Please have a look at other user32 spec file entries for correct type for a window handle. -- Dmitry.

1 0

Re: [4/4] shell32: Fix SHLoadInProc() return value
by Marvin Jan. 8, 2012

Jan. 8, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16325 Your paranoid android. === W2KPROSP4 (32 bit shellole) === shellole.c:452: Test failed: got 0x80040111 === WVISTAADM (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W2K8SE (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W7PRO (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W7PROX64 (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === TEST64_W7SP1 (32 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === W7PROX64 (64 bit shellole) === shellole.c:452: Test failed: got 0x80004001 === TEST64_W7SP1 (64 bit shellole) === shellole.c:452: Test failed: got 0x80004001

1 0

Re: d3drm/tests: Add IDirect3DRM3 tests
by Marvin Jan. 6, 2012

Jan. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16297 Your paranoid android. === WNT4WSSP6 (32 bit d3drm) === d3drm.c:145: Test failed: Cannot get IDirect3DRM3 interface (hr = 80040111) d3drm: unhandled exception c0000005 at 0040184F

1 0

Re: [1/2] d3drm: Partial implementation for [Add/Delete]Child
by Henri Verbeet Jan. 6, 2012

Jan. 6, 2012

2012/1/6 André Hentschel <nerv(a)dawncrow.de>: > @@ -212,10 +216,15 @@ static HRESULT WINAPI IDirect3DRMFrame2Impl_AddChild(IDirect3DRMFrame2* iface, > LPDIRECT3DRMFRAME child) > { > IDirect3DRMFrameImpl *This = impl_from_IDirect3DRMFrame2(iface); > + IDirect3DRMFrameImpl *Frame = impl_from_IDirect3DRMFrame2((LPDIRECT3DRMFRAME2)child); That looks pretty questionable, but some tests would probably be a good thing either way.

1 0

Re: [2/4] d3drm: Forward GetTextureCoordinates from IDirect3DRMMeshBuilder3 to IDirect3DRMMeshBuilder2
by Henri Verbeet Jan. 6, 2012

Jan. 6, 2012

2012/1/6 André Hentschel <nerv(a)dawncrow.de>: > - > - FIXME("(%p)->(%d,%p,%p): stub\n", This, index, u, v); > - > - return E_NOTIMPL; > + return IDirect3DRMMeshBuilder_GetTextureCoordinates(&This->IDirect3DRMMeshBuilder2_iface, > + index, u, v); > } I'm not going to say you can't do it like this, but it can often be pretty useful to know what version of an interface you were called from. Also, usually we implement older versions of interfaces on top of the new ones, instead of the other way around.

2 1

Re: [PATCH 4/5] ieframe: Added IHTMLWindow2 service tests
by Marvin Jan. 6, 2012

Jan. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16291 Your paranoid android. === WNT4WSSP6 (32 bit ie) === ie.c:78: Test failed: Could not create InternetExplorer instance: 80040154

2 1

Re: msvcp90: add basic_ios<wchar_t> stubs
by Piotr Caban Jan. 6, 2012

Jan. 6, 2012

On 01/05/12 22:41, Daniel Lehman wrote: +/* ?imbue@?$basic_ios(a)_WU?$char_traits(a)_W@std@@@std@@QAE?AVlocale(a)2@ABV32@@Z */ +/* ?imbue@?$basic_ios(a)_WU?$char_traits(a)_W@std@@@std@@QEAA?AVlocale(a)2@AEBV32@@Z */ +DEFINE_THISCALL_WRAPPER(basic_ios_wchar_imbue, 4) +locale __thiscall basic_ios_wchar_imbue(basic_ios_wchar *this) +{ + locale ret = { NULL }; + FIXME("(%p) stub\n", this); + return ret; +} This should look like: locale* __thiscall basic_ios_wchar_imbue(basic_ios_wchar *this, locale *ret) there's similar mistake in basic_ios_char_imbue.

1 0

Re: mshtml: Remove unused definitions
by Jacek Caban Jan. 6, 2012

Jan. 6, 2012

Hi André, On 01/05/12 19:35, André Hentschel wrote: > --- > dlls/mshtml/resource.h | 17 ----------------- > 1 files changed, 0 insertions(+), 17 deletions(-) > > diff --git a/dlls/mshtml/resource.h b/dlls/mshtml/resource.h > index 50342a2..a798760 100644 > --- a/dlls/mshtml/resource.h > +++ b/dlls/mshtml/resource.h > @@ -38,23 +38,6 @@ > > #define IDR_BROWSE_CONTEXT_MENU 24641 > > -#define IDM_TRACETAGS 6004 > -#define IDM_RESOURCEFAILURES 6005 > -#define IDM_DUMPTRACKINGINFO 6006 > -#define IDM_DEBUGBREAK 6007 > -#define IDM_DEBUGVIEW 6008 > -#define IDM_DUMPTREE 6009 > -#define IDM_DUMPLINES 6010 > - > -#define IDM_SAVEHTML 6012 > -#define IDM_MEMORYMONITOR 6013 > -#define IDM_PERFORMANCEMETERS 6014 > -#define IDM_DUMPDISPLAYTREE 6015 > -#define IDM_DUMPFORMATCACHES 6016 > -#define IDM_DUMPLAYOUTRECTS 6017 > - > -#define _IDM_REFRESH 6042 > - > #define IDD_HYPERLINK 8000 > > #define IDC_URL 9001 > These defines are for stuff that is in shdoclc and mshtml uses these resources. Although we currently don't use them currently, ideally we should implement them. It doesn't make sense to remove them now and add back in the future. Jacek

1 0

Re: [PATCH 2/2] winmm/tests: Test some inconsistent WAVEFORMAT descriptions.
by Marvin Jan. 6, 2012

Jan. 6, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16276 Your paranoid android. === WVISTAADM (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W2K8SE (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W7PRO (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W7PROX64 (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === TEST64_W7SP1 (32 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === W7PROX64 (64 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.) === TEST64_W7SP1 (64 bit wave) === wave.c:658: Test failed: waveOutOpen(0): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=MMSYSERR_INVALPARAM(An invalid parameter was passed to a system function.) wave.c:658: Test failed: waveOutOpen(WAVE_MAPPER): format=22050x 8x1 flags=50000(CALLBACK_EVENT) rc=WAVERR_BADFORMAT(The specified format is not supported or cannot be translated. Use the Capabilities function to determine the supported formats.)

2 1

Re: [PATCH 1/5] ddraw/tests: Add some clipper tests.
by Alexandre Julliard Jan. 5, 2012

Jan. 5, 2012

Henri Verbeet <hverbeet(a)codeweavers.com> writes: > --- > dlls/ddraw/tests/ddraw1.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw2.c | 217 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw4.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ddraw/tests/ddraw7.c | 216 ++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 866 insertions(+), 0 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M ddraw.dll -T ../../.. -p ddraw_test.exe.so ddraw1.c && touch ddraw1.ok ddraw1.c:225: Test succeeded inside todo block: Got unexpected bounding rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. ddraw1.c:231: Test succeeded inside todo block: Got unexpected clip rect {14, 33, 646, 486}, expected {14, 33, 646, 486}. make: *** [ddraw1.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3