January 2012 - Wine-Devel - list.winehq.org

[PATCH RFC 4/5] dsound: Clean up channels
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 3, 2012

Jan. 3, 2012

Alexander, You want to google the paper titled "Defining speaker locations in multi-channel streams and WDM audio drivers using the WAVEFORMATEXTENSIBLE structure" by Carsten Schulz to learn a lot about channel mapping as performed by w2k. It's a pity there's nothing like it for xp or w7! Wine's mmdevapi does not yet behave like native's 5:1 cards. People have sent me the following mmdevapi:render test data on native machines: render.c:182: chan: 6 render.c:183: rate: 48000 render.c:184: align: 24 render.c:191: Mask: 3f IOW, the system's mixer format is really 6 channels! There presumably, DSound sends stereo and 6 channel data to the mixer. I suppose MS evolved DSound's mixer into mmdevapi's one, with some lessons learned. BTW, as I'm not aware of a means to extract from ALSA the user's speaker configuration, Wine likely needs either a winecfg setting (like MS' system preferences) or a registry key to advertize the mixer's dwChannelMask (and default to 0x3f with 6 channels). Regards, Jörg Höhle

1 0

new d3d9/device.ok test always fails here, but not a regression?
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 3, 2012

Jan. 3, 2012

Hi, > Bugs in newly added code cannot be regressions. > > Similarly, if we add a dll and some app starts using it and breaks, > technically that's not a regression even though the behavior got worse, > because it has always been broken, it just wasn't exercised before. What does this distinction bring us? The old definition, "if it worked in version N and doesn't in N+1, then it is a regression" was straightforward and easy to understand. There was little to debate, no room left for confusion. Every such regression could be associated with the SHA1 of a commit. The new definition can get arbitrarily complex. Consider bug #19496. Bug resolution likely involves moving from mciwave to mciavi. As mciavi is not equally advanced, this move will likely cause bugs to appear in other apps. But we wouldn't call them regressions "because it has always been broken"?!? That makes no sense to users. What benefit does it have for developers? Having one's name appear less often in source.winehq.org/regressions when doing The Right Thing (TRT)? Regards, Jörg Höhle

5 5

Re: mscoree: Implement CLRRuntimeHost_ExecuteInDefaultAppDomain
by Vincent Povirk Jan. 3, 2012

Jan. 3, 2012

Cool! Looks good to me. On Tue, Jan 3, 2012 at 4:23 AM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > > > Changelog: > mscoree: Implement CLRRuntimeHost_ExecuteInDefaultAppDomain > > > Best Regards > Alistair Leslie-Hughes > > >

1 0

new d3d9/device.ok test always fails here, but not a regression?
by Dan Kegel Jan. 3, 2012

Jan. 3, 2012

Happy New Year's Eve, everyone! 002447357c2b1feca5ef2649429fc55f70238901 added a IDirect3DDevice9::SetCursorPosition() test to d3d9. That test never worked here, I think. I filed http://bugs.winehq.org/show_bug.cgi?id=29094 for it, and marked it as a regression (since tests/device.c used to pass, but fails here after that commit). Henri removed the regression keyword and sha1sum without comment. What's the reasoning there? Is Henri saying there's something wrong with my test setup (stock ubuntu), or are new tests that cause 'make test' to fail not considered regressions? Or something else?

4 6

Re: [PATCH 3/5] d3d10/tests: Add a state groups test.
by Marvin Jan. 3, 2012

Jan. 3, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16235 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [PATCH 2/5] wined3d: Recognize some more Intel GPUs.
by Christian Inci Jan. 3, 2012

Jan. 3, 2012

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Henri, I'm using a Netbook with an Intel Atom N450 (Pineview, PCI ID: 8086:a011), which has 256MB under 2GB of RAM. Personally, I think we need a way for detecting the correct VRAM size for IGD's, as it usually depends on the total RAM size. (If not already implemented. I'm not familiar with the directx subset of Wine. ;-) ) Kind regards, Chris -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPAmH5AAoJEBs38cNfaEHvzBsH/2Xlg5bfOc6Cudr2dIgD2XJk +ru6bHLM51tN2aacQphRNm6y1e60DEPvEiBei8hSZ0dU+mP0C/WsuOMjHIz3+LIg kXfRgqfjExqXoCaZuDnjnFpVjkdnF+NJUJlvvqTRm2hmZIbvKIdvKUagyNx8rmnG 4Bro+00qzU7KlAuYHZZptlFcCF4efndllCKonMBt2IqxpePz84Kx7YfjTABXvZS4 +JeYVlMiZ8wcCzcE3C7MHWwXToas1vAE7BHWiCQ9sUrs0Me4e7KqurvFKm690sf+ L63eD16R9xfgS/SBWFEG74iehb8bEjZNZgpxMrjdZdU7vAVjskfhnAvAjFkkNxU= =IRzs -----END PGP SIGNATURE-----

2 1

Warning report for wine-1.3.36
by Jerome Leclanche Jan. 2, 2012

Jan. 2, 2012

No change since 1.3.35. J. Leclanche

1 0

[PATCH RFC 4/5] dsound: Clean up channels
by Joerg-Cyril.Hoehle＠t-systems.com Jan. 2, 2012

Jan. 2, 2012

Alexander, I'm not familiar with dsound + if (ichannels > 2) + FIXME("Conversion from %u to %u channels is not implemented, falling back to stereo", ichannels, ochannels); + dsb->mix_channels = 2; Does you code support 8 channels? Look through git history, and you'll see some patches made specifically for 6 or even 8 channel audio plus some 8->2 and 2->8 conversions. Without having a 5:1 or 7:1 card, I think this gives hints as to what apps expect from conversions. Of course, there's always a risk that an old bug analysis was biased by other bugs, leading to misconceptions and misbeliefs about the actual needs and behaviour. About dsound: convert from fixed to floating point Using floats for frequencies is not bad. After all, modern mmdevapi does it too in IAudioClockAdjustment::SetSampleRate Just avoid computing byte positions from floats... BTW, AUDCLNT_STREAMFLAGS_RATEADJUST hints that the DSound mixer implements stuff that mmdevapi's mixer needs... Regards, Jörg Höhle

1 0

Re: ieframe: Improved test traces
by Marvin Jan. 2, 2012

Jan. 2, 2012

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16234 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3089: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3166: Test failed: Creating WebBrowser object failed: 80040154 === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:405: Test failed: unexpected call Exec_SETDOWNLOADSTATE_0 webbrowser.c:2087: Test failed: put_Resizable failed: 80004001 webbrowser.c:2088: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2092: Test failed: put_Resizable failed: 80004001 webbrowser.c:2093: Test failed: expected Invoke_WINDOWSETRESIZABLE webbrowser.c:2473: Test failed: expected GetOverridesKeyPath webbrowser.c:2477: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2478: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2750: Test failed: expected TranslateUrl webbrowser.c:2751: Test failed: expected Invoke_BEFORENAVIGATE2 webbrowser.c:2752: Test failed: expected Invoke_PROPERTYCHANGE webbrowser.c:2758: Test failed: ReadyState = 1, expected 4 webbrowser.c:2582: Test failed: ReadyState = 1, expected 4 webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:807: Test failed: unexpected call Invoke_BEFORENAVIGATE2 webbrowser.c:814: Test failed: ReadyState = 1, expected 4 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:791: Test failed: unexpected call Invoke_PROPERTYCHANGE webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:892: Test failed: ReadyState = 1, expected 4 webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:3125: Test failed: doc != doc2 webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:606: Test failed: unexpected call Invoke_AMBIENT_USERMODE webbrowser.c:609: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL webbrowser.c:613: Test failed: unexpected call Invoke_AMBIENT_USERAGENT webbrowser.c:617: Test failed: unexpected call Invoke_AMBIENT_PALETTE webbrowser.c:1509: Test failed: unexpected call GetOptionKeyPath webbrowser.c:354: Test failed: unexpected call QueryStatus_SETPROGRESSTEXT webbrowser.c:461: Test failed: unexpected nCmdID 26 webbrowser.c:461: Test failed: unexpected nCmdID 29 webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:1520: Test failed: unexpected call GetDropTarget webbrowser.c:959: Test failed: unexpected call GetContainer webbrowser.c:509: Test failed: unexpected call webbrowser.c:2623: Test failed: expected TranslateUrl webbrowser.c:2630: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2843: Test failed: expected RequestUIActivate webbrowser.c:2935: Test failed: Got 0x80004002 webbrowser.c:3133: Test failed: doc != doc2 webbrowser.c:3030: Test failed: QueryService failed: 80004002 webbrowser: unhandled exception c0000005 at 0040C9B2

1 0

Re: urlmon: When detecting text/html look for HEAD or BODY tags too and only in first 256 bytes
by Jacek Caban Jan. 2, 2012

Jan. 2, 2012

On 01/02/12 14:53, Paul Chitescu wrote: > Changelog: > urlmon: When detecting text/html look for HEAD or BODY tags too and only in > first 256 bytes Please add a test case. > > This fixes bug #27115 and similar. > > Note that this is just a minor improvement. The entire implementation should > be changed to follow the IE way: > http://msdn.microsoft.com/en-us/library/ms775147(v=vs.85).aspx > It mostly is except that page is full of mistakes (as proven by our tests). Jacek

1 0