January 2013 - Wine-Devel - list.winehq.org

Reload a DLL and _getptd returns zero
by Michael Ost Jan. 13, 2013

Jan. 13, 2013

Hi list, Does anyone know why _getptd() calls would return zero on a DLL that has been reloaded? Does something happen to the TLS used by _getptd? At Muse Research we have been struggling with a deep bug for years where there is a crash _sometimes_ if you load a DLL a second time. Finally (with a big tip of the hat to Julien Pommier at PianoTeq!) we have a test case that demonstrates a (if not _the_) crash. The sequence is: 1. [main] start a thread 2. [main] load a library 3. [thread] call std::cout<< from the library 4. [main] free the library 5. [main] reload the library 6. [thread] call std::cout<< from the library -> crash! It looks like the crash happens because the MSVCRT function _getptd() is returning zero in step 6. This is dereferenced and crashes. In windows, there is no crash. The library in question is using static vc runtime linkage, so _getptd() is linked in and I don't know exactly what it is doing. But Wine's MSVCRT implementation of _getptd() gets its data from TlsGetValue. And I can see that just before the crash there is a TlsGetValue call that returns zero. Looking at TlsGetValue(), there must be something wrong with the values in TlsSlots. Maybe they persist for DLLs in Windows in a way they don't for Wine...? Or maybe Wine doesn't reinitialize them the same way when the DLL is reloaded? Any hints, thoughts? clues? Thanks! -- Michael Ost

4 4

Re: comctl32/listview: fix icon spacing calculation
by Nikolay Sivov Jan. 13, 2013

Jan. 13, 2013

On 1/14/2013 00:00, Daniel Jelinski wrote: > -static DWORD LISTVIEW_SetIconSpacing(LISTVIEW_INFO *infoPtr, INT cx, INT cy) > +static DWORD LISTVIEW_SetIconSpacing(LISTVIEW_INFO *infoPtr, WORD cx, WORD cy) I don't really like it as WORD, what it really is a int value with special meaning reserved for -1. For 64bits and lParam == -1 you'll still get two -1 values. > + /* LPARAM = -1 - restore default processing */ > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, MAKELPARAM(-1,-1)); > +todo_wine > + expect(100, LOWORD(ret)); > + expect(0xFFFF, HIWORD(ret)); > + > + /* NOTE: -1 is not the same as MAKELPARAM(-1,-1) in 64bit listview */ > + if(sizeof(LPARAM) == 8) > + { > + ret = SendMessage(hwnd, LVM_SETICONSPACING, 0, -1); > +todo_wine { > + expect(0xFFFF, LOWORD(ret)); > + expect(0xFFFF, HIWORD(ret)); > + } > + } That means you should just use lParam == -1. Also this message is supposed to use MAKELONG apparently, not sure if it makes a difference.

1 0

Re: comctl32/listview: fix icon spacing calculation
by Marvin Jan. 13, 2013

Jan. 13, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23897 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH] advapi32: add RegSetKeyValue{A,W}
by Nikolay Sivov Jan. 13, 2013

Jan. 13, 2013

On 1/13/2013 09:27, danielfsantos(a)att.net wrote: > Adds RegSetKeyValue{A,W} to advapi32.dll > Refactors RegSetValue{A,W} to call RegSetKeyValue{A,W} > Fixes bug #32711 > --- > dlls/advapi32/advapi32.spec | 4 +- > dlls/advapi32/registry.c | 81 +++++++++++++++++++++++++++++++++---------- > 2 files changed, 64 insertions(+), 21 deletions(-) > > diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec > index 21357fa..336518b 100644 > --- a/dlls/advapi32/advapi32.spec > +++ b/dlls/advapi32/advapi32.spec > @@ -645,8 +645,8 @@ > # @ stub RegSaveKeyExW > @ stdcall RegSaveKeyW(long ptr ptr) > @ stdcall RegSetKeySecurity(long long ptr) > -# @ stub RegSetKeyValueA > -# @ stub RegSetKeyValueW > +@ stdcall RegSetKeyValueA(long str str long ptr long) > +@ stdcall RegSetKeyValueW(long str str long ptr long) This should use wstr. > +LSTATUS WINAPI RegSetValueW( HKEY hkey, LPCWSTR name, DWORD type, LPCWSTR data, DWORD count ) > +{ > + return RegSetKeyValueW(hkey, name, NULL, type, data, count); > +} Don't use tabs please. And as I said in bug comment this needs tests.

1 0

Re: libwine: Use rpath-based install name and library references for libwine on Mac.
by Alexandre Julliard Jan. 12, 2013

Jan. 12, 2013

Ken Thomases <ken(a)codeweavers.com> writes: > --- > configure.ac | 3 ++- > libs/wine/Makefile.in | 6 +++--- > 2 files changed, 5 insertions(+), 4 deletions(-) It doesn't seem to work when installed: wine: failed to initialize: dlopen(/usr/local/lib/wine/ntdll.dll.so, 258): image not found -- Alexandre Julliard julliard(a)winehq.org

2 4

Problem with editing FAQ and other pages at wiki
by Romanoff Alexei Jan. 12, 2013

Jan. 12, 2013

Hello! I've tried editing wine FAQ and several other wiki pages, but failed. When I click on "Preview" or "Save" buttons, I always see error message like [Errno 31] Too many links: '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' If you want to report a bug, please save this page and attach it to your bug report. A problem occurred in a Python script. Here is the sequence of function calls leading up to the error, in the order they occurred. 1. /usr/lib/python2.4/site-packages/MoinMoin/request.py in *run* (self=<MoinMoin.request.RequestModPy object>) 1. 1170 self.page.send_page(self, msg=msg) 2. 1171 else: 3. 1172 handler(self.page.page_name, self) 4. 1173 5. 1174 # generate page footer (actions that do not want this footer use - *handler* = <function do_edit> - *self* = <MoinMoin.request.RequestModPy object> - self.*page* = <MoinMoin.Page.Page instance> - self.page.*page_name* = u'FAQ' 2. /usr/lib/python2.4/site-packages/MoinMoin/wikiaction.py in *do_edit* (pagename=u'FAQ', request=<MoinMoin.request.RequestModPy object>) 1. 651 request.form.has_key('button_spellcheck') or 2. 652 request.form.has_key('button_newwords')): 3. 653 pg.sendEditor(preview=savetext, comment=comment) 4. 654 5. 655 # Preview with mode switch - *pg* = <MoinMoin.PageEditor.PageEditor instance> - pg.*sendEditor* = <bound method PageEditor.sendEditor of <MoinMoin.PageEditor.PageEditor instance>> - preview *undefined* - *savetext* = u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n" - *comment* = u'Fixed shell code example with invalid redirection of stderr to stdout instead of file' 3. /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in *sendEditor* (self=<MoinMoin.PageEditor.PageEditor instance>, **kw={'comment': u'Fixed shell code example with invalid redirection of stderr to stdout instead of file', 'preview': u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n"}) 1. 284 # Make backup on previews - but not for new empty pages 2. 285 if preview and raw_body: 3. 286 self._make_backup(raw_body) 4. 287 5. 288 # Generate default content for new pages - *self* = <MoinMoin.PageEditor.PageEditor instance> - self.*_make_backup* = <bound method PageEditor._make_backup of <MoinMoin.PageEditor.PageEditor instance>> - *raw_body* = u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n" 4. /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in *_make_backup* (self=<MoinMoin.PageEditor.PageEditor instance>, newtext=u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n", **kw={}) 1. 738 intro += _('## backup of page "%(pagename)s" submitted %(date)s') % { 2. 739 'pagename': pagename, 'date': date,} + u'\n' 3. 740 backuppage._write_file(intro + newtext) 4. 741 5. 742 return backuppage.url(self.request) - *backuppage* = <MoinMoin.PageEditor.PageEditor instance> - backuppage.*_write_file* = <bound method PageEditor._write_file of <MoinMoin.PageEditor.PageEditor instance>> - *intro* = u'#acl AlexeiRomanoff:read,write,delete All:\n\n' - *newtext* = u"#pragma section-numbers 1\n#language en\n'''''Tran..., it can delete your entire hard drive.\nDeleted/\n" 5. /usr/lib/python2.4/site-packages/MoinMoin/PageEditor.py in *_write_file* (self=<MoinMoin.PageEditor.PageEditor instance>, text=u'#acl AlexeiRomanoff:read,write,delete All:\n\n#pra..., it can delete your entire hard drive.\nDeleted/\n', action='SAVE', comment=u'', extra=u'') 1. 801 # The local log should be the standard edit log, not the 2. 802 # underlay copy log! 3. 803 pagelog = self.getPagePath('edit-log', use_underlay=0, isfile=1) 4. 804 llog = editlog.EditLog(self.request, filename=pagelog, 5. 805 uid_override=self.uid_override) - pagelog *undefined* - *self* = <MoinMoin.PageEditor.PageEditor instance> - self.*getPagePath* = <bound method PageEditor.getPagePath of <MoinMoin.PageEditor.PageEditor instance>> - use_underlay *undefined* - isfile *undefined* 6. /usr/lib/python2.4/site-packages/MoinMoin/Page.py in *getPagePath* (self=<MoinMoin.PageEditor.PageEditor instance>, *args=('edit-log',), **kw={'isfile': 1, 'use_underlay': 0}) 1. 348 """Return path to the page storage area.""" 2. 349 3. 350 return self.getPageStatus(*args, **kw)[1] 4. 351 5. 352 def split_title(self, request, force=0): - *self* = <MoinMoin.PageEditor.PageEditor instance> - self.*getPageStatus* = <bound method PageEditor.getPageStatus of <MoinMoin.PageEditor.PageEditor instance>> - *args* = ('edit-log',) - *kw* = {'isfile': 1, 'use_underlay': 0} 7. /usr/lib/python2.4/site-packages/MoinMoin/Page.py in *getPageStatus* (self=<MoinMoin.PageEditor.PageEditor instance>, *args=('edit-log',), **kw={'isfile': 1, 'use_underlay': 0}) 1. 342 dirname = fullpath 2. 343 if not os.path.exists(dirname): 3. 344 filesys.makeDirs(dirname) 4. 345 return underlay, fullpath 5. 346 - *global* *filesys* = <module 'MoinMoin.util.filesys' from '/usr/lib/python2.4/site-packages/MoinMoin/util/filesys.pyc'> - filesys.*makeDirs* = <function makedirs> - *dirname* = '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' 8. /usr/lib/python2.4/site-packages/MoinMoin/util/filesys.py in *makedirs* (name='/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup', mode=511) 1. 49 return 2. 50 try: 3. 51 os.mkdir(name, mode & config.umask) 4. 52 except OSError, err: 5. 53 if err.errno != errno.EEXIST: - *global* *os* = <module 'os' from '/usr/lib/python2.4/os.pyc'> - os.*mkdir* = <built-in function mkdir> - *name* = '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' - *mode* = 511 - *global* *config* = <module 'MoinMoin.config' from '/usr/lib/python2.4/site-packages/MoinMoin/config.pyc'> - config.*umask* = 504 OSError [Errno 31] Too many links: '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' - args = (31, 'Too many links') - errno = 31 - filename = '/var/www/wine/wiki/data/pages/AlexeiRomanoff(2f)MoinEditorBackup' - strerror = 'Too many links' It seems, something wrong happened at server side with MoinMoin. But how could be possible to contribute, if wiki isn't editable? I haven't found any specific mailing list or forum for wiki editors and decided to write here. -- Best regards, Alexei Romanoff software developer, Melesta

3 4

Re: Ken Thomases : libwine: Use rpath-based install name and library references for libwine on Mac.
by Charles Davis Jan. 11, 2013

Jan. 11, 2013

On Jan 11, 2013, at 12:46 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: f377591e98c490ca00e6479627832e41b2ad01b9 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=f377591e98c490ca00e647962… > > Author: Ken Thomases <ken(a)codeweavers.com> > Date: Fri Jan 11 03:25:07 2013 -0600 > > libwine: Use rpath-based install name and library references for libwine on Mac. Huh? I thought this broke running installed Wine for you. Why did you commit this anyway? (Or is there another email message that I didn't see? Gmail has been acting wonky lately about delivering my email...) Chip

2 1

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation.
by Vincent Povirk Jan. 11, 2013

Jan. 11, 2013

You appear to be leaking the IWICBitmapLock object. Also, it seems odd that you're using the buffer AND IWICBitmapLock. I assume the point of passing a buffer to BitmapImpl_Create (and wasting a bit of time/memory) was to avoid IWICBitmapLock.

2 1

Re: kernel32/tests : try3 added tests for copyfileex
by Dmitry Timoshkov Jan. 11, 2013

Jan. 11, 2013

Patrick Rudolph <siro(a)das-labor.org> wrote: > + if (!pCopyFileExA) > + win_skip("CopyFileExA is not available\n"); Continuing at this point doesn't seem much useful. Also you need to use pCopyFileExA instead of direct CopyFileExA calls everywhere in the test, otherwise .exe won't even load under Windows due to dynamic linking errors. Sorry, I missed that in previous review. -- Dmitry.

1 0

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation. Resend.
by Vincent Povirk Jan. 11, 2013

Jan. 11, 2013

I hadn't noticed you had resent this, and made comments on the earlier mail which still apply.

1 0