January 2013 - Wine-Devel - list.winehq.org

Re: kernel32/tests : try3 added tests for copyfileex
by Marvin Jan. 11, 2013

Jan. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23881 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/2] d3d9: Return D3D_OK from the palette setters
by Henri Verbeet Jan. 11, 2013

Jan. 11, 2013

On 11 January 2013 09:49, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - * Copyright 2006-2007, 2010 Stefan Dösinger for CodeWeavers > + * Copyright 2006-2008,2010-2011,2013 Stefan Dösinger for CodeWeavers I'm going to assume you're changing this because you checked it, but the formatting is a bit off. > + memset(&caps, 0, sizeof(caps)); That's redundant.

2 2

Re: [PATCH 2/2] d3d8: Return D3D_OK from the palette setters (try 2)
by Marvin Jan. 11, 2013

Jan. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23877 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Merge surface.c into device.c.
by Marvin Jan. 11, 2013

Jan. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23875 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 4/5] d3d9/tests: Merge texture.c into device.c.
by Marvin Jan. 11, 2013

Jan. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23874 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [2/2] windowscodecs: Implement CreateBitmapFromHICON, based on a gdiplus implementation. Resend.
by Marvin Jan. 11, 2013

Jan. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23872 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [1/2] windowscodecs: Add a test for CreateBitmapFromHICON. Take 2.
by Marvin Jan. 11, 2013

Jan. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23871 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] d3dx9_36: Implement ID3DXFileDataImpl_Lock and ID3DXFileDataImpl_Unlock.
by Rico Schüller Jan. 11, 2013

Jan. 11, 2013

On 11.01.2013 09:40, Christian Costa wrote: > static HRESULT WINAPI ID3DXFileDataImpl_Unlock(ID3DXFileData *iface) > { > - FIXME("(%p)->(): stub\n", iface); > + TRACE("(%p)->()\n", iface); > > - return E_NOTIMPL; > + /* Nothing to do */ > + > + return S_OK; > } Hi Christian, I stumble over MSDN, it says in Remarks on http://msdn.microsoft.com/de-de/library/windows/desktop/bb205846%28v=vs.85%… ... from that sentence I'd think that you have to do some lock count. A test would probably be nice. Though, msdn has a bool as return value for the unlock function but in the header it's a HRESULT... Is msdn wrong here? Cheers Rico

2 1

Re: [1/2] windowscodecs: Add a test for CreateBitmapFromHICON.
by Nikolay Sivov Jan. 11, 2013

Jan. 11, 2013

On 1/11/2013 14:39, Dmitry Timoshkov wrote: > + icon = CreateIconIndirect(&info); > + ok(icon != 0, "CreateIconIndirect failed\n"); > + DeleteObject(info.hbmColor); > + DeleteObject(info.hbmMask); > + > + hr = IWICImagingFactory_CreateBitmapFromHICON(factory, icon, &bitmap); > + ok(hr == S_OK, "CreateBitmapFromHICON error %#x\n", hr); > + > + IWICBitmap_GetPixelFormat(bitmap, &format); > + ok(IsEqualGUID(&format, &GUID_WICPixelFormat32bppBGRA), > + "unexpected pixel format %s\n", debugstr_guid(&format)); > + > + IWICBitmap_GetSize(bitmap, &width, &height); > + ok(hr == S_OK, "IWICBitmap_GetSize error %#x\n", hr); > + ok(width == 16, "expected 16, got %u\n", width); > + ok(height == 16, "expected 16, got %u\n", height); > + > + IWICBitmap_Release(bitmap); > +} Who is responsible for freeing icon handle? I guess it should be done here cause your implementation doesn't free it either.

3 4

Re: [PATCH 6/6] msvcrt: Added fwprintf tests
by Marvin Jan. 11, 2013

Jan. 11, 2013

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23870 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0