September 2014 - Wine-Devel

Re: [PATCH 1/5] gdi32: Don't overflow the buffer in GetGlyphOutline.
by Alexandre Julliard Sept. 30, 2014

Sept. 30, 2014

Matteo Bruni <mbruni(a)codeweavers.com> writes: > The code already mixes tabs and spaces; since newer stuff seems to be > using spaces I'm using spaces for the new code too. I'm cleaning up the > lines nearby while at it. > It's quite a bit of code motion, hopefully the actual changes are still > readable enough. It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M d3dx9_36.dll -p d3dx9_36_test.exe.so mesh && touch mesh.ok mesh.c:4199: Test failed: Expected: 0, Got: 0.637207 mesh.c:4200: Test failed: Expected: 632928, Got: 0.464355 mesh.c:4201: Test failed: Expected: 0, Got: 0.00195312 mesh.c:4202: Test failed: Expected: 0, Got: 0.464355 mesh.c:4203: Test failed: Expected: 0, Got: 0.645508 mesh.c:4199: Test failed: Expected: 0, Got: 0.0786133 mesh.c:4200: Test failed: Expected: 632928, Got: 0.640625 ... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/5] wined3d: Fail to create shaders using more than the supported number of float constants.
by Henri Verbeet Sept. 30, 2014

Sept. 30, 2014

On 30 September 2014 14:51, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + case WINED3D_SHADER_VERSION(1, 0): > + case WINED3D_SHADER_VERSION(1, 1): > + shader->limits.constant_bool = 0; > + shader->limits.constant_int = 0; > + shader->limits.packed_output = 12; > + shader->limits.sampler = 0; > + /* TODO: vs_1_1 has a minimum of 96 constants. What happens when > + * a vs_1_1 shader is used on a vs_3_0 capable card that has 256 > + * constants? */ > + shader->limits.constant_float = min(256, vs_uniform_count); Since you touched it... Perhaps at least as interesting as what happens when trying to create SM3 shaders that use more that 256 constants is what happens when trying to create e.g. SM1 shaders that use more than 96 constants. Also note that aside from the somewhat questionable clamping of "constant_float" to the uniform count, this is all just static const data, and there's really no reason that every single shader needs its own copy of it. I don't think there are a lot of users of "constant_float" that don't already do that kind of clamping themselves, so we should probably just fix the remaining ones, if any. > + switch (reg_maps->shader_version.type) > + { > + case WINED3D_SHADER_TYPE_VERTEX: > + vertexshader_set_limits(shader); > + break; > + case WINED3D_SHADER_TYPE_GEOMETRY: > + geometryshader_set_limits(shader); > + break; > + case WINED3D_SHADER_TYPE_PIXEL: > + pixelshader_set_limits(shader); > + break; > + default: > + FIXME("Unexpected shader type %u found.\n", reg_maps->shader_version.type); > + } > + > reg_maps->constf = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > sizeof(*reg_maps->constf) * ((constf_size + 31) / 32)); But now you can use "shader->limits.constant_float" instead of "constf_size".

2 1

Re: [PATCH 6/6] jscript: Added @set tests.
by Marvin Sept. 30, 2014

Sept. 30, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9140 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/5] gdi32/tests: Add a test for GetGlyphOutline with an insufficient buffer.
by Marvin Sept. 30, 2014

Sept. 30, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9137 Your paranoid android. === wvistau64 (32 bit font) === The test timed out

2 1

Re: [PATCH] vbscript: Implemented RGB(try 4)
by Marvin Sept. 30, 2014

Sept. 30, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9135 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/3] user32: Add initial WindowFromPoint tests
by Dmitry Timoshkov Sept. 30, 2014

Sept. 30, 2014

Hi Piotr, Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/user32/tests/win.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) There already exist the tests for RealChildWindowFromPoint with a FIXME about adding new tests for WindowFromPoint, ChildWindowFromPoint and ChildWindowFromPointEx, is it possible to use existing tests as a base and extend them as needed? -- Dmitry.

2 1

Re: [PATCH 1/3] mshtml: Use proper type for text node in exec_hyperlink.
by Michael Stefaniuc Sept. 30, 2014

Sept. 30, 2014

On 09/30/2014 10:12 AM, Jacek Caban wrote: > --- dlls/mshtml/editor.c | 7 ++++--- 1 file changed, 4 > insertions(+), 3 deletions(-) > > > > 0001-mshtml-Use-proper-type-for-text-node-in-exec_hyperlin.diff > > > diff --git a/dlls/mshtml/editor.c b/dlls/mshtml/editor.c index > 14aab53..779dcc7 100644 --- a/dlls/mshtml/editor.c +++ > b/dlls/mshtml/editor.c @@ -1170,13 +1170,14 @@ static HRESULT > exec_hyperlink(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, > > /* create an element with text of URL */ if (insert_link_at_caret) > { - nsIDOMNode *text_node, *unused_node; + nsIDOMNode > *unused_node; + nsIDOMText *text_node; > > nsIDOMHTMLDocument_CreateTextNode(This->doc_node->nsdoc, &ns_url, > (nsIDOMText **)&text_node); Jacek, you don't need the above cast anymore. > /* wrap the <a> tags around the text element */ - > nsIDOMHTMLElement_AppendChild(anchor_elem, text_node, > &unused_node); - nsIDOMNode_Release(text_node); + > nsIDOMHTMLElement_AppendChild(anchor_elem, (nsIDOMNode*)text_node, > &unused_node); + nsIDOMText_Release(text_node); > nsIDOMNode_Release(unused_node); } bye michael

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByName
by Marvin Sept. 29, 2014

Sept. 29, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9131 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByName
by Nikolay Sivov Sept. 29, 2014

Sept. 29, 2014

On 9/30/2014 08:08, Alistair Leslie-Hughes wrote: > + *pdwBufferSize = entry->size; > + > + if(*pdwBufferSize < entry->size) > + return DPNERR_BUFFERTOOSMALL; Looks broken.

1 0

Re: wpp: Fix a few memory leaks
by Alexandre Julliard Sept. 29, 2014

Sept. 29, 2014

Fabian Ebner <f.ebner94(a)gmail.com> writes: > Fixes bug 37130 where it was discovered. You can't do that, the buffer is on the buffer stack. -- Alexandre Julliard julliard(a)winehq.org

2 1