September 2014 - Wine-Devel

Re: [2/2] shell32: Implement IApplicationAssociationRegistration, QueryCurrentDefault
by Nikolay Sivov Sept. 28, 2014

Sept. 28, 2014

> + hr = CoCreateInstance(&CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC_SERVER, > + &IID_IApplicationAssociationRegistration, (LPVOID*)&appreg); > + if (FAILED(hr)) { > + skip("IApplicationAssociationRegistration not created: 0x%x\n", hr); > + return; > + } Just check it with ok(), missing implementation is already checked in START_TEST(). > + trace("%s\n", wine_dbgstr_w(assocprog)); Do you really need this? > - test_IApplicationAssociationRegistration_QueryInterface(); > + /* this works since Vista */ > + hr = CoCreateInstance(&CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC_SERVER, > + &IID_IApplicationAssociationRegistration, (LPVOID*)&appreg); > + if (hr == S_OK) > + { > + test_IApplicationAssociationRegistration_QueryInterface(); > + test_IApplicationAssociationRegistration_QueryCurrentDefault(); > + > + IApplicationAssociationRegistration_Release(appreg); > + } > + else > + skip("IApplicationAssociationRegistration not supported: 0x%x\n", hr); This should be win_skip().

1 0

Re: Assorted spelling fixes.
by Marvin Sept. 28, 2014

Sept. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9111 Your paranoid android. === w8 (32 bit device) === device.c:2398: Test failed: Expected foreground window 000301E4, got 0002004C. device.c:3040: Test failed: Expected wndproc 0x412cf0, got 0x412cf0.

1 0

Re: Assorted spelling fixes.
by Marvin Sept. 28, 2014

Sept. 28, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9103 Your paranoid android. === wvistau64 (32 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR === wvistau64 (64 bit shlfileop) === shlfileop.c:815: Test failed: Expected ERROR_CANCELLED or DE_DIFFDIR

1 0

Re: [PATCH] vbscript: Implemented RGB (try 3)
by Qian Hong Sept. 26, 2014

Sept. 26, 2014

Hi Shuai, > Call ok(RGB(0, &h00001f&, &h0000f1&) = &hf11f00&, " I think Call ok(RGB(0, &h1f&, &hf1&) = &hf11f00&, "... is better and clearer.

2 1

Re: [PATCH] jscript: Implemented conditional compilation support for @if, @elif, @else and @end keywords.
by Jacek Caban Sept. 26, 2014

Sept. 26, 2014

Hi Qian, On 09/26/14 07:17, Qian Hong wrote: > This patch improves QQDownload on Wine. Most of parser code and > compiler code for '@if statement' are implemented based on the Wine > vbscript implementation of 'if statement' since Microsoft JScript > conditional compilation '@if statement' shares similar syntax with > vbscript 'if statement'. Not really, @if causes conditional compilation. Your patch unconditionally compiles everything. See my simple test on top of your patch for what I mean. Jacek

2 1

Re: [PATCH] jscript: Implemented conditional compilation support for @if, @elif, @else and @end keywords.
by Marvin Sept. 26, 2014

Sept. 26, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9084 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Implemented RGB (try 3)
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9072 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 10/10] ddraw/tests: Test focus loss style changes.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9071 Your paranoid android. === w8 (32 bit ddraw1) === ddraw1.c:1318: Test failed: Expected color 0x00ff0000 for test 0, got 0x0000ff00. ddraw1.c:1340: Test failed: Expected color 0x000000ff for test 0, got 0x0000ff00.

1 0

Re: [PATCH 09/10] d3d/tests: Add focus loss style tests.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9070 Your paranoid android. === w2000pro (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (64 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (64 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6.

1 0

Re: [PATCH 09/10] d3d/tests: Add focus loss style tests.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9069 Your paranoid android. === w2000pro (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === w8 (32 bit device) === device.c:2388: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2393: Test failed: The focus window is active. device.c:2426: Test failed: Expected message 0x6 for window 0x1, but didn't receive it.

1 0