September 2014 - Wine-Devel

Re: [PATCH 08/10] d3d/tests: Additional swapchains are only allowed in windowed mode.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9068 Your paranoid android. === w2000pro (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (64 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (64 bit device) === device.c:3154: Test failed: Got unexpected wparam 0 for message 6.

1 0

Re: [PATCH 08/10] d3d/tests: Additional swapchains are only allowed in windowed mode.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9067 Your paranoid android. === w2000pro (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:2193: Test failed: Got unexpected wparam 0 for message 6. === w8 (32 bit device) === device.c:2388: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2393: Test failed: The focus window is active. device.c:2426: Test failed: Expected message 0x6 for window 0x1, but didn't receive it.

1 0

Re: [PATCH 07/10] wined3d: Do not minimize invisible windows.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9066 Your paranoid android. === w2000pro (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (64 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (64 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6.

1 0

Re: [PATCH 07/10] wined3d: Do not minimize invisible windows.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9065 Your paranoid android. === w2000pro (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === w8 (32 bit device) === device.c:2341: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2346: Test failed: The focus window is active. device.c:2379: Test failed: Expected message 0x6 for window 0x1, but didn't receive it.

1 0

Re: [PATCH 06/10] d3d8/tests: Test messages on focus loss.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9064 Your paranoid android. === w2000pro (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:2146: Test failed: Got unexpected wparam 0 for message 6. === w8 (32 bit device) === device.c:2321: Test failed: Expected message 0x6 for window 0x1, but didn't receive it. device.c:2326: Test failed: The focus window is active. device.c:2332: Test failed: Got unexpect width 640. device.c:2333: Test failed: Got unexpect height 480. device.c:2472: Test failed: Expected foreground window 000B00CA, got 0002004C. device.c:3114: Test failed: Expected wndproc 0x413050, got 0x413050.

1 0

Re: d3d10core: Add support for map_type flags D3D10_MAP_READ, D3D10_MAP_WRITE_NO_OVERWRITE and D3D10_MAP_DISCARD. (try 2)
by Henri Verbeet Sept. 25, 2014

Sept. 25, 2014

On 24 September 2014 17:06, Johannes Brandstätter <jbrandst(a)2ds.eu> wrote: > + DWORD wine_map_flags = wined3d_map_flags_from_d3d10_map_type(map_type); > > TRACE("iface %p, map_type %u, map_flags %#x, data %p.\n", iface, map_type, map_flags, data); > > - if (map_type != D3D10_MAP_READ_WRITE) > - FIXME("Ignoring map_type %#x.\n", map_type); > if (map_flags) > FIXME("Ignoring map_flags %#x.\n", map_flags); > > - return wined3d_buffer_map(buffer->wined3d_buffer, 0, 0, (BYTE **)data, 0); > + return wined3d_buffer_map(buffer->wined3d_buffer, 0, 0, (BYTE **)data, wine_map_flags); You don't really need the wine_map_flags variable here. > +DWORD wined3d_map_flags_from_d3d10_map_type(D3D10_MAP map_type) > +{ > + switch (map_type) > + { > + case D3D10_MAP_READ_WRITE: > + return 0; > + > + case D3D10_MAP_READ: > + return WINED3D_MAP_READONLY; > + > + case D3D10_MAP_WRITE_DISCARD: > + return WINED3D_MAP_DISCARD; > + > + case D3D10_MAP_WRITE_NO_OVERWRITE: > + return WINED3D_MAP_NOOVERWRITE; > + > + default: > + FIXME("Unhandled map_type %#x.\n", map_type); > + } > + > + return 0; You can just return in the default case.

1 0

Re: [PATCH 04/10] d3d9/tests: Test messages on focus loss.
by Marvin Sept. 25, 2014

Sept. 25, 2014

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=9062 Your paranoid android. === w2000pro (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === wxppro (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === w7u (32 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === wvistau64 (64 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6. === w2008s64 (64 bit device) === device.c:3107: Test failed: Got unexpected wparam 0 for message 6.

1 0

Question about implementing a test for BCryptGetFipsAlgorithmMode
by Kai Blaschke Sept. 24, 2014

Sept. 24, 2014

Hi, I had a small patch lying around here for some while which properly implements the BCryptGetFipsAlgorithmMode function, behaving identically to the original implementation. Just one question is bugging me, regarding the test. To properly test the function, I'd have to write to a registry key in HKLM\System\CurrentControlSet\Control\Lsa. Is it safe to assume that the test has write access to this key? Additionally, I noticed I put a small bug in the code, returning false for all registry values which are multiples of 256, which is a result of simply casting a registry DWORD value to a BOOLEAN. To my surprise, the original function - tested with WinXP and Win7 - has the same bug, so I wouldn't fix my implementation before sending in the patch if no one votes against it. Regards Kai

3 5

Re: [PATCH 4/5] d3d9/tests: Extend focus loss tests.
by Henri Verbeet Sept. 24, 2014

Sept. 24, 2014

I don't think the tests really support the implementation. For example, they don't test multiple swapchains at all, and they basically only test if WS_MINIMIZE is set or not as far as window styles are concerned. I'd expect at least some basic message and style tests along the lines of e.g. test_wndproc() and test_window_style().

2 3

Re: dpvoice: Add DirectPlay Voice Test (try 2)
by Alexandre Julliard Sept. 24, 2014

Sept. 24, 2014

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Fix errors on systems which don't have Direct Voice configured. > > Changelog: > dpvoice: Add DirectPlay Voice Test It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M dpvoice.dll -p dpvoice_test.exe.so voice && touch voice.ok voice.c:106: Test succeeded inside todo block: AddComponent(addr) with 0x00000000 voice.c:109: Test succeeded inside todo block: AddComponent(port)) with 0x00000000 voice.c:187: Test succeeded inside todo block: AddComponent(addr) with 0x00000000 voice.c:190: Test succeeded inside todo block: AddComponent(port)) with 0x00000000 make: *** [voice.ok] Error 4 -- Alexandre Julliard julliard(a)winehq.org

1 0