October 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 5/5] wined3d: Use the core version of the debug messages functions.
by Henri Verbeet Oct. 22, 2015

Oct. 22, 2015

On 22 October 2015 at 00:21, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Fixes bug 39478. > > Do we want to introduce some additional tag for this kind of info? > In general, no. The way you search for bugs fixed by a particular commit is to search for the commit ID in bugzilla. Bug ID's aren't necessarily stable over the lifetime of the git repository, and for Wine in particular it isn't necessarily clear beforehand what bugs a patch is going to fix. I also would have preferred a (short) description of the issue in the commit message over having to look it up in bugzilla.

1 0

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Sebastian Lackner Oct. 22, 2015

Oct. 22, 2015

On 21.10.2015 02:43, Hugh McMaster wrote: > + if (osvi.dwMajorVersion >= 6) /* Windows Vista or higher */ > + { > + COORD c; > + c = GetConsoleFontSize(std_output, cfi.nFont); > + todo_wine ok(cfi.dwFontSize.X == c.X, "got %d, expected %d\n", cfi.dwFontSize.X, c.X); > + todo_wine ok(cfi.dwFontSize.Y == c.Y, "got %d, expected %d\n", cfi.dwFontSize.Y, c.Y); > + } > + else > + { > + CONSOLE_SCREEN_BUFFER_INFO csbi; > + short int width, height; > + GetConsoleScreenBufferInfo(std_output, &csbi); > + width = csbi.srWindow.Right - csbi.srWindow.Left + 1; > + height = csbi.srWindow.Bottom - csbi.srWindow.Top + 1; > + ok(cfi.dwFontSize.X == width, "got %d, expected %d\n", cfi.dwFontSize.X, width); > + ok(cfi.dwFontSize.Y == height, "got %d, expected %d\n", cfi.dwFontSize.Y, height); > + } I haven't reviewed the whole patch, but wanted to point that we usually do not test or implement Windows version specific behavior, unless an application depends on it. Often only one of both is implemented, and the other version is marked as broken. If you decide to implement the pre-Vista behavior (which would make sense, because Wine still uses WinXP as default version), it seems like no wineserver changes are required at all (at least as long as font.index is always 0).

3 2

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1 (try 2)
by Marvin Oct. 22, 2015

Oct. 22, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17563 Your paranoid android. === wvistau64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w2008s64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w7u (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w7pro64 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w8 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w864 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w1064 (32 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === wvistau64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w2008s64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x8007000e. d3d10_1.c:417: Test failed: got 0x8007000e. === w7pro64 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w864 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002. === w1064 (64 bit d3d10_1) === d3d10_1.c:410: Test failed: got 0x80004002. d3d10_1.c:417: Test failed: got 0x80004002.

1 0

Re: [PATCH] vbscript/tests Add array out of bounds test
by Jacek Caban Oct. 22, 2015

Oct. 22, 2015

Hi Alistair, On 10/20/15 10:05, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/vbscript/tests/lang.vbs | 5 +++++ > dlls/vbscript/tests/run.c | 17 ++++++++++++++++- > 2 files changed, 21 insertions(+), 1 deletion(-) This seems more complicated than it has to be. Is there any reason you don't use parse_script_ar helper? Thanks, Jacek

2 1

Re: [PATCH 6/6] dxgi/tests: Remove test_device_interfaces().
by Marvin Oct. 22, 2015

Oct. 22, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17561 Your paranoid android. === w1064 (32 bit device) === device.c:1141: Test failed: Got unexpected hr 0, test 16. device.c:1141: Test failed: Got unexpected hr 0x87a0001, test 39. === w1064 (64 bit device) === device.c:1195: Test failed: Got usage 160, expected 60, test 28, buffer 1. device.c:1195: Test failed: Got usage 160, expected 60, test 29, buffer 2. device.c:1195: Test failed: Got usage 160, expected 60, test 35, buffer 1. device.c:1195: Test failed: Got usage 160, expected 60, test 36, buffer 2. device.c:1141: Test failed: Got unexpected hr 0, test 39. device.c:1195: Test failed: Got usage 160, expected 60, test 41, buffer 15. device.c:1195: Test failed: Got usage 160, expected 60, test 42, buffer 15.

1 0

Re: [PATCH] quartz: show fixme for Parser_OutputPin_QueryInterface only once
by Nikolay Sivov Oct. 21, 2015

Oct. 21, 2015

On 20.10.2015 21:56, Jonas Maebe wrote: > This prevents the game Majesty Gold HD from flooding the console with > "No interface for {56a868a5-0ad4-11ce-b03a-0020af0ba770}" messages. > > Signed-off-by: Jonas Maebe <jonas.maebe(a)elis.ugent.be> > --- > dlls/quartz/parser.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dlls/quartz/parser.c b/dlls/quartz/parser.c > index cd8d93d..a9384a5 100644 > --- a/dlls/quartz/parser.c > +++ b/dlls/quartz/parser.c > @@ -634,6 +634,7 @@ static HRESULT WINAPI Parser_OutputPin_BreakConnect(BaseOutputPin *This) > > static HRESULT WINAPI Parser_OutputPin_QueryInterface(IPin * iface, REFIID riid, LPVOID * ppv) > { > + static int once = 0; > Parser_OutputPin *This = unsafe_impl_Parser_OutputPin_from_IPin(iface); > > TRACE("(%s, %p)\n", qzdebugstr_guid(riid), ppv); > @@ -654,7 +655,11 @@ static HRESULT WINAPI Parser_OutputPin_QueryInterface(IPin * iface, REFIID riid, > return S_OK; > } > > - FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); > + if (!once) > + { > + FIXME("No interface for %s!\n", qzdebugstr_guid(riid)); > + once = 1; > + } > > return E_NOINTERFACE; > } > This is too much, because it will disable every failed QI fixme after first one. Base output pin already supports IQualityControl case, by forwarding it. So proper fix is to try to write some tests for this pin implementation to see if it's supposed to be supported, and then act from there.

2 3

Re: [PATCH] configure: Check for linker relocation support before relying on prelink
by Alexandre Julliard Oct. 21, 2015

Oct. 21, 2015

Michael Cronenworth <mike(a)cchtml.com> writes: > @@ -1167,8 +1173,9 @@ static void build(struct options* opts) > spawn(opts->prefix, link_args, 0); > strarray_free (link_args); > > - /* set the base address */ > - if (opts->image_base && !opts->target) > + /* set the base address with prelink if linker support is not present */ > + if (opts->image_base && !opts->target && > + try_link(opts->prefix, link_args, strmake("-Wl,-Ttext-segment=%s", opts->image_base))) It looks OK now, but please avoid calling try_link() twice for the same check. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] d3d10_1: Implement D3D10CreateDeviceAndSwapChain1
by Henri Verbeet Oct. 21, 2015

Oct. 21, 2015

On 21 October 2015 at 05:25, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > --- > dlls/d3d10_1/d3d10_1.spec | 2 +- > dlls/d3d10_1/d3d10_1_main.c | 68 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 69 insertions(+), 1 deletion(-) > Tests, please.

1 0

Re: [PATCH 1/2] kernel32/tests: Add tests for GetCurrentConsoleFont (v2)
by Marvin Oct. 21, 2015

Oct. 21, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17535 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: fltmgr.sys: add FltInitializePushLock stub (try 4)
by Dmitry Timoshkov Oct. 21, 2015

Oct. 21, 2015

Austin English <austinenglish(a)gmail.com> wrote: > +void WINAPI FltInitializePushLock( PEX_PUSH_LOCK *lock ) According to MSDN this is wrong. -- Dmitry.

1 0