October 2015 - Wine-Devel - list.winehq.org

Re: [PATCH] usp10/tests: Use BOOL variable for BOOL retval (PVS-Studio)
by Marvin Oct. 20, 2015

Oct. 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17515 Your paranoid android. === w1064 (32 bit usp10) === usp10.c:1244: Test failed: 0: uJustification incorrect (0) usp10.c:1244: Test failed: 1: uJustification incorrect (0) usp10.c:1244: Test failed: 2: uJustification incorrect (0) usp10.c:1244: Test failed: 3: uJustification incorrect (0) usp10.c:1244: Test failed: 4: uJustification incorrect (0) usp10.c:1244: Test failed: 5: uJustification incorrect (0) usp10.c:1244: Test failed: 6: uJustification incorrect (0) usp10.c:1244: Test failed: 7: uJustification incorrect (0) usp10.c:1244: Test failed: 8: uJustification incorrect (0) usp10.c:1244: Test failed: 9: uJustification incorrect (0) usp10.c:1260: Test failed: 3: uJustification incorrect (0) usp10.c:1260: Test failed: 5: fDiacritic incorrect (1) usp10.c:1260: Test failed: 5: fZeroWidth incorrect (1) usp10.c:1260: Test failed: 15: fDiacritic incorrect (1) usp10.c:1260: Test failed: 15: fZeroWidth incorrect (1)

2 1

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Marvin Oct. 20, 2015

Oct. 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17510 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1

Re: [RFC PATCH 1/2] msvcrt: Split simple string/memory routines to a separate file
by Alexandre Julliard Oct. 20, 2015

Oct. 20, 2015

Martin Storsjo <martin(a)martin.st> writes: > These are simple functions that don't touch the global CRT state > (not touching errno etc). These are functions that are part of > vcruntime140.dll in the new ucrtbase/vcruntime split. > > Signed-off-by: Martin Storsjo <martin(a)martin.st> > --- > I'm not sure if "memory" is the best filename here, other suggestions > are welcome. I don't think you need a separate file for this. Simply duplicate the handful of functions that you need inside vcruntime140. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ddraw/tests: Test the return of DrawPrimitive()
by Marvin Oct. 20, 2015

Oct. 20, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17507 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2183: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. ddraw7.c:3024: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3026: Test failed: Got unexpected screen width 1024. ddraw7.c:3028: Test failed: Got unexpected screen height 768. ddraw7.c:3041: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3043: Test failed: Got unexpected screen width 1024. ddraw7.c:3045: Test failed: Got unexpected screen height 768. ddraw7.c:3049: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3051: Test failed: Got unexpected screen width 1024. ddraw7.c:3053: Test failed: Got unexpected screen height 768. ddraw7.c:3072: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3074: Test failed: Got unexpected screen width 1024. ddraw7.c:3076: Test failed: Got unexpected screen height 768. ddraw7.c:3080: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3082: Test failed: Got unexpected screen width 1024. ddraw7.c:3084: Test failed: Got unexpected screen height 768. ddraw7.c:3104: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3106: Test failed: Got unexpected screen width 1024. ddraw7.c:3108: Test failed: Got unexpected screen height 768. ddraw7.c:3113: Test failed: Got unexpected screen width 1024. ddraw7.c:3115: Test failed: Got unexpected screen height 768. ddraw7.c:3128: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3130: Test failed: Got unexpected screen width 1024. ddraw7.c:3132: Test failed: Got unexpected screen height 768. ddraw7.c:3136: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3138: Test failed: Got unexpected screen width 1024. ddraw7.c:3140: Test failed: Got unexpected screen height 768. ddraw7.c:3148: Test failed: Got unexpected screen width 1024. ddraw7.c:3150: Test failed: Got unexpected screen height 768. ddraw7.c:3162: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3164: Test failed: Got unexpected screen width 1024. ddraw7.c:3166: Test failed: Got unexpected screen height 768. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4021: Test failed: Display mode restored after good ddraw1::SetCooperativeLevel call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4034: Test failed: Display mode restored after ddraw1::SetCooperativeLevel(SETFOCUSWINDOW) call ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4050: Test failed: Display mode restored after good-bad ddraw1::SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:4069: Test failed: Display mode restored after ddraw1-ddraw7 SetCooperativeLevel() call sequence ddraw7.c:3975: Test failed: Failed to set display mode, hr 0x80004001. ddraw7.c:5877: Test failed: Failed to set display mode, hr 0x80004001. === w864 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000 === w1064 (64 bit ddraw7) === ddraw7: unhandled exception c0000005 at 0000000000000000

2 1

Re: gdi32: Return default palette entries from GetSystemPaletteEntries for non-palette-based devices. (try 5)
by Huw Davies Oct. 20, 2015

Oct. 20, 2015

On 17 Oct 2015, at 16:35, Anton Baskanov wrote: > +static void test_system_palette_entries() You're missing a 'void' inside the parenthesis. Otherwise, this looks good. Huw.

1 0

Re: [PATCH] dpnet: Add Server tests
by Stefan Dösinger Oct. 19, 2015

Oct. 19, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, My apologies for the late review. I've been sick the past days and also had to put a lot of attention towards other stuff. Am 2015-10-13 um 11:05 schrieb Alistair Leslie-Hughes: > +static const WCHAR localhost[] = {'1','2','7','.','0','.','0','.','1',0}; Minor nitpick: Is there a reason why you use "127.0.0.1" instead of "localhost"? > +static int destroy_dnt = 0; What does "dnt" stand for? > +static HRESULT WINAPI DirectPlayMessageHandler(void *pvUserContext, DWORD dwMessageId, void *pMsgBuffer) You got rid of CamelCase in the global variables. Please do it here as well and call the function direct_play_message_handler or similar. Also avoid things like dwThisIsADword and pDidIMentionThisIsaPointer. > + case DPN_MSGID_INDICATE_CONNECT: > + trace("DPN_MSGID_CREATE_PLAYER\n"); Copy-paste mistake. > +static HRESULT WINAPI DirectPlayClientMsHandler(void *context, DWORD dwMessageId, void *buffer) "MsHandler"? > +{ > + HRESULT hr; > + > + switch(dwMessageId) > + { > + case DPN_MSGID_ENUM_HOSTS_RESPONSE: > + { > + DPNMSG_ENUM_HOSTS_RESPONSE *host_msg; > + host_msg = (PDPNMSG_ENUM_HOSTS_RESPONSE)buffer; PDPNMSG_ENUM_HOSTS_RESPONSE -> DPNMSG_ENUM_HOSTS_RESPONSE * please. > + memset(&hostdesc, 0, sizeof(DPN_APPLICATION_DESC)); You can use sizeof(hostdesc) instead of sizeof(DPN_APPLICATION_DESC) here. > + memcpy(&hostdesc, host_msg->pApplicationDescription, sizeof(DPN_APPLICATION_DESC) ); Same. > + hr = CoCreateInstance(&CLSID_DirectPlay8Client, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectPlay8Client, (void **)&client); > + ok(hr == S_OK, "CoCreateInstance failed with 0x%x\n", hr); > + if(hr != S_OK) > + return; You don't need the if() check here. If CoCreateInstance fails the test already failed and you can just let it crash. > + memset( &appdesc, 0, sizeof(DPN_APPLICATION_DESC) ); > + appdesc.dwSize = sizeof( DPN_APPLICATION_DESC ); > + appdesc.guidApplication = appguid; > + > + connect = CreateEventA( NULL, TRUE, FALSE, NULL); > + hostenum = CreateEventA( NULL, TRUE, FALSE, NULL); Inconsistent parenthesis placement. It seems the code was copypasted together from other places. > + hr = IDirectPlay8Client_Initialize(client, NULL, DirectPlayClientMsHandler, 0); > + ok(hr == S_OK, "IDirectPlay8Client_Initialize failed with %x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&host); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); > + > + hr = IDirectPlay8Address_SetSP(host, &CLSID_DP8SP_TCPIP); > + ok(hr == S_OK, "IDirectPlay8Address_SetSP failed with 0x%08x\n", hr); > + > + hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&device); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); You're using LPCRAP here again. I think you're not making any productive use of the address object you create here and you're leaking it. Later on you're creating a separate address and overwrite this one. > + hr = IDirectPlay8Address_AddComponent(host, DPNA_KEY_HOSTNAME, localhost, sizeof(localhost), > + DPNA_DATATYPE_STRING); > + ok(hr == S_OK, "IDirectPlay8Address failed with 0x%08x\n", hr); This is obviously something for a different patch / test, but do you know how the various components play together with the service provider? I'd assume that a Serial or Modem service provider requires different components than the TCPIP service provider. > @@ -109,5 +269,9 @@ START_TEST(server) > > create_server(); > > + create_client(); > + > + cleanup(); It is difficult to see what is going on by just reading the main function of the test. create_foo() and cleanup() suggest that they create / destroy helper objects, but all of them do a serious amount of testing. You cannot disable the tests separately without breaking the entire test. I'd suggest to have helper functions that create server and client and one enumeration test, a test for connecting to a server, ..., and call the creation functions in each individual test, similar to how e.g. create_device() is working in various d3d tests. This makes this patch more complicated, but it will be very helpful in the long run when more tests are added that need fresh objects. Sooner or later you'll also want to be able to disable individual tests for debugging and / or faster execution times if you work on a new test. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWJSi7AAoJEN0/YqbEcdMwz3sP/ArVZHXjUMVD45/bGbqJ7ZIX oKYP/GTHEBVJtA3EICapjIhN/92intcsQxtjYy0sK5ol4U2Yeg3HDon/PTSihEgC oK0cr1Jf8Z1lN7+kuIgDc4agMrW7UxAhBuJ4CqMFsOkLFbuem30VXnFj+/1VhCRC zYqhirihyFyH+8ac4g6kQLJBnPP5gtJ3YKbDYoE+LM0wF1eIUTfvcEuMfxp8tF4s gO4k7fpjvOzrf7J/z1MK/J+1OUQxvyGPp+HikZ8ZUXD16A6Dqwc7nATL3f+wMV85 JICLuXiyqV7slnkb0A2rIbMIM2Y5cF7pHAjz08thGYSWno+wJFXAcGtH12JPT1uD 61XQfh/lPZKXgeJRKwpwq3meztVVxzb1V4mfQsNWvi81nzEnu2VRvs8PZqAyR09E vU7yFNXq/cDikRN9NrtX/tTv7ZaHwM1HwZVqGzA+mB4vlQ8pApzycYLQh1sOVQRm g39eSq2qNx/7pk53G7Chxm/8sQ3Xa7s5D0F7PqvDTxlXA0xo8Q1r3+zH/NQDGvS8 UsKz0br6rRFdArpyzv9VUxF2Ynn+xig25JPk0ofbJx90H677kAJJ2QMyik4DOWGb sojlCQ0n9W5zR1kY3mbNWxa6mFiBsnexvoJ+eSiqnybkc+b+SDz1vJrSsOcKp1ys XUIIuCpcMtvVp85zcZG3 =/XJU -----END PGP SIGNATURE-----

1 0

Re: [PATCH 2/5] winepulse: Add format and period probing
by Alexandre Julliard Oct. 19, 2015

Oct. 19, 2015

Andrew Eikum <aeikum(a)codeweavers.com> writes: > From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > dlls/winepulse.drv/mmdevdrv.c | 128 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 128 insertions(+) It breaks the tests here: ../../../tools/runtest -q -P wine -T ../../.. -M devenum.dll -p devenum_test.exe.so devenum && touch devenum.ok wine: Unhandled page fault on execute access to 0x7dd57d70 at address 0x7dd57d70 (thread 0026), starting debugger... Unhandled exception: page fault on execute access to 0x7dd57d70 in 32-bit code (0x7dd57d70). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7dd57d70 ESP:0053e900 EBP:0053e928 EFLAGS:00010206( R- -- I - -P- ) EAX:00000000 EBX:7dd64260 ECX:00000087 EDX:7dd64830 ESI:7d6004b8 EDI:7dd64830 Stack dump: 0x0053e900: 7dd64830 0053e942 0000000a 7dce2a74 0x0053e910: 7d6004f8 7d6007f0 7dd57d5b 7dd1a000 0x0053e920: 7d6004b8 00000000 7dd57d50 7dce26d2 0x0053e930: 7d604e40 00000003 ffffffff 00000000 0x0053e940: 575704b8 57575757 0000009c 25aac200 0x0053e950: 0053e9e8 00000801 7dce2629 7dd1a000 Backtrace: =>0 0x7dd57d70 (0x0053e928) 1 0x7dce26d2 pa_mainloop_poll+0xb1() in libpulse.so.0 (0x7dd57d50) 2 0x7dce2def pa_mainloop_iterate+0x3e() in libpulse.so.0 (0x0053e9e8) 3 0x7dce2eac pa_mainloop_run+0x2b() in libpulse.so.0 (0x0053e9e8) 4 0x7dd57d18 (0x0053e9e8) 5 0x7bc7ea60 call_thread_func_wrapper+0xb() in ntdll (0x0053ea08) 6 0x7bc817cf call_thread_func+0xde(entry=0x7dd57cb0, arg=0x0(nil), frame=0x53eb08) [/home/julliard/wine/wine/dlls/ntdll/signal_i386.c:2732] in ntdll (0x0053eae8) 7 0x7bc7ea3e call_thread_entry_point+0x11() in ntdll (0x0053eb08) 8 0x7bc89483 start_thread+0xa2(info=0x7ffd4fb8) [/home/julliard/wine/wine/dlls/ntdll/thread.c:449] in ntdll (0x0053f358) 9 0xf755defb start_thread+0xca() in libpthread.so.0 (0x0053f428) 0x7dd57d70: -- no code accessible -- Modules: Module Address Debug info Name (108 modules) ELF 7b800000-7ba60000 Deferred kernel32<elf> \-PE 7b810000-7ba60000 \ kernel32 ELF 7bc00000-7bcec000 Dwarf ntdll<elf> \-PE 7bc10000-7bcec000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7d4f4000-7d600000 Deferred libasound.so.2 ELF 7d764000-7d794000 Deferred winealsa<elf> \-PE 7d770000-7d794000 \ winealsa ELF 7d794000-7d7c1000 Deferred libvorbis.so.0 ELF 7d7c1000-7d7ca000 Deferred libogg.so.0 ELF 7d7ca000-7d7df000 Deferred libgpg-error.so.0 ELF 7d7df000-7d852000 Deferred libpcre.so.3 ELF 7d852000-7d8de000 Deferred libvorbisenc.so.2 ELF 7d8de000-7d93f000 Deferred libflac.so.8 ELF 7d93f000-7d95c000 Deferred libgcc_s.so.1 ELF 7d95c000-7da0d000 Deferred libgcrypt.so.20 ELF 7da0d000-7da36000 Deferred liblzma.so.5 ELF 7da36000-7da4d000 Deferred libresolv.so.2 ELF 7da4d000-7da75000 Deferred libselinux.so.1 ELF 7da75000-7da7b000 Deferred libuuid.so.1 ELF 7da7b000-7da81000 Deferred libattr.so.1 ELF 7da81000-7da88000 Deferred libasyncns.so.0 ELF 7da88000-7db01000 Deferred libsndfile.so.1 ELF 7db01000-7db0b000 Deferred libwrap.so.0 ELF 7db0b000-7db97000 Deferred libsystemd.so.0 ELF 7db97000-7db9f000 Deferred libxtst.so.6 ELF 7db9f000-7dba9000 Deferred libsm.so.6 ELF 7dba9000-7dbc6000 Deferred libice.so.6 ELF 7dbc6000-7dbcf000 Deferred librt.so.1 ELF 7dbcf000-7dc2b000 Deferred libdbus-1.so.3 ELF 7dc2b000-7dcb5000 Deferred libpulsecommon-7.0.so ELF 7dcb5000-7dcc1000 Deferred libjson-c.so.2 ELF 7dcc1000-7dd1b000 Dwarf libpulse.so.0 ELF 7dd65000-7dd87000 Deferred mmdevapi<elf> \-PE 7dd70000-7dd87000 \ mmdevapi ELF 7dd87000-7ddbd000 Deferred uxtheme<elf> \-PE 7dd90000-7ddbd000 \ uxtheme ELF 7ddbd000-7de32000 Deferred shlwapi<elf> \-PE 7ddd0000-7de32000 \ shlwapi ELF 7de32000-7df2a000 Deferred comctl32<elf> \-PE 7de40000-7df2a000 \ comctl32 ELF 7df2a000-7df74000 Deferred dsound<elf> \-PE 7df30000-7df74000 \ dsound ELF 7df74000-7e061000 Deferred quartz<elf> \-PE 7df90000-7e061000 \ quartz ELF 7e061000-7e117000 Deferred winmm<elf> \-PE 7e070000-7e117000 \ winmm ELF 7e172000-7e175000 Deferred libx11-xcb.so.1 ELF 7e175000-7e19e000 Deferred msvfw32<elf> \-PE 7e180000-7e19e000 \ msvfw32 ELF 7e19e000-7e1c7000 Deferred msacm32<elf> \-PE 7e1a0000-7e1c7000 \ msacm32 ELF 7e1c7000-7e1db000 Deferred avicap32<elf> \-PE 7e1d0000-7e1db000 \ avicap32 ELF 7e1db000-7e202000 Deferred devenum<elf> \-PE 7e1e0000-7e202000 \ devenum ELF 7e224000-7e22b000 Deferred libxfixes.so.3 ELF 7e22b000-7e237000 Deferred libxcursor.so.1 ELF 7e237000-7e24a000 Deferred libxi.so.6 ELF 7e24a000-7e24e000 Deferred libxcomposite.so.1 ELF 7e24e000-7e25b000 Deferred libxrandr.so.2 ELF 7e25b000-7e267000 Deferred libxrender.so.1 ELF 7e267000-7e26e000 Deferred libxxf86vm.so.1 ELF 7e26e000-7e272000 Deferred libxinerama.so.1 ELF 7e272000-7e279000 Deferred libxdmcp.so.6 ELF 7e279000-7e27d000 Deferred libxau.so.6 ELF 7e27d000-7e2a3000 Deferred libxcb.so.1 ELF 7e2a3000-7e3f5000 Deferred libx11.so.6 ELF 7e3f5000-7e40a000 Deferred libxext.so.6 ELF 7e40a000-7e410000 Deferred libcap.so.2 ELF 7e434000-7e4c0000 Deferred winex11<elf> \-PE 7e440000-7e4c0000 \ winex11 ELF 7e4c0000-7e4e3000 Deferred imm32<elf> \-PE 7e4d0000-7e4e3000 \ imm32 ELF 7e5c3000-7e5ed000 Deferred libexpat.so.1 ELF 7e5ed000-7e62f000 Deferred libfontconfig.so.1 ELF 7e62f000-7e65c000 Deferred libpng12.so.0 ELF 7e65c000-7e679000 Deferred libz.so.1 ELF 7e679000-7e728000 Deferred libfreetype.so.6 ELF 7e728000-7e74c000 Deferred libtinfo.so.5 ELF 7e74c000-7e772000 Deferred libncurses.so.5 ELF 7e79c000-7e81a000 Deferred rpcrt4<elf> \-PE 7e7b0000-7e81a000 \ rpcrt4 ELF 7e81a000-7e833000 Deferred version<elf> \-PE 7e820000-7e833000 \ version ELF 7e833000-7e94a000 Deferred gdi32<elf> \-PE 7e840000-7e94a000 \ gdi32 ELF 7e94a000-7ea97000 Deferred user32<elf> \-PE 7e960000-7ea97000 \ user32 ELF 7ea97000-7eb0a000 Deferred advapi32<elf> \-PE 7eaa0000-7eb0a000 \ advapi32 ELF 7eb0a000-7ec3c000 Deferred ole32<elf> \-PE 7eb20000-7ec3c000 \ ole32 ELF 7ec3c000-7ed69000 Deferred oleaut32<elf> \-PE 7ec50000-7ed69000 \ oleaut32 ELF 7ef69000-7ef76000 Deferred libnss_files.so.2 ELF 7ef76000-7ef90000 Deferred libnsl.so.1 ELF 7ef90000-7efd6000 Deferred libm.so.6 ELF 7efe8000-7f000000 Deferred devenum_test<elf> \-PE 7eff0000-7f000000 \ devenum_test ELF f73a6000-f73ab000 Deferred libdl.so.2 ELF f73ab000-f7556000 Dwarf libc.so.6 ELF f7557000-f7573000 Dwarf libpthread.so.0 ELF f7574000-f7580000 Deferred libnss_nis.so.2 ELF f7594000-f759d000 Deferred libnss_compat.so.2 ELF f759d000-f7753000 Dwarf libwine.so.1 ELF f7755000-f7777000 Deferred ld-linux.so.2 ELF f7777000-f7778000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\julliard\wine\wine\dlls\devenum\tests\devenum_test.exe 00000028 0 00000027 0 00000026 0 <== 00000009 0 0000000e services.exe 0000001e 0 0000001d 0 00000017 0 00000016 0 00000014 0 00000010 0 0000000f 0 00000012 winedevice.exe 0000001c 0 00000019 0 00000018 0 00000013 0 0000001a plugplay.exe 00000020 0 0000001f 0 0000001b 0 00000021 explorer.exe 00000025 0 00000024 0 00000023 0 00000022 0 System information: Wine build: wine-1.7.53-39-g51c5fea1f275 Platform: i386 Host system: Linux Host version: 3.16.0-4-amd64 Makefile:161: recipe for target 'devenum.ok' failed make: *** [devenum.ok] Error 5 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] hidclass.sys: fixed size passed IOCTL_HID_GET_INPUT_REPORT (Coverity)
by Sebastian Lackner Oct. 19, 2015

Oct. 19, 2015

On 17.10.2015 14:52, Marcus Meissner wrote: > 1327477 Wrong sizeof argument > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c > index e7e7e11..dcc7d3c 100644 > --- a/dlls/hidclass.sys/device.c > +++ b/dlls/hidclass.sys/device.c > @@ -277,7 +277,7 @@ static DWORD CALLBACK hid_device_thread(void *args) > packet->reportId = 0; > > irp = IoBuildDeviceIoControlRequest(IOCTL_HID_GET_INPUT_REPORT, > - device, NULL, 0, packet, sizeof(packet), TRUE, events[0], > + device, NULL, 0, packet, sizeof(*packet)+ext->preparseData->caps.InputReportByteLength, TRUE, events[0], > &irp_status); > > irpsp = IoGetNextIrpStackLocation(irp); > This looks wrong, you have to allocate a separate buffer, and then copy it (like in the code below). I don't know why some of these buffers are HEAP_ZERO_MEMORY though, and others not? Adding Aric, he might want to review this part again, especially since Coverity detected more issues in this code (unnecessary assignment of "rc" for example).

4 8

Re: [PATCH v4] Remove whitespaces and tabs
by Frédéric Delanoy Oct. 19, 2015

Oct. 19, 2015

On Sun, Oct 18, 2015 at 11:44 AM, Andrey Gusev <andrey.goosev(a)gmail.com> wrote: > Supersedes 115416 As a general rule, pure whitespace patches are not accepted. No point sending them over and over. Frédéric Delanoy

5 4

Re: wined3d: Recognize Radeon HD 3850 AGP
by Henri Verbeet Oct. 19, 2015

Oct. 19, 2015

Did you test this? You don't add anything that matches CARD_AMD_RADEON_HD3850.

1 0