March 2015 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] gdiplus: Store IWICBitmapDecoder inside GpBitmap
by Vincent Povirk March 10, 2015

March 10, 2015

As long as we're doing this, we should probably make use of the decoder in GdipImageSelectActiveFrame, and maybe we shouldn't bother when we just have one frame. On Mon, Mar 9, 2015 at 12:33 PM, Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/gdiplus_private.h | 1 + > dlls/gdiplus/image.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > > > >

2 1

Re: [PATCH 3/3] gdiplus: Fix animated gif frames composition
by Dmitry Timoshkov March 10, 2015

March 10, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > --- > dlls/gdiplus/gdiplus_private.h | 5 ++ > dlls/gdiplus/image.c | 193 > +++++++++++++++++++++++++++++++++++++---- > 2 files changed, 181 insertions(+), 17 deletions(-) Besides its complexity this probably needs a split, and it seems to me that GIF transparent color index is not properly handled. -- Dmitry.

1 0

Re: [PATCH 2/3] gdiplus: Convert gif frame to DIB on load
by Dmitry Timoshkov March 10, 2015

March 10, 2015

Piotr Caban <piotr(a)codeweavers.com> wrote: > + bitmap->format = PixelFormat32bppARGB; Please add a test confirming this. -- Dmitry.

1 0

Re: [PATCH 3/3] gdiplus: Fix animated gif frames composition
by Vincent Povirk March 10, 2015

March 10, 2015

+ hr = IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICBitmapSource, (void**)&bmp_source); FrameDecode inherits Source so I don't think this is necessary? None of this seems obviously wrong to me, but it is complicated and interesting behavior. I'm not sure if I understand it all.

1 0

Re: [4/4] winmm/tests: Add notify tests for MPEGVideo device.
by Marvin March 9, 2015

March 9, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12014 Your paranoid android. === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

1 0

Re: [PATCH] wine.inf: Add some knownfolders to the registry
by Marvin March 9, 2015

March 9, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12013 Your paranoid android. === w8 (32 bit shellpath) === shellpath.c:471: Test failed: CSIDL_PERSONAL has unexpected type 46 (0x2e) shellpath.c:480: Test failed: CSIDL_PERSONAL has unexpected type 46 (0x2e) shellpath.c:545: Test failed: CSIDL_PERSONAL: got GUID {a8cdff1c-4878-43be-b5fd-f8091c1c60d0}, expected {450d8fba-ad25-11d0-98a8-0800361b1103} shellpath.c:1835: Test failed: invalid known folder parsing name returned for FOLDERID_Videos: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{A0953C92-50DC-43BF-BE83-3742FED03C9C}" retrieved shellpath.c:1317: Test failed: invalid known folder parsing name returned for FOLDERID_Pictures: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{3ADD1653-EB32-4CB0-BBD7-DFA0ABB5ACCA}" retrieved shellpath.c:1607: Test failed: invalid known folder attributes for FOLDERID_SamplePictures: 0x00000001 expected, but 0x00000000 retrieved shellpath.c:1083: Test failed: invalid known folder parent for FOLDERID_Cookies: FOLDERID_RoamingAppData expected, but {f1b32785-6fba-4fcf-9d55-7b8e7f157091} retrieved shellpath.c:1083: Test failed: invalid known folder relative path returned for FOLDERID_Cookies: Microsoft\Windows\Cookies expected, but L"Microsoft\\Windows\\INetCookies" retrieved shellpath.c:1598: Test failed: invalid known folder attributes for FOLDERID_SampleMusic: 0x00000001 expected, but 0x00000000 retrieved shellpath.c:1263: Test failed: invalid known folder parsing name returned for FOLDERID_Music: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{1CF1260C-4DD0-4EBB-811F-33C572699FDE}" retrieved shellpath.c:1128: Test failed: invalid known folder parsing name returned for FOLDERID_Downloads: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{374DE290-123F-4565-9164-39C4925E467B}" retrieved shellpath.c:1625: Test failed: invalid known folder attributes for FOLDERID_SampleVideos: 0x00000001 expected, but 0x00000000 retrieved shellpath.c:1110: Test failed: invalid known folder parsing name returned for FOLDERID_Documents: L"shell:::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{A8CDFF1C-4878-43be-B5FD-F8091C1C60D0}" retrieved shellpath.c:1200: Test failed: invalid known folder relative path returned for FOLDERID_InternetCache: Microsoft\Windows\Temporary Internet Files expected, but L"Microsoft\\Windows\\INetCache" retrieved

1 0

Re: [PATCH 3/4] wshom.ocx: Implement Exec() method
by Jacek Caban March 9, 2015

March 9, 2015

Hi Nikolay, On 03/09/15 06:41, Nikolay Sivov wrote: > + if (!CreateProcessW(NULL, command, NULL, NULL, FALSE, 0, NULL, NULL, &si, &info)) > + return HRESULT_FROM_WIN32(GetLastError()); > + > + hr = WshExec_create(&info, ret); > + if (FAILED(hr)) { > + TerminateProcess(info.hProcess, hr); This is questionable error handling. You wouldn't need that if you called WshExec_create before CreateProcessW. Cheers, Jacek

2 1

Re: [5/5] ws2_32/tests: Add more select() tests (try 2)
by Marvin March 8, 2015

March 8, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11987 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: [4/5] ws2_32/tests: Improve setup_connector_socket to allow non-blocking connect calls
by Marvin March 8, 2015

March 8, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11986 Your paranoid android. === wxppro (32 bit sock) === sock.c:613: Test failed: oob_server (c54): unexpectedly at the OOB mark: 0

1 0

Using compiler error information to check undocumented prototypes and structures?
by Qian Hong March 7, 2015

March 7, 2015

Hi, On Thu, Mar 5, 2015 at 7:27 PM, Piotr Caban <piotr.caban(a)gmail.com> wrote: > I'm expecting it to be quite hard taking in account the functions are not > documented and that you can't look on the headers while working on it. Could we use compiler error information to check undocumented prototypes and structures? For example, assume we don't know the prototype of CreateWindowExW. Let's write a test program test.c like below: #include <windows.h> void CreateWindowExW(); int main(void) { CreateWindowExW(); return 0; } Then we compile test.c on Windows using: gcc -sysroot /path/to/MicrosoftSDK/include test.c Then we will get some error message like: In file included from /path/to/windows.h:72:0, from test.c:1: /path/to/winuser.h:1935:26: note: previous declaration of ‘CreateWindowExW’ was here WINUSERAPI HWND WINAPI CreateWindowExW(DWORD dwExStyle,LPCWSTR lpClassName,LPCWSTR lpWindowName,DWORD dwStyle,int X,int Y,int nWidth,int nHeight,HWND hWndParent,HMENU hMenu,HINSTANCE hInstance,LPVOID lpParam); Then we will know the correct prototype. In theory VC++ and clang should do similar job as well. Could that be a valid way to detect a function prototype and a data structure when re-implementing undocumented API? If it's valid, we can consider setting up a AppVeyor CI account and connect to a github account to provide a "MS type and structure query service". AppVeyor CI provides a free (as beer) Windows environment and VC++ compiler (third party compilers like gcc and clang can be installed as well). By tweaking the setting, we can trigger AppVeyor rebuild by pull request. In that case, whenever we need to query a undocumented prototype or structure, we can just write a (wrong) test case and submit a pull request, without reading MS headers by human. Any thought is appreciated. -- Regards, Qian Hong - http://www.winehq.org

4 5