March 2015 - Wine-Devel - list.winehq.org

Re: [1/4] dpnet:Add check for mismatched string lengths (try 5)
by Marvin March 6, 2015

March 6, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11937 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: [PATCH 1/4] windowscodecs: Add helper to create internal COM classes without CoCreateInstance call if possible
by Vincent Povirk March 6, 2015

March 6, 2015

Thanks for working on this. The series looks good to me. + hr = WICCreateImagingFactory_Proxy(WINCODEC_SDK_VERSION, &factory); + ok(hr == S_OK, "CoCreateInstance error %#x\n", hr); This message doesn't match the call.

1 0

hostname: Remove redundant codepath and replace with FormatMessage
by Hugh McMaster March 5, 2015

March 5, 2015

How does patch 109550 need to improve? (http://source.winehq.org/patches/data/109550) Thanks, Hugh

1 0

Re: [PATCH 1/4] reg: Add path/key conversion functions
by Stefan Dösinger March 5, 2015

March 5, 2015

I think these patches can be split further. And yeah, I could have thought of some of this sooner :-( . 1.1: A patch that replaces the if chains with the table 1.2: A patch that merges the duplicated string splitting with reg_open 2.1: Implement REG_MULTI_SZ. Use this patch to strip LPCRAP from the function definition 2.2: Improve REG_DWORD. I think you can merge the REG_DWORD_BIG_ENDIAN support into this patch, since it is just another REG_DWORD. 2.3: Add REG_NONE. Just a one-liner and todo_wine removal. 2.4: Add REG_EXPAND_SZ. Another one-liner. 2.5: Add REG_BINARY. Patch 3: I think at least the check > + if (value_name && value_empty) > + { > + reg_message(STRING_INVALID_CMDLINE); > + return 1; > + } Is independent of the rest. I may be missing something though. Another question that pops up in my mind is this: > + if (value_name && !value_name[0]) > + value_name = NULL; This is interesting together with the value_name && value_empty check. I suspect /v "" /ve still results in an error, but it is worth a test in a separate patch. This can be after the existing series as far as I'm concerned. > + if (!argvW[++i][0] || argvW[i][1]) > + { > + reg_message(STRING_INVALID_CMDLINE); > + return 1; > + } Can also go in a separate patch. > + if (err != ERROR_SUCCESS){ I expect Alexandre to hit me with a brick now, but this is inconsistent with the rest. Patch 4 can be split in a similar fashion: > + /* Mutually exclusive options */ > + if ((!!value_name + !!value_empty + !!value_all) > 1) I think merging the existing (and broken) checks for that is separate from the rest. The changes you make to handle value_all can also be separated I think. That will make this patch easier to read. Stefan Am 04.03.2015 um 17:29 schrieb Jonathan Vollebregt <jnvsor(a)gmail.com>: > --- > programs/reg/reg.c | 166 +++++++++++++++++++++++++++-------------------------- > 1 file changed, 86 insertions(+), 80 deletions(-) > > <0001-reg-Add-path-key-conversion-functions.patch>

1 0

Re: [PATCH] vbscript: Implemented String
by Marvin March 5, 2015

March 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11930 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Implemented String
by Marvin March 5, 2015

March 5, 2015

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11929 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [3/3] dpnet: Always update Component type since it can change (try 3)
by Stefan Dösinger March 5, 2015

March 5, 2015

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-05 um 09:55 schrieb Alistair Leslie-Hughes: > hr = IDirectPlay8Address_GetComponentByName(localaddr, DPNA_KEY_HOSTNAME, buffer, &size, &type); > ok(hr == S_OK, "got 0x%08x\n", hr); > - todo_wine ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); > + ok(type == DPNA_DATATYPE_STRING, "incorrect type %d\n", type); > todo_wine ok(!lstrcmpW(buffer, localhost), "Invalid string: %s\n", wine_dbgstr_w(buffer)); I don't understand why the last check still needs todo_wine. Afaics the value should be stored and retrieved correctly. Otherwise this looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU+GI4AAoJEN0/YqbEcdMwsyoP/0gkQITbAphMP7a4lonngLNC Bs3N5Pfo+AeXXcBUWMBFWTPfwHlTGxrk6cQZWijDaWI8ahWi57sjTY7iyez9gh7c +mCrewr+vOVOxWT6gIQIvv1xRCOQ2rrDAuNF3Ae9YuwaOvrtVuQmBMZuM5436OrD bTKu4Jj4wwnFRhR9TCQRiReI75vg9ZSF/T+PEnpovRCje7P53FtaqQcAPTDr742O IWSKngP+jAbWn5K4pwxDR8DVgGaGlzWHE7nv0IAZ69hZJy9fovzIGHbyiqQP2bZ6 2elhJkGgeNCwTVxV1ygbheJvs73KBrwf74mJbJUzC98EpdlO87ZJNEJKR6/UzAu5 Gr5aKtlQTjyvzY0AFwiahdWjS+gR5uUJLymAdEHBKjjYZzowzdXNq7KSGluhn5cm /c8EtJxcalix7dTdGp7Jq0te6B0yEk3hcvpYXcyfELo66hW4jdFApFpgZNb1Xx05 pmDfqagqHe3HHma3J4Uxhn0CyxJeOZKdJlQPZldpVia6zlf2y9BjD2iWfXq2Xl1B yoxS/xnmcx1HWvtUDtPmzobNCqZaA5KFNwKCJBGRiD7MaQjeY+EXBz+IjVuSiQk6 HziyqNT5u+CCjRY4MULGC3om4j9qytqxOjbVPKqZPesmYDI0SddrMwWtTcjoSMV8 8G0BUKbyNuBFCe/LiOtM =t8mZ -----END PGP SIGNATURE-----

1 0

Re: [1/4] ntdll: Implement TpSimpleTryPost and basic threadpool infrastructure.
by Alexandre Julliard March 5, 2015

March 5, 2015

Sebastian Lackner <sebastian(a)fds-team.de> writes: > diff --git a/dlls/ntdll/Makefile.in b/dlls/ntdll/Makefile.in > index ed4bb94..2cecac6 100644 > --- a/dlls/ntdll/Makefile.in > +++ b/dlls/ntdll/Makefile.in > @@ -47,6 +47,7 @@ C_SRCS = \ > tape.c \ > thread.c \ > threadpool.c \ > + threadpool2.c \ Please put that stuff in the existing threadpool.c, it's not large and it will be easier to find that way. -- Alexandre Julliard julliard(a)winehq.org

1 0

GSOC 2015 : D3DX9 - Implement missing D3DX9 APIs
by Abhishek Kumar March 5, 2015

March 5, 2015

Hi, I am Abhishek and am interested in the project titled "D3DX9 - Implement missing D3DX9 APIs". I am good at data-structures and algorithms and have worked with C,C++, PHP, Javascript and Python. I have some questions about the task: 1)Can domain-specific knowledge be a issue..? From just the name of the apis listed on ideas page, i can guess that some advanced domain knowledge in the concerned field is needed. How difficult would it be to write the apis without that knowledge..? 2) How should i start my work for this project..? By collecting the list of apis that would be implemented..? How should it be done..? Is there any documentation about it that will help..? Currently i have no idea. -- Thanks, Abhishek Kumar UG4, CSE IIIT Hyderabad, India

2 1

My GSOC2015 ideas
by YongHao Hu March 5, 2015

March 5, 2015

Hello, folks I'm YongHao Hu, a college student who study and send patches about msvcp,msvcrt. Thanks for Zhenbo's ideas. Here are my ideas for GSoC 2015. 1. Add needed functions about tr2 and finish my patch about cin>>complex ================== Though msvcp has almost 80%[1] functions implemented, it still has many unimplemented functions, which is used heavily in many softwares. For example, almost all the functions in namespace std::tr2::sys[2] need to implement, which causes a bug[3] now. 2. Optimize printf,sprintf functions using Grisu algorithm ================== I had found a bug[4] which is about inconsistent rounding behaviour for sprintf function. In order to fix it, I had made a patch[5] using Dragon4 algorithm. However, this implementation is a little slower than MSVC++ 2010, even four times slower[6] when printing 64-bit values with the minimal number of significant digits to identify the number like sprintf(buffer, "%.17g", value). As functions like printf and sprintf are dependent on pf_printf function, to which the patch applies, I guess efficency is important. As a result, using Grisu algorithm[7] to optimize the patch is a good choice. Grisu algorithm speeds up 99.4 percent of all 64-bit floating point numbers by only using small-integer arithmetic, while the remaining 0.6% still need to use a variant of Dragon4. My idea is to improve my patch based on Dragon4 algorithm so that it can be commited, after which I will add Grisu algorithm to optimize it. 3. Implement series undocumented functions about _Pad ================== There are two bugs needed unimplemented function of _pad in msvcp now[8][9]. I have studied and tested _pad function, finding that _pad is an undocumented function. I also implied that _Pad::Launch is a wrapper of _Thrd_create, thus, it is a tough job which needs to imply and implement many functions. Though my ideas for GSOC2015 may not mature enough, but I hope that they will be helpful. What's more, I am glad to choose some of them as my proposal, if they meet the criteria for GSoC. Thank you for reading this email. I will be grateful for any advice you can provide. [1]: https://www.winehq.org/winapi_stats [2]: https://msdn.microsoft.com/en-us/eg/library/hh874769.aspx [3]: https://bugs.winehq.org/show_bug.cgi?id=35774 [4]: https://bugs.winehq.org/show_bug.cgi?id=37913 [5]: http://source.winehq.org/patches/data/109456 [6]: http://www.ryanjuckett.com/programming/printing-floating-point-numbers/part… [7]: http://www.cs.tufts.edu/~nr/cs257/archive/florian-loitsch/printf.pdf [8]: https://bugs.winehq.org/show_bug.cgi?id=36996 [9]: https://bugs.winehq.org/show_bug.cgi?id=37694

2 1