November 2016 - Wine-Devel - list.winehq.org

Github mirror seems to be out-of-sync
by Akihiro Sagawa Nov. 30, 2016

Nov. 30, 2016

Source code admin, Official Github mirror, https://github.com/wine-mirror/wine, seems to be not updated for a few days. Could you take a look? Thanks in advance. Akihiro Sagawa

2 2

Re: [resend] fusion: Avoid buffer overflow in enum_gac_assemblies.
by Alexandre Julliard Nov. 29, 2016

Nov. 29, 2016

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > [ Marvin indicated testing went fine, and I did not see any feedback > for two weeks. Only the description below has changed a little. ] > > In enum_gac_assemblies we have the following > > sprintf(buf, ", Version=%s, Culture=%s, PublicKeyToken=%s", > ffd.cFileName, culture, ptr); > > culture is declared as char[MAX_PATH], and WIN32_FIND_DATAA.cFileName > is CHAR[260], so a mere size of MAX_PATH for the output buffer buf is > not sufficient. > > (We need to double sizeof(ffd.cFileName) since ptr also points > into it.) They all point into the same path, so the total size is not going to exceed MAX_PATH (modulo the additionally printed chars). And it doesn't make sense to fix this buffer but not the other ones, you are just moving the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Serial port sniffing problem
by Christopher Harrington Nov. 29, 2016

Nov. 29, 2016

(copying list again, below edited for brevity) On Tue, Nov 29, 2016 at 12:39 PM Bill Lionheart <billlionheart(a)gmail.com> wrote: > $ ls -Fl > lrwxrwxrwx 1 bill bill 10 May 11 2014 c: -> ../drive_c/ > lrwxrwxrwx 1 bill bill 12 Jan 6 2016 com1 -> /dev/ttyUSB0 > > $ id -a > uid=1001(bill) gid=1001(bill) > groups=1001(bill),20(dialout) > $ ls -l /dev/ttyUSB0 > crw-rw---- 1 root dialout 188, 0 Nov 29 18:27 /dev/ttyUSB0 > > > All of this definitely looks correct. Here are a couple more suggestions: 1. Try creating a brand new wine prefix. Yours certainly has a beard on it and there may be artifacts of older copies of Wine that could be impacting your testing. Anyway, this essentially would look like moving ~/.wine to somewhere else, installing your test application again, and re-creating your com1 file in dosdevices/. You can always move your .wine directory back if it has important stuff in it. 2. See if using a more current version of Wine improves anything. You say you're on Wine 1.8; if you could be more specific (try running wine --version) that might give someone a lightbulb. 3. Crossover from Codeweavers is appallingly affordable if you haven't looked into that yet, and it comes with professional support. Anyway, wine-devel is more for discussion of development of Wine itself, not a support forum. What you're probably looking for is wine-users. I'm not subscribed to wine-users, so I can't copy your email there, but you can subscribe here: https://www.winehq.org/mailman/listinfo/wine-users Good luck. > > On 29 November 2016 at 17:57, Christopher Harrington > <ironiridis+winehq(a)gmail.com> wrote: > > On Tue, Nov 29, 2016 at 1:22 AM Bill Lionheart <billlionheart(a)gmail.com> > > wrote: > >> > >> Using Wine version 1.8 on Ubuntu 14.04.5 > >> I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a > >> serial interface. The device is supplied with a Prolific USB serial > >> converter which comes up as /dev/ttyUSB0 which > >> I have sym linked to COM1 > > > > > > Can you please cd into your dosdevices folder and run this command? > > > > ls -Fl > > > > (that's an uppercase F and a lowercase L) > > > > Then we will also need to see permissions of the serial device, so run > this: > > > > ls -l /dev/ttyUSB0 > > > > That's a lowercase L again... and run this too: > > > > id -a > > > > With all this info we can rule out a couple problems, chief among them: > > 1. Is the symlink named correctly and actually pointing to something that > > exists > > 2. Do you actually have permissions to access the serial port > > > > If you provide the output of all three of these commands, we should be > able > > to help. > > > > -Chris > > > >> > >> > > > > > > -- > Professor of Applied Mathematics > University of Manchester > http://www.maths.manchester.ac.uk/bl >

1 0

Re: [PATCH v2] ws2_32/tests: Add IDN resolution tests for GetAddrInfoW
by Marvin Nov. 29, 2016

Nov. 29, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26981 Your paranoid android. === w7u (32 bit sock) === sock.c:8270: Test failed: Overlapped TransmitFile failed. sock.c:8272: Test failed: Overlapped TransmitFile sent an unexpected number of bytes (219 != 209).

1 0

Re: [PATCH 9/9] d3d11/tests: Add test for typed UAV loads.
by Henri Verbeet Nov. 29, 2016

Nov. 29, 2016

On 29 November 2016 at 12:06, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/d3d11/tests/d3d11.c | 326 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 326 insertions(+) > This fails for me on Windows: d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 1: Got 0x3f000000, expected 0x00000000 at (3, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 0). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 1). d3d11.c:11568: Test failed: Test 5: Got 0x00000010, expected 0x00000000 at (3, 1). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 2). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (0, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (1, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (2, 3). d3d11.c:11568: Test failed: Test 5: Got 0xffffffff, expected 0x00000000 at (3, 3).

2 1

Re: [PATCH 4/5] d3d11/tests: Add test for shader input register limits.
by Henri Verbeet Nov. 29, 2016

Nov. 29, 2016

On 25 November 2016 at 12:17, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > > The "ps_many_resources_code" shader bytecode is very big because texture > resources cannot be indexed and the loop is unrolled. > > --- > dlls/d3d11/tests/d3d11.c | 221 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 221 insertions(+) > This doesn't work here. In particular: fixme:d3d_shader:print_glsl_info_log Info log received from GLSL shader #5: fixme:d3d_shader:print_glsl_info_log error: Too many fragment shader texture samplers ... fixme:d3d:context_bind_shader_resources Shader 0x18bb10 needs 21 samplers, but only 16 are supported.

2 3

Re: [PATCH] ws2_32/tests: Add IDN resolution test for GetAddrInfoW
by Alexandre Julliard Nov. 29, 2016

Nov. 29, 2016

Bruno Jesus <00cpxxx(a)gmail.com> writes: > I'm using €.linux.it because I could not find any standard domain name > for validation. Maybe winehq.org could have a IDN sub-domain name to > test. I created テスト.winehq.org for this purpose. > Also instead of broken'ing every test to catch Windows <= 7 I'm > skipping before, so real failures are not lost due to broken covering > them in Win >= 8. I still think it's better to avoid version checks. You can do broken() on the first test and skip the others if you detect the Win 7 behavior. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: shell32/tests: Add some uuids present on Windows 10.
by Nikolay Sivov Nov. 29, 2016

Nov. 29, 2016

On 29.11.2016 16:43, Huw Davies wrote: > +DEFINE_GUID(IID_UnknownInterface22, 0x42f85136, 0xdb7e, 0x439c, 0x85,0xf1, 0xe4,0x07,0x5d,0x13,0x5f,0xc8); This one is IID_IFileDialog.

2 1

Re: [PATCH 2/2] hnetcfg/tests: Add INetFwAuthorizedApplication tests
by Nikolay Sivov Nov. 29, 2016

Nov. 29, 2016

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > Since put_ProcessImageFileName appears to validate the image name that is > supplied, the normal put/get/compare was excluded because it returned > E_INVALIDARG even for a fully qualified filename. An investigation for another > day. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/tests/Makefile.in | 2 +- > dlls/hnetcfg/tests/policy.c | 32 +++++++++++++++++++++++++++++++- > 2 files changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/tests/Makefile.in b/dlls/hnetcfg/tests/Makefile.in > index aa4062a..5e1ce91 100644 > --- a/dlls/hnetcfg/tests/Makefile.in > +++ b/dlls/hnetcfg/tests/Makefile.in > @@ -1,5 +1,5 @@ > TESTDLL = hnetcfg.dll > -IMPORTS = ole32 uuid > +IMPORTS = ole32 uuid oleaut32 > > C_SRCS = \ > policy.c > diff --git a/dlls/hnetcfg/tests/policy.c b/dlls/hnetcfg/tests/policy.c > index a3ed4b2..a05b02e 100644 > --- a/dlls/hnetcfg/tests/policy.c > +++ b/dlls/hnetcfg/tests/policy.c > @@ -65,6 +65,36 @@ static void test_interfaces(void) > INetFwMgr_Release(manager); > } > > +static void test_NetFwAuthorizedApplication(void) > +{ > + INetFwAuthorizedApplication *app; > + HRESULT hr; > + > + hr = CoCreateInstance(&CLSID_NetFwAuthorizedApplication, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, > + &IID_INetFwAuthorizedApplication, (void**)&app); > + ok(hr == S_OK, "got: %08x\n", hr); > + if(hr == S_OK) > + { It's not really necessary to protect it like that. If creation consistently fails test or all tests should be skipped. > + static WCHAR empty[] = {0}; > + BSTR bstr; > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, NULL); > + ok(hr == E_POINTER, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_get_ProcessImageFileName(app, &bstr); > + ok(hr == S_OK, "got: %08x\n", hr); > + ok(!bstr, "got: %s\n", wine_dbgstr_w(bstr)); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, NULL); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); > + > + hr = INetFwAuthorizedApplication_put_ProcessImageFileName(app, empty); > + ok(hr == E_INVALIDARG, "got: %08x\n", hr); Please use actual BSTR here. > + > + INetFwAuthorizedApplication_Release(app); > + } > +} > + > START_TEST(policy) > { > INetFwMgr *manager; > @@ -84,7 +114,7 @@ START_TEST(policy) > INetFwMgr_Release(manager); > > test_interfaces(); > - > + test_NetFwAuthorizedApplication(); > > CoUninitialize(); > } >

1 0

Re: [v2 PATCH 1/2] hnetcfg: Improve INetFwAuthorizedApplication::get_ProcessImageFileName stub.
by Nikolay Sivov Nov. 29, 2016

Nov. 29, 2016

On 29.11.2016 9:58, Alistair Leslie-Hughes wrote: > From: Michael Müller <michael(a)fds-team.de> > > v2: > Corrected error return values. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/hnetcfg/apps.c | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/dlls/hnetcfg/apps.c b/dlls/hnetcfg/apps.c > index 2b8d78c..a89e6a7 100644 > --- a/dlls/hnetcfg/apps.c > +++ b/dlls/hnetcfg/apps.c > @@ -38,6 +38,7 @@ typedef struct fw_app > { > INetFwAuthorizedApplication INetFwAuthorizedApplication_iface; > LONG refs; > + BSTR filename; > } fw_app; > > static inline fw_app *impl_from_INetFwAuthorizedApplication( INetFwAuthorizedApplication *iface ) > @@ -60,6 +61,7 @@ static ULONG WINAPI fw_app_Release( > if (!refs) > { > TRACE("destroying %p\n", fw_app); > + if (fw_app->filename) SysFreeString( fw_app->filename ); There's no need for this check. > HeapFree( GetProcessHeap(), 0, fw_app ); > } > return refs; > @@ -252,7 +254,18 @@ static HRESULT WINAPI fw_app_get_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %p\n", This, imageFileName); > - return E_NOTIMPL; > + > + if (!imageFileName) > + return E_POINTER; > + > + if (!This->filename) > + { > + *imageFileName = NULL; > + return S_OK; > + } > + > + *imageFileName = SysAllocString( This->filename ); > + return *imageFileName ? S_OK : E_OUTOFMEMORY; > } You can reduce this to --- *imageFileName = SysAllocString( This->filename ); return *imageFileName || !This->filename ? S_OK : E_OUTOFMEMORY; --- > > static HRESULT WINAPI fw_app_put_ProcessImageFileName( > @@ -262,7 +275,12 @@ static HRESULT WINAPI fw_app_put_ProcessImageFileName( > fw_app *This = impl_from_INetFwAuthorizedApplication( iface ); > > FIXME("%p, %s\n", This, debugstr_w(imageFileName)); > - return S_OK; > + > + if (!imageFileName || !imageFileName[0]) > + return E_INVALIDARG; > + > + This->filename = SysAllocString( imageFileName ); > + return This->filename ? S_OK : E_OUTOFMEMORY; > } What happens if you call put_ProcessImageFileName() repeatedly?

1 0