November 2016 - Wine-Devel - list.winehq.org

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Lauri Kenttä Nov. 26, 2016

Nov. 26, 2016

Testbot reports a failure on Vista, but that is not related to my patch. -- Lauri Kenttä

1 0

Re: [PATCH] cmd: Fix copying when the dest is one of the sources.
by Marvin Nov. 26, 2016

Nov. 26, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26929 Your paranoid android. === wvistau64 (32 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:313: Test failed: unexpected char 0x27 position 0 in line 456 (got ''--a--c---'', wanted ''--a------'@or_broken@'--a--------'@or_broken@'%~ai'')

1 0

Re: [PATCH v2 2/5] d3d9/tests: Add test for occlusion query with result bigger than UINT32_MAX.
by Marvin Nov. 25, 2016

Nov. 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26917 Your paranoid android. === w864 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f. === w1064 (64 bit device) === device.c:4392: Test failed: cw is 0xf60, expected 0x7f. device.c:4401: Test failed: Callback cw is 0xf60, expected 0x7f.

1 0

Re: ntdll/tests: The fpu exception offset is broken on 32-bit Windows 8 too.
by Marvin Nov. 25, 2016

Nov. 25, 2016

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=26914 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x2e0000/0x2e0001 exception: unhandled exception 80000004 at 002E0000 exception.c:551: Test failed: 42: Unexpected eip 0x77baed97/0x2e0001 === w7u (32 bit exception) === exception.c:551: Test failed: 42: Unexpected eip 0x300000/0x300001 exception: unhandled exception 80000004 at 00300000 exception.c:551: Test failed: 42: Unexpected eip 0x77cde34f/0x300001 === w1064 (32 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) === w1064 (64 bit exception) === An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Re: [PATCH] winspool: Use all Fields from DRIVER_INFO_8A when we add a Printer Driver.
by Huw Davies Nov. 25, 2016

Nov. 25, 2016

On Fri, Nov 25, 2016 at 12:49:40AM +0100, Detlef Riekenberg wrote: > + if ((Level > 7) && diA->pszzColorProfiles) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, NULL, 0); > + diW.pszzColorProfiles = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzColorProfiles, -1, diW.pszzColorProfiles, len); > + } This is a 'multi-sz' string, so you need the same handling as 'pDependentFiles' here. > + if ((Level > 7) && diA->pszInfPath) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, NULL, 0); > + diW.pszInfPath = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszInfPath, -1, diW.pszInfPath, len); > + } > + > + if ((Level > 7) && diA->pszzCoreDriverDependencies) { > + len = MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, NULL, 0); > + diW.pszzCoreDriverDependencies = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, diA->pszzCoreDriverDependencies, -1, diW.pszzCoreDriverDependencies, len); > + } The same goes for pszzCoreDriverDependencies. > if (Level > 7) { > - FIXME("level %u is incomplete\n", Level); > + diW.dwPrinterDriverAttributes = diA->dwPrinterDriverAttributes; > + diW.ftMinInboxDriverVerDate = diA->ftMinInboxDriverVerDate; > + diW.dwlMinInboxDriverVerVersion = diA->dwlMinInboxDriverVerVersion; > } > > res = AddPrinterDriverExW(nameW, Level, (LPBYTE) &diW, dwFileCopyFlags); > @@ -7018,6 +7061,11 @@ BOOL WINAPI AddPrinterDriverExA(LPSTR pName, DWORD Level, LPBYTE pDriverInfo, DW You're leaking pHelpFile. > HeapFree(GetProcessHeap(), 0, diW.pszOEMUrl); > HeapFree(GetProcessHeap(), 0, diW.pszHardwareID); > HeapFree(GetProcessHeap(), 0, diW.pszProvider); > + HeapFree(GetProcessHeap(), 0, diW.pszPrintProcessor); > + HeapFree(GetProcessHeap(), 0, diW.pszVendorSetup); > + HeapFree(GetProcessHeap(), 0, diW.pszzColorProfiles); > + HeapFree(GetProcessHeap(), 0, diW.pszInfPath); > + HeapFree(GetProcessHeap(), 0, diW.pszzCoreDriverDependencies); > > TRACE("=> %u with %u\n", res, GetLastError()); > return res;

1 0

Re: 2 of 13 [PATCH] po: Update Simplified Chinese translation (v3).
by Jactry Zeng Nov. 24, 2016

Nov. 24, 2016

This looks good to me. Thanks for your contribution! 2016-11-23 0:09 GMT+08:00 Mingcong Bai <jeffbaichina(a)gmail.com>: > Signed-off-by: Mingcong Bai <jeffbai(a)aosc.xyz> > --- > po/zh_CN.po | 1202 ++++++++++++++++++++++++++++++ > ++++------------------------- > 1 file changed, 687 insertions(+), 515 deletions(-) > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 1/2] shlwapi: Remove dot segments for URLs starting with /
by Jacek Caban Nov. 24, 2016

Nov. 24, 2016

Hi Daniel, On 24.11.2016 00:44, Daniel Lehman wrote: > diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c > index 879a734..5de9076 100644 > --- a/dlls/shlwapi/url.c > +++ b/dlls/shlwapi/url.c > @@ -372,6 +372,9 @@ HRESULT WINAPI UrlCanonicalizeW(LPCWSTR pszUrl, LPWSTR pszCanonicalized, > dwFlags |= URL_ESCAPE_UNSAFE; > state = 5; > is_file_url = TRUE; > + } else if(url[0] == '/') { > + state = 2; Wouldn't state 5 be more appropriate? > + is_file_url = TRUE; It would be interesting to have tests using URL_WININET_COMPATIBILITY and URL_FILE_USE_PATHURL flags. is_file_url usually affects slashes conversion in such cases, but you set it too late to take such effect. It may be right, but tests would be nice. Thanks, Jacek

1 0

Re: [PATCH 04/11] wined3d: Introduce wined3d_device_set_unordered_access_view().
by Henri Verbeet Nov. 24, 2016

Nov. 24, 2016

On 23 November 2016 at 14:36, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + FIXME("Unordered access view unsupported yet (layers %u-%u).\n", > + desc->u.texture.layer_idx, desc->u.texture.layer_count); I don't think you can do that in English. You'd either have "UAV unsupported" or "UAV not supported yet". In the specific case here, I'd probably use something like "Unsupported layer selection %u+%u.\n" or something along those lines though.

1 0

Re: [PATCH] d2d1: Implement retrieving dash pattern data for stroke styles
by Henri Verbeet Nov. 24, 2016

Nov. 24, 2016

On 23 November 2016 at 18:09, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > -static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 count) > +static void STDMETHODCALLTYPE d2d_stroke_style_GetDashes(ID2D1StrokeStyle *iface, float *dashes, UINT32 dash_count) > { > - FIXME("iface %p, dashes %p, count %u stub!\n", iface, dashes, count); > + struct d2d_stroke_style *style = impl_from_ID2D1StrokeStyle(iface); > + > + TRACE("iface %p, dashes %p, count %u.\n", iface, dashes, dash_count); > + > + memcpy(dashes, style->dashes, min(style->dash_count, dash_count) * sizeof(*dashes)); > + if (dash_count > style->dash_count) > + memset(dashes, 0, (dash_count - style->dash_count) * sizeof(*dashes)); That doesn't look right.

2 2

Re: [PATCH v2] msvcrt: Add _lfind_s
by Piotr Caban Nov. 24, 2016

Nov. 24, 2016

Hi Daniel, it fails to compile: ../../tools/winegcc/winegcc -o api-ms-win-crt-utility-l1-1-0.dll.so -B../../tools/winebuild -m32 -fasynchronous-unwind-tables -shared ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec \ ../../libs/port/libwine_port.a ../../../wine_src/dlls/api-ms-win-crt-utility-l1-1-0/api-ms-win-crt-utility-l1-1-0.spec:6: function '_lfind_s' not defined winegcc: ../../tools/winebuild/winebuild failed Makefile:166: recipe for target 'api-ms-win-crt-utility-l1-1-0.dll.so' failed make[1]: *** [api-ms-win-crt-utility-l1-1-0.dll.so] Error 2 Thank you, Piotr

1 0