June 2022 - Wine-Devel - list.winehq.org

[PATCH 0/6] MR261: win32u: nonclient conversion
by Jacek Caban (＠jacek) June 17, 2022

June 17, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/261

4 12

[PATCH v4 0/4] MR231: SetWindowPos() parent window exposure fixes (#53153)
by Jinoh Kang (＠iamahuman) June 17, 2022

June 17, 2022

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v4: server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children. server: Redraw composited window child when its z-order changes. server: Correctly expose composited parent window and its child on position change. user32/tests: Test for window exposure behaviours. https://gitlab.winehq.org/wine/wine/-/merge_requests/231

3 12

[PATCH v2 0/5] MR237: winegstreamer: Implement Resampler and ColorConvert MF transforms.
by Rémi Bernon June 17, 2022

June 17, 2022

I don't think this will cause any conflicts with the other MR, as long as the `wg_sample` API doesn't change. -- v2: winegstreamer: Implement ColorConvertDMO transform. winegstreamer: Register stub ColorConvertDMO transform. winegstreamer: Remove unnecessary WineAudioConverter transform. winegstreamer: Implement ResamplerMediaObject transform. winegstreamer: Register stub ResamplerMediaObject transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/237

3 12

[PATCH 0/1] MR262: winhttp: Release object on allocation failure.
by Hans Leidekker (＠hans) June 17, 2022

June 17, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/262

2 1

[tools] testbot/Engine: Prevent recursion into ScheduleJobs().
by Francois Gouget June 17, 2022

June 17, 2022

Recursion may happen through the ScheduleJobs() -> VM::Run() -> VMStatusChange() -> ScheduleJobs() chain. It can cause multiple revert processes to run on the same VM, or even a revert process to run at the same time as a task. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> --- This issue is caused by the patch to process notifications originating from the Engine (9b0894ed386f). What's strange is I'm not seeing this issue in my test environment. --- testbot/lib/WineTestBot/Engine/Scheduler.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/testbot/lib/WineTestBot/Engine/Scheduler.pm b/testbot/lib/WineTestBot/Engine/Scheduler.pm index b9304c1c8f..bba7e6a2cc 100644 --- a/testbot/lib/WineTestBot/Engine/Scheduler.pm +++ b/testbot/lib/WineTestBot/Engine/Scheduler.pm @@ -946,6 +946,7 @@ sub _PowerOffDirtyVMs($) } } +my $_InScheduleJobs; my $_LastTaskCounts = ""; =pod @@ -1004,6 +1005,11 @@ kept on standby so they are ready when their turn comes. sub ScheduleJobs() { + # Don't let Engine notifications (specifically VMStatusChange) cause + # recursion into ScheduleJobs(). + return if ($_InScheduleJobs); + $_InScheduleJobs = 1; + my $Sched = _CheckAndClassifyVMs(); my $NeededVMs = _ScheduleTasks($Sched); _RevertVMs($Sched, $NeededVMs); @@ -1053,6 +1059,8 @@ sub ScheduleJobs() $Timeout = 600; } AddEvent("ScheduleJobs", $Timeout, 0, \&ScheduleJobs); + + $_InScheduleJobs = undef; } -- 2.30.2

1 0

[PATCH v3 0/4] MR231: SetWindowPos() parent window exposure fixes (#53153)
by Jinoh Kang (＠iamahuman) June 16, 2022

June 16, 2022

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v3: server: Don't invalidate the newly exposed child region on the parent with WS_CLIPCHILDREN. server: Redraw composited window child on its z-order change on SetWindowPos(). server: Correctly expose composited parent window on SetWindowPos(). user32/tests: Test for parent window exposure by SetWindowPos(). https://gitlab.winehq.org/wine/wine/-/merge_requests/231

3 8

[PATCH v2 0/1] MR229: comctl32: Always paint SS_BITMAP static control background with WM_CTLCOLORSTATIC brush.
by Jinoh Kang (＠iamahuman) June 16, 2022

June 16, 2022

This is consistent with the behaviour of other static control styles. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: comctl32: Always paint SS_BITMAP static control background with WM_CTLCOLORSTATIC brush. https://gitlab.winehq.org/wine/wine/-/merge_requests/229

3 2

Re: [PATCH v2 0/2] MR258: win32u: Move menu tracking implementation from user32. - approved
by Alexandre Julliard (＠julliard) June 16, 2022

June 16, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/258

1 0

[PATCH v2 0/1] MR254: winex11.drv: Change order register_extension for WGL_ARB_pixel_format_float.
by Sebastián Aedo June 16, 2022

June 16, 2022

Some processes use very naive string matching when detecting extensions, for example, Cossacks III checks if the extension is "contained" in the current extension is checking, causing that `WGL_ARB_pixel_format` is contained in `WGL_ARB_pixel_format_float`, but it ends up with the flag deactivated because they aren't the same. This makes it consistent with the behavior on winemac.drv/opengl.c too. -- v2: winex11.drv: Change order register_extension for WGL_ARB_pixel_format_float. https://gitlab.winehq.org/wine/wine/-/merge_requests/254

2 2

Re: [PATCH v5 0/1] MR134: ntdll: Don't hard-code the battery and AC adapter names on Linux - approved
by Alexandre Julliard (＠julliard) June 16, 2022

June 16, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/134

1 0