June 2022 - Wine-Devel - list.winehq.org

[PATCH 0/1] MR249: include: Emit CFI directives when building on Mac with gcc.
by Stefan Dösinger June 15, 2022

June 15, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53157 Building with FSF gcc on mac is possible and the only way to get a --without-mingw build since clang does not support -mabi=ms. (Some hacks are needed to build winemac.drv.so though.) Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> --- No, FSF gcc on macos does not define __GCC_HAVE_DWARF2_CFI_ASM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/249

2 3

[tools 0/6] Known failures tracking
by Francois Gouget June 15, 2022

June 15, 2022

This patchset provides support for tracking known failures in the TestBot results. The main goal is to avoid false positives but there are some side benefits as well: * The job reports sent to developers link to the relevant WineHQ bugs which gives them more exposure and may help get them fixed faster. * The failure details pages will eventually link to all the tasks where the failure happened, which could be valuable to find patterns. * The failure page tracks when it was last seen. This simplifies spotting bugs which are fixed and could be closed. (Or failures where the regular expression needs to be updated / fixed) The patchset mostly follows the scheme described in bug 48912: https://bugs.winehq.org/show_bug.cgi?id=48912 There are some differences though: * The bug envisionned this scheme purely as a blacklist to avoid false positives. The implementation can certainly be used in this way but it is not limited to failures that cause false positives. Tracking other failures can provide the side benefits mentionned above. The only limit is the maintenance work required to track more failures. * As a consequence the FailureBlacklist class was renamed to Failure, and the FailureBlacklistUses was renamed to TaskFailures since it links Tasks with the related Failures. * The FailureBlacklistVMs purpose is not really described in the bug but I think the goal was to provide a way to deckare that the failure is expected to only happen on specific test configurations. Instead the Failures class has a ConfigRegExp regular expression which specifies which test configurations the failure applies to. The test 'configuration name' is of the form 'VM:logfile' which allows matching specific Windows versions (thanks to the TestBot VM naming scheme), specific Windows locales (part of the VM name), specific bitnesses (part of the log filename), or specific Wine locales (part of the log filename). For instance: ^w8 -> all Windows 8 VMs :exe -> all Windows tests (exe32.report and exe64.report) ^w10.*_ja.*: -> all Windows 10 Japanese test configurations win|wow -> all Wine test configurations (win32.report, ...) (win|wow).*_fr -> French Wine test configurations * Changes in FailureBlacklists -> Failures - Primary key: (Bug, TestModule, TestUnit) -> Id Some issues generate quite a few failures. So in case trying to match them all results in a regular expression that's too long (either because of the database limit or for readability), this change makes it possible to add multiple Failure objects to track them all. - TestModule -> ErrorGroup The .errors files split the errors in groups. Each group corresponds to a test module, but extra errors (too much output, missing summary lines, etc) are in a separate group. So I renamed TestModule to ErrorGroup as a reminder to the coder that this is meant to match the .errors group names, not just test modules. - Name -> (BugStatus, BugDescription) Instead of having a name describing the failure, this patchset uses the corresponding WineHQ bug description. The TestBot also retrieves the bug status which allows checking that closed bugs dont happen anymore, or open bugs that should be closed. - LastUsed -> (LastNew, LastOld) The LastUse field was split into LastNew and LastOld to track whether the failure would cause false positives without the known failures support. * Changes in FailureBlacklistUses -> TaskFailures - (Bug, TestModule, TestUnit) -> FailureId This is a consequence of the Failure primary key change described above. - () -> (TaskLog) This allows tracking which task log the failure was found in. This is quite important for Wine tasks since they run all the test configurations in just one task. - () -> (NewCount, OldCount) This provides a count of matching failures and whether they would have been tagged as old or new without this patchset. This provides a quick way to know whether there is the same number of failures every time or whether the number of failures changes from one run to the next. It also provides a quick way to know how many failures to look for when jumping to the log. Francois Gouget (6): testbot: Add tables to track the test failures. testbot/web: Add pages to add, edit and show known failures. testbot: Match the failures with the test logs. testbot/web: Link job details to the related known failures. testbot/WineSendLog: Take into account the known failures. testbot/UpdateFailures: Add a script to refresh the failures' bug information. testbot/bin/UpdateFailures.pl | 192 ++++++ testbot/bin/WineSendLog.pl | 78 ++- testbot/ddl/update47.sql | 33 + testbot/ddl/winetestbot.sql | 32 + testbot/doc/INSTALL.txt | 5 + testbot/doc/winetestbot-schema.dia | 852 +++++++++++++++++++++--- testbot/lib/WineTestBot/CGI/PageBase.pm | 1 + testbot/lib/WineTestBot/Config.pm | 6 +- testbot/lib/WineTestBot/Failures.pm | 184 +++++ testbot/lib/WineTestBot/Jobs.pm | 6 + testbot/lib/WineTestBot/LogUtils.pm | 180 ++++- testbot/lib/WineTestBot/TaskFailures.pm | 120 ++++ testbot/lib/WineTestBot/Tasks.pm | 4 + testbot/web/FailureDetails.pl | 119 ++++ testbot/web/FailuresList.pl | 160 +++++ testbot/web/JobDetails.pl | 54 +- testbot/web/WineTestBot.css | 3 + 17 files changed, 1907 insertions(+), 122 deletions(-) create mode 100755 testbot/bin/UpdateFailures.pl create mode 100644 testbot/ddl/update47.sql create mode 100644 testbot/lib/WineTestBot/Failures.pm create mode 100644 testbot/lib/WineTestBot/TaskFailures.pm create mode 100644 testbot/web/FailureDetails.pl create mode 100644 testbot/web/FailuresList.pl -- 2.30.2

1 6

[PATCH v4 0/1] MR190: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail).
by Jinoh Kang (＠iamahuman) June 15, 2022

June 15, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52673 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v4: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail). https://gitlab.winehq.org/wine/wine/-/merge_requests/190

3 2

[PATCH v3 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) June 15, 2022

June 15, 2022

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v3: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. d3dx10/tests: Add D3DX10CreateTextureFromMemory HRESULT argument tests. d3dx10: Don't ignore HRESULT parameter in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 9

[PATCH 0/8] MR250: win32u: user32 conversion
by Jacek Caban (＠jacek) June 15, 2022

June 15, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/250

4 14

[PATCH v2 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) June 15, 2022

June 15, 2022

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- v2: uiautomationcore: Add basic IAccessible2 support. ia2comproxy: Introduce new proxy stub DLL for IAccessible2. include: Import IAccessible2 headers. https://gitlab.winehq.org/wine/wine/-/merge_requests/247

4 8

[PATCH 0/3] MR247: uiautomationcore: Add basic IAccessible2 support.
by Connor McAdams (＠cmcadams) June 15, 2022

June 15, 2022

I'm not sure if there's a 'correct' way to import headers from another project, so this might need some work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/247

3 8

[PATCH 0/3] MR251: cryptnet:
by Hans Leidekker (＠hans) June 15, 2022

June 15, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/251

2 3

[PATCH v2 0/6] MR228: d3dx: improvements to texture creation functions
by Piotr Caban (＠piotr) June 15, 2022

June 15, 2022

- support HRESULT parameter in D3DX10CreateTextureFrom* - implement D3DX10CreateAsyncTextureProcessor -- v2: d3dx10/tests: Add D3DX10CreateAsyncTextureProcessor tests. d3dx10: Add D3DX10CreateAsyncTextureProcessor implementation. d3dx10: Add D3DX10CreateAsyncTextureProcessor stub. d3dx10: Exit early on volume textures in D3DX10CreateTextureFromMemory. https://gitlab.winehq.org/wine/wine/-/merge_requests/228

3 17

[PATCH v2 0/1] MR190: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail).
by Jinoh Kang (＠iamahuman) June 15, 2022

June 15, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52673 Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: shell32: Partially implement IShellItemImageFactory (icon only, no thumbnail). https://gitlab.winehq.org/wine/wine/-/merge_requests/190

3 2