- Wine-Devel - list.winehq.org

Re: [PATCH] msvcrtd/tests: Missing the library should be a win_skip().
by Piotr Caban March 23, 2021

March 23, 2021

Signed-off-by: Piotr Caban <piotr(a)codeweavers.com>

1 0

Re: TestBot job 87490 results: [PATCH 3/5] include: Add missing items_size parameter to GetMany.
by Rémi Bernon March 23, 2021

March 23, 2021

On 3/23/21 10:13 AM, Marvin wrote: > VM Status Failures Command > build success > w2008s64 success 0 windows.gaming.input_test.exe input > w7u_2qxl success 0 windows.gaming.input_test.exe input > w7u_adm success 0 windows.gaming.input_test.exe input > w7u_el success 0 windows.gaming.input_test.exe input > w8 success 0 windows.gaming.input_test.exe input > w8adm success 0 windows.gaming.input_test.exe input > w864 success 0 windows.gaming.input_test.exe input > w1064v1507 failed 1 windows.gaming.input_test.exe input > w1064v1809 failed 2 windows.gaming.input_test.exe input > w1064 failed 2 windows.gaming.input_test.exe input > w10pro64 failed 2 windows.gaming.input_test.exe input > wvistau64 success 0 windows.gaming.input_test64.exe input > w2008s64 success 0 windows.gaming.input_test64.exe input > w864 success 0 windows.gaming.input_test64.exe input > w1064v1507 failed 1 windows.gaming.input_test64.exe input > w1064v1809 failed 2 windows.gaming.input_test64.exe input > w1064 failed 2 windows.gaming.input_test64.exe input > w1064_2qxl failed 2 windows.gaming.input_test64.exe input > w10pro64 failed 2 windows.gaming.input_test64.exe input > w10pro64_ar failed 2 windows.gaming.input_test64.exe input > w10pro64_he failed 2 windows.gaming.input_test64.exe input > w10pro64_ja failed 2 windows.gaming.input_test64.exe input > w10pro64_zh_CN failed 2 windows.gaming.input_test64.exe input > w2008s64 success 0 windows.media.speech_test.exe speech > w7u_2qxl success 0 windows.media.speech_test.exe speech > w7u_adm success 0 windows.media.speech_test.exe speech > w7u_el success 0 windows.media.speech_test.exe speech > w8 success 0 windows.media.speech_test.exe speech > w8adm success 0 windows.media.speech_test.exe speech > w864 success 0 windows.media.speech_test.exe speech > w1064v1507 success 0 windows.media.speech_test.exe speech > w1064v1809 success 0 windows.media.speech_test.exe speech > w1064 success 0 windows.media.speech_test.exe speech > w10pro64 success 0 windows.media.speech_test.exe speech > wvistau64 success 0 windows.media.speech_test64.exe speech > w2008s64 success 0 windows.media.speech_test64.exe speech > w864 success 0 windows.media.speech_test64.exe speech > w1064v1507 success 0 windows.media.speech_test64.exe speech > w1064v1809 success 0 windows.media.speech_test64.exe speech > w1064 success 0 windows.media.speech_test64.exe speech > w1064_2qxl success 0 windows.media.speech_test64.exe speech > w10pro64 success 0 windows.media.speech_test64.exe speech > w10pro64_ar success 0 windows.media.speech_test64.exe speech > w10pro64_he success 0 windows.media.speech_test64.exe speech > w10pro64_ja success 0 windows.media.speech_test64.exe speech > w10pro64_zh_CN success 0 windows.media.speech_test64.exe speech > debiant2 success 0 > debiant2 success 0 > > You can also see the results at: > https://testbot.winehq.org/JobDetails.pl?Key=87490 > > > === w1064v1507 (32 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > > === w1064v1809 (32 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w1064 (32 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w10pro64 (32 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w1064v1507 (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > > === w1064v1809 (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w1064 (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w1064_2qxl (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w10pro64 (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w10pro64_ar (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w10pro64_he (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w10pro64_ja (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > > === w10pro64_zh_CN (64 bit report) === > > windows.gaming.input: > input.c:179: Test failed: IVectorView_Gamepad_GetMany failed, hr 0x8000000b > input.c:351: Test failed: IVectorView_RawGameController_GetMany failed, hr 0x8000000b > I'll fix these, a bit weird that we get E_BOUNDS when vector is empty, but not when it isn't (as in windows.media.speech voices tests), even though the requested range is always out of bounds? -- Rémi Bernon <rbernon(a)codeweavers.com>

1 0

[PATCH 1/5] include: Add DayOfWeek enum in windows.globalization.idl.
by Rémi Bernon March 23, 2021

March 23, 2021

Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> --- include/Makefile.in | 1 + include/windows.globalization.idl | 49 +++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 include/windows.globalization.idl diff --git a/include/Makefile.in b/include/Makefile.in index b71de990aa2..46164b8268f 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -753,6 +753,7 @@ SOURCES = \ windows.foundation.idl \ windows.gaming.input.forcefeedback.idl \ windows.gaming.input.idl \ + windows.globalization.idl \ windows.h \ windows.media.speechsynthesis.idl \ windows.system.idl \ diff --git a/include/windows.globalization.idl b/include/windows.globalization.idl new file mode 100644 index 00000000000..c08f7bd27d9 --- /dev/null +++ b/include/windows.globalization.idl @@ -0,0 +1,49 @@ +/* + * Copyright 2021 Rémi Bernon for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifdef __WIDL__ +#pragma winrt ns_prefix +#endif + +import "inspectable.idl"; +import "asyncinfo.idl"; +import "eventtoken.idl"; +import "windowscontracts.idl"; +import "windows.foundation.idl"; + +namespace Windows { + namespace Globalization { + typedef enum DayOfWeek DayOfWeek; + } +} + +namespace Windows { + namespace Globalization { + [contract(Windows.Foundation.UniversalApiContract, 1.0)] + enum DayOfWeek + { + Sunday = 0, + Monday = 1, + Tuesday = 2, + Wednesday = 3, + Thursday = 4, + Friday = 5, + Saturday = 6 + }; + } +} -- 2.30.2

2 6

[PATCH 1/5] server: Cancel asyncs before closing handles when a process is destroyed.
by Zebediah Figura March 22, 2021

March 22, 2021

test_exit_process_async() essentially validates this. The only reason it currently succeeds (instead of incorrectly returning ERROR_BROKEN_PIPE) is that due to the use of DuplicateHandle() the source handle is never actually closed. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- server/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/process.c b/server/process.c index f65d7abe2af..571a80f0dc6 100644 --- a/server/process.c +++ b/server/process.c @@ -842,8 +842,8 @@ static void process_killed( struct process *process ) if (!process->is_system) close_process_desktop( process ); process->winstation = 0; process->desktop = 0; - close_process_handles( process ); cancel_process_asyncs( process ); + close_process_handles( process ); if (process->idle_event) release_object( process->idle_event ); process->idle_event = NULL; assert( !process->console ); -- 2.30.2

2 5

[PATCH 3/9] devenum: Use nameless structs and unions.
by Jacek Caban March 22, 2021

March 22, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/devenum/Makefile.in | 1 - dlls/devenum/createdevenum.c | 48 ++++++++++++++++++------------------ 2 files changed, 24 insertions(+), 25 deletions(-)

2 1

[PATCH 6/9] wininet/tests: Use nameless structs and unions.
by Jacek Caban March 22, 2021

March 22, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/wininet/tests/Makefile.in | 1 - dlls/wininet/tests/urlcache.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)

2 1

[PATCH v2] winevulkan: Implement vkEnumerateDeviceLayerProperties
by Victor Hermann Chiletto March 22, 2021

March 22, 2021

Currently, this function is passed through winevulkan to the system's Vulkan loader, which causes the loader to write the system's device layers properties in pProperties. Unreal Engine 4 then calls vkEnumerateDeviceExtensionProperties, using VkLayerProperties::layerName as the pLayerName. winevulkan's implementation of vkEnumerateDeviceExtensionProperties then returns VK_ERROR_LAYER_NOT_PRESENT, crashing UE4. This issue was found while debugging Project Wingman (Steam appid 895870), but it should also happen to any UE4 application using the Vulkan RHI. Signed-off-by: Victor Hermann Chiletto <v(a)hnn.net.br> --- v2: Improve the patch's description dlls/winevulkan/make_vulkan | 1 + dlls/winevulkan/vulkan.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/dlls/winevulkan/make_vulkan b/dlls/winevulkan/make_vulkan index 3ad210e4701..a0e59a0370e 100755 --- a/dlls/winevulkan/make_vulkan +++ b/dlls/winevulkan/make_vulkan @@ -153,6 +153,7 @@ FUNCTION_OVERRIDES = { "vkCreateDevice" : {"dispatch" : True, "driver" : False, "thunk" : False}, "vkDestroyInstance" : {"dispatch" : False, "driver" : True, "thunk" : False }, "vkEnumerateDeviceExtensionProperties" : {"dispatch" : True, "driver" : False, "thunk" : False}, + "vkEnumerateDeviceLayerProperties": {"dispatch": True, "driver": False, "thunk": False}, "vkEnumeratePhysicalDeviceGroups" : {"dispatch" : True, "driver" : False, "thunk" : False}, "vkEnumeratePhysicalDevices" : {"dispatch" : True, "driver" : False, "thunk" : False}, "vkGetPhysicalDeviceExternalBufferProperties" : {"dispatch" : False, "driver" : False, "thunk" : False}, diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c index 971394eb9dd..23087c9df2e 100644 --- a/dlls/winevulkan/vulkan.c +++ b/dlls/winevulkan/vulkan.c @@ -1061,6 +1061,14 @@ VkResult WINAPI wine_vkEnumerateInstanceExtensionProperties(const char *layer_na return *count < num_properties ? VK_INCOMPLETE : VK_SUCCESS; } +VkResult WINAPI wine_vkEnumerateDeviceLayerProperties(VkPhysicalDevice phys_dev, uint32_t *count, VkLayerProperties *properties) +{ + TRACE("%p, %p, %p\n", phys_dev, count, properties); + + *count = 0; + return VK_SUCCESS; +} + VkResult WINAPI wine_vkEnumerateInstanceLayerProperties(uint32_t *count, VkLayerProperties *properties) { TRACE("%p, %p\n", count, properties); -- 2.31.0

3 2

[PATCH 9/9] winecfg: Use nameless unions.
by Jacek Caban March 22, 2021

March 22, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/winecfg/Makefile.in | 1 - programs/winecfg/audio.c | 20 ++++++++++---------- 2 files changed, 10 insertions(+), 11 deletions(-)

1 0

[PATCH 8/9] winemenubuilder: Use nameless unions.
by Jacek Caban March 22, 2021

March 22, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/winemenubuilder/Makefile.in | 1 - programs/winemenubuilder/winemenubuilder.c | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-)

1 0

[PATCH 7/9] services: Use nameless unions.
by Jacek Caban March 22, 2021

March 22, 2021

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- programs/services/Makefile.in | 1 - programs/services/rpc.c | 22 +++++++++++----------- 2 files changed, 11 insertions(+), 12 deletions(-)

1 0