- Wine-Devel - list.winehq.org

[PATCH v2 0/1] MR203: ws2_32: Check for valid socket in WSAGetOverlappedResult().
by Paul Gofman (＠gofman) June 8, 2022

June 8, 2022

-- v2: ws2_32: Check for valid socket in WSAGetOverlappedResult(). https://gitlab.winehq.org/wine/wine/-/merge_requests/203

3 2

[PATCH] wevtapi: Add stub for EvtCreateRenderContext.
by Louis Lenders June 8, 2022

June 8, 2022

1 0

[PATCH v4 0/2] MR135: Cancel asyncs queued by thread when the thread is terminated
by Paul Gofman (＠gofman) June 8, 2022

June 8, 2022

Inspired by the discussion for MR 127 (https://www.winehq.org/pipermail/wine-devel/2022-May/217832.html) and is aimed to replace the second patch (ws2_32: Use allocated IO status block in select().) in that MR. When the thread calls server's terminate_thread for itself queuing the system APC though SIGUSR1 might race with the thread exit, there seems no easy and reliable way to be sure that signal is processed before the thread's stack and TEB are freed. Thus I am making the system APCs to be queued to the thread to be processed by server_select() after (terminate_thread) server call. When terminate_thread is called for the other thread the system APC will always be delivered through some other thread. Thread stack and TEB are not freed when the thread is killed externally, so completing the async from another thread should probably be fine. -- v4: ws2_32/tests: Add tests for terminated thread asyncs completion. ntdll: Cancel asyncs when thread is terminated. https://gitlab.winehq.org/wine/wine/-/merge_requests/135

3 4

[PATCH 0/2] MR210: winhttp: Use completion port for overlapped send.
by Paul Gofman (＠gofman) June 8, 2022

June 8, 2022

There are a few issues with the way it is done now: 1. We queue overlapped WSARecv from one (user) thread and then await completion on another. As it became apparent the completions queued by a thread are canceled when thread terminates. That is currently not the case in Wine, but I have a pending MR for that: https://gitlab.winehq.org/wine/wine/-/merge_requests/135. User may use WinhttpWebSocketSend() and close the thread, if it gets to async send path that send may be canceled before it is complete. The only condition when the async operation is not canceled is that the queued async IO has a completion port and no event (which becomes the case with these patches). I tested on Windows that terminating the thread which called WinhttpWebSocketSend() doesn't cancel the async send, while I am reproducing this case with Wine and the refernced patch. 2. Using overlapped WSASend without a completion port or an event is fragile: the socket may potentially be signaled by a parallel async operation (or maybe instead not singaled until that operation completes; I think Wine and Windows currently don't agree in lot of details how that works, including maybe the higher level WSAGetOverlappedResult). This is more of theoretical point as currently we don't queue any overlapped receives. 3. WSAGetOverlappedResult is currently buggy in a funny way. It doesn't check for valid socket handle, and so if called with an overlapped without an event it waits on socket, and if socket is -1 it is current process pseudo handle and the wait hangs forever. I've sent a patch for winsock for that: https://gitlab.winehq.org/wine/wine/-/merge_requests/203. But since we need completion port for 1 anyway it also seems to also solve the potential race issue between setting socket to -1 when aborting operation and starting wait for overlapped IO on it without additional complications. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/210

3 4

Re: [PATCH v2 0/6] MR207: UiaProviderFromIAccessible improvements. - approved
by Alexandre Julliard (＠julliard) June 8, 2022

June 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/207

1 0

Re: [PATCH v2 0/3] MR206: windows.gaming.input: Implement stub IGamepad2 interface. - approved
by Alexandre Julliard (＠julliard) June 8, 2022

June 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/206

1 0

Re: [PATCH v3 0/7] MR195: winhttp: Abort web socket receive operations when the socket handle is closed - approved
by Alexandre Julliard (＠julliard) June 8, 2022

June 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/195

1 0

Re: [PATCH v2 0/5] MR204: win32u: Avoid calling PE code with user lock - approved
by Alexandre Julliard (＠julliard) June 8, 2022

June 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/204

1 0

Re: [PATCH v2 0/1] MR196: winegstreamer: Return void from align_video_info_planes. - approved
by Alexandre Julliard (＠julliard) June 8, 2022

June 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/196

1 0

Re: [PATCH v6 0/1] MR175: d3d11: Do not return uninitialized values on Map() failure. - approved
by Alexandre Julliard (＠julliard) June 8, 2022

June 8, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/175

1 0