- Wine-Devel - list.winehq.org

Const Function Parameters?
by Michael Carlson July 28, 2005

July 28, 2005

I've been doing some oprofille tests with wine running fce ultra, the 8-bit Nintendo emulator. I found that when running a rom for 60 seconds, more than 99% of the CPU utilization for winex11drv (which uses the most of all components of wine in this case) is in the same function : convert_888_to_0888_asis (in dlls/x11drv/dib_convert.c). I've also found that marking a couple of parameters of that function const (that I believe should be marked const anyways), CPU usage in that function drops measurably with oprofile. As far as I know, parameters that aren't modified in a function should be marked const anyways, to send the right hint to the compiler. Since it actually turns out to be faster too, it seems worth it to me. Here are the results from oprofile before the change: 21982 99.2012 convert_888_to_0888_asis 22078 99.1735 convert_888_to_0888_asis 22207 99.1605 convert_888_to_0888_asis 22161 99.1544 convert_888_to_0888_asis 22158 99.2253 convert_888_to_0888_asis and after: 21828 99.1731 convert_888_to_0888_asis 21769 99.2296 convert_888_to_0888_asis 21835 99.3313 convert_888_to_0888_asis 21868 99.1027 convert_888_to_0888_asis 21601 99.1508 convert_888_to_0888_asis On average, it went from 22117 (context switches I believe?) to 21780, about a 1.5% improvement. The same test was run with a script each time (run fceu with the same rom, kill it after 60 seconds). I'm assuming the percentages (the second column in this chart) don't matter much, because this function we're examining takes up an overwhelming amount of the function's CPU (> 99%), so its percentage depends largely on how many context switches other functions took up. I've taken the liberty of providing a diff that patches all the functions in this file to use const parameters where appropriate. I don't get any compiler warnings with this compiling with gcc 4.0.1. Should I submit this to wine-patches? This would be my first patch to wine (or any open-source project, period). I'd appreciate some feedback before I try for it. Thanks in advance!

5 6

More insatllers
by Oliver Stieber July 28, 2005

July 28, 2005

Hi, The axis and allies 2 demo installer requires native ole to install. (http://www.atari.com.au/games/downloads.do?id=24) On the up side, The bards Tale and Juiced demos now install more-or-less correctly. The Bards Tale uses a WISE + MSI installer and has some problems with labels being prefixes with things like {Arial_80} which is a little annoying.(http://www.download.com/The-Bard-s-Tale-updated-demo/3000-8024_4-… Juiced has some problems with bitmaps in the installer. (http://www.download.com/Juiced-final-demo/3000-7534_4-10302658.html?tag=lst…) ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

1 0

Use Gecko to render HTML
by Jacek Caban July 28, 2005

July 28, 2005

Hello. I've sent a patch that makes MSHTML use Gecko to render HTML. Unfortunately, it uses Windows Gecko, not Linux one. Alexandre wrote me that it's impossible to get perfect support for XEmbed container, so, although my implementation was enough for Gecko, it can't go to CVS and I should use Windows one. So, as of now, support for the Linux version went into trash and I've sent this patch. Well, I don't give up with Linux version, I have an other idea, but that's not for the nearest future. One plus is that the Windows version is much simpler... Now it's time to write about this patch. For now it can use Gecko installed with Mozilla Suite or Mozilla ActiveX Control - it could use any Gecko-based product, but we have to be able to search for it (every Gecko-based product has its own registry settings for Gecko path). I'm planning to add Firefox support, but it doesn't work yet and I have to find why. If you think there should be support for any other application, please let me know. As our shdocvw still uses Mozilla ActiveX Control, I think it should be preferred (it's the first one on the search list and it's smallest). In future, when we'll implement shdocvw on top on MSHTML and get rid of Mozilla ActiveX Control dependency, I think it will be better to have a package like wine-gecko with an installer, downloaded automatically when needed (well, not automatically in MS sens, user will be informed about it ;-) ). We need a very limited version of Gecko, so it will be just small package. What does this patch change? You may see IE working on Gecko engine! Not much of its functionality is implemented yet, but a HTML document is displayed. Soon there will be more! To see how it works for your program, probably you will have to set shdocvw to native (and usually urlmon, maybe wininet) and mshtml as builtin. Thanks, Jacek

1 0

[WINEHQ] Lots of buggy < and >
by Francois Gouget July 28, 2005

July 28, 2005

Reading WWN 284 I noticed the following line: > stabilizing for release &. And sure enough the source XML is buggy: > stabilizing for release &<g&>. I believe the intent was the following to deal with the double parsing: > stabilizing for release &lt;g&gt;. But really this double parsing is a major pain. Can't we get rid of it? Because it's causing a lot of bugs: $ egrep "<.*>" wwn/*.sgml | grep -v "who=" | wc -l 190 And it's not just missing grins either. For instance in WWN 125: > gdb <gdb remote protocol> winedbg <Win32 debug API> wineserver and all the reader sees is: > gdb winedbg wineserver which is totally wrong of course. And in WWN 149: > #include <comcat.h> <br /> > #include <oaidl.h><br /> > #include <objbase.h><br /> > #include <objidl.h><br /> ... all the reader sees is: > #include > #include > #include > #include ... Not very informative! -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

2 1

Re: patch for libs/wine/mmap.c making wine running on FreeBSD 5.x
by Alexandre Julliard July 28, 2005

July 28, 2005

"jean-marc DETREZ" <jm.detrez(a)cegetel.net> writes: > I made a little correction of "try_mmap_fixed" because it's seems to me > that the function didn't really test the result (vec). That's the way it should be, we don't care if the page is in core or not, we only want to know if something is mapped there. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [wined3d] repack nonpower2 textures
by Lionel Ulmer July 28, 2005

July 28, 2005

On Thu, Jul 28, 2005 at 01:13:02PM +0100, Oliver Stieber wrote: > repacking can be quite CPU intensive and warhammer 40k is the only game so far > that needs nonpower2 texture repacking so it's turned off by default but can be turned > on via the following registry key: > HKEY_CURRENT_USER/Software/Wine/Direct3D Nonpower2Mode [repack] Is there a way to automagically detect the need for this feature ? If not, how are we going to maintain the list of 'game-specific' WineD3D configurations ? Should we ship this as part of 'wine.inf' or create a new .inf that would install automatically the correct keys ? Lionel -- Lionel Ulmer - http://www.bbrox.org/

1 0

Process Explorer and 16-bit windows applications
by Paul Vriens July 28, 2005

July 28, 2005

Hi, I've reported before that I still had an issue with the version of 16bit windows applications (and hence 16bit resource) reported by Process Explorer. I've emailed the developer about this. His answer: On Thu, 2005-07-21 at 00:20, Mark Russinovich wrote: > Hi Paul, > > I make no effort to support 16-bit programs in Process Explorer. On Windows > NT-based OSes the run within Ntvdm.exe processes and not as "real" > processes. > > -Mark So there was no issue after all. All other version information tools I've used so far, show the correct versions for both win16 and win32 resources. Just to let you know (if you're interested at all in this :-) ) Cheers, Paul.

1 0

Re: ntdll: Try2: Fix IOCTL_SCSI_GET_ADDRESS and HKLM\HARDWARE\DEVICEMAP\Scsi entries
by Alexandre Julliard July 28, 2005

July 28, 2005

Vitaliy Margolen <wine-patch(a)kievinfo.com> writes: > @@ -235,14 +249,18 @@ static void create_hardware_branch(void) > int i; > HANDLE handle; > char drive[] = "\\\\.\\A:"; > + char drive1[] = "A:\\"; > + UINT uNumber = 0; > > /* create entries for cdroms (skipping A: and B:) */ > for (i = 2; i < 26; i++) > { > drive[4] = 'A' + i; > + drive1[0] = 'A' + i; > + if (GetDriveTypeA(drive1) != DRIVE_CDROM) continue; > handle = CreateFileA( drive, 0, 0, NULL, OPEN_EXISTING, 0, 0 ); > if (handle == INVALID_HANDLE_VALUE) continue; You shouldn't use GetDriveType here, you should determine the device type from the ioctls you do on the handle. The GetDriveType result doesn't necessarily correspond to the device since it can be changed in the registry. -- Alexandre Julliard julliard(a)winehq.org

1 0

winecfg in 640x480
by Oliver Stieber July 28, 2005

July 28, 2005

I know this isn't going to be too big an issue with many people but it would be nice if winecfg was usable with a 640x480 desktop, at the moment it's 20 or so pixels to tall and you can't see the ok/cancel buttons. ___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com

2 1

Wine compatibility sponsoring
by Christian Siegert July 28, 2005

July 28, 2005

Hi *, although I am not quite sure if this is the right list for my question, I will try it anyway as I did not find a better list (e.g. jobs)... Being a software development company with limited wine know-how, we are would like to request if there is any interest at any of the developers around to assist us in a wine-customization related project. For one of our customers, we will have to customize a wine system to support a special windows application (a rather complex one from the finance sector) which is currently not *fully* supported (This is the results of recent tests with standard-wine). The results of this special cutomization will be GPLed again, so this could be integrated in the next wine release if wanted by the project. The project will be split in three phases: - Testing of earlier results of wine/application interaction in cooperation with our customer - Modification of wine - Packaging to single launchable application Payment will be subject of negotiation. Anyone of the developers who is interested should contact me directly via phone or mail. -- Viele Grueße / Best regards, Christian Siegert Geschaeftsfuehrer / Executive director ___________________________________________________ Open Source Factory GmbH Stefan-George-Ring 8 81929 Muenchen GERMANY Tel.: +49 (0)89 99 34 13-50 Fax: +49 (0)89 99 34 13-69 E-Mail: info(a)opensourcefactory.com www: http://www.opensourcefactory.com

1 0