- Wine-Devel - list.winehq.org

Re: Fix Using DDraw to Access the Desktop
by Alexandre Julliard July 28, 2005

July 28, 2005

Robert Shearman <rob(a)codeweavers.com> writes: > Previously, using ddraw to write to a small area of the desktop (or > even none at all) would cause the screen to go black because the > contents of the screen wasn't copied to the surface before the surface > was copied back to the screen. This patch fixes that. Of course it's still corrupting the screen, it's just less obvious... -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: Try 2:Implement IOCTL_SCSI_GET_INQUIRY_DATA
by Dmitry Timoshkov July 28, 2005

July 28, 2005

"Vitaliy Margolen" <wine-patch(a)kievinfo.com> wrote: > Check for HAVE_SG_IO_HDR_T_INTERFACE_ID instead of defined Linux > +static NTSTATUS GetInquiryData(int fd, PSCSI_ADAPTER_BUS_INFO BufferOut, DWORD OutBufferSize) > +{ > + PSCSI_INQUIRY_DATA inquirydata = NULL; > + sg_io_hdr_t iocmd; ^^^^^^^^^^^^^^^^^ > + UCHAR inquiry[INQ_CMD_LEN] = {INQUIRY, 0, 0, 0, INQ_REPLY_LEN, 0}; > + UCHAR sense_buffer[32]; > + struct hd_driveid; > + int iochk, version; > + > +#ifdef HAVE_SG_IO_HDR_T_INTERFACE_ID > + /* Check we have a SCSI device and a supported driver */ > + if(ioctl(fd, SG_GET_VERSION_NUM, &version) != 0) This won't compile if sg_io_hdr_t doesn't present. Underlined structure declaration needs to be protected as well. Just add '#undef HAVE_SG_IO_HDR_T_INTERFACE_ID' after config.h include and try to compile. -- Dmitry.

1 0

Version
by jstrupeni July 28, 2005

July 28, 2005

Hello, I'm using a Novell Linux Desktop Version 9 and I don't know which version of Wine I should install. Thank you very much in advance, Juan

2 1

Re: patch for libs/wine/mmap.c making wine running on FreeBSD 5.x
by Dmitry Timoshkov July 28, 2005

July 28, 2005

"jean-marc DETREZ" <jm.detrez(a)cegetel.net> wrote: > @@ -207,6 +207,13 @@ void *wine_anon_mmap( void *start, size_ > #elif defined(__svr4__) || defined(__NetBSD__) || defined(__APPLE__) > if ( try_mmap_fixed( start, size, prot, flags, fdzero, 0 ) ) > return start; > +#elif defined(__FreeBSD__) > + /*for FreeBSD assure system heap adress of 0x80000000*/ > + if (start == (void *)0x80000000) > + { > + if (try_mmap_fixed( start, size, prot, flags, fdzero, 0 ) ) > + return start; > + } > #endif > } > return mmap( start, size, prot, flags, fdzero, 0 ); Why didn't you simply add __FreeBSD__ to the '#elif defined(__svr4__) || defined(__NetBSD__) || defined(__APPLE__)' case? -- Dmitry.

1 0

Re: Implement IOCTL_SCSI_GET_INQUIRY_DATA
by Dmitry Timoshkov July 28, 2005

July 28, 2005

"Vitaliy Margolen" <wine-patch(a)kievinfo.com> wrote: > +static NTSTATUS GetInquiryData(int fd, PSCSI_ADAPTER_BUS_INFO BufferOut, DWORD OutBufferSize) > +{ > + PSCSI_INQUIRY_DATA inquirydata = NULL; > + sg_io_hdr_t iocmd; > + UCHAR inquiry[INQ_CMD_LEN] = {INQUIRY, 0, 0, 0, INQ_REPLY_LEN, 0}; > + UCHAR sense_buffer[32]; > + struct hd_driveid; > + int iochk, version; > + > +#if defined(linux) > + /* Check we have a SCSI device and a supported driver */ Please use appropriate configure checks instead of a blind '#if defined(linux)'. -- Dmitry.

1 0

Re: [wined3d] support get vertexdeclaration with pnumelements set to zero
by Oliver Stieber July 27, 2005

July 27, 2005

With the patch this time --- Oliver Stieber <oliver_stieber(a)yahoo.co.uk> wrote: > Hi, > This patch returns all elements when getDeclaration is called with > pnumelements set to 0. This fixes bugs in Teeage mutant ninja turtles and The > Increadibles. > > > > > > ___________________________________________________________ > Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail > http://uk.messenger.yahoo.com > > ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

2 1

How to pass / convert file names?
by Christian Britz July 27, 2005

July 27, 2005

Hi, I discovered only recently a problem which is probably quite prevalent, but I could not find the answer on the web. Example: I want to configure Mozilla for opening .DOC files with the free Word Viewer that can be downloaded at http://www.microsoft.com. To do so I go to Edit -> Preferences -> Navigator -> "Helper Applications" and create a new MIME-Type "application/msword", extensions "doc dot" and tell the beast to open such files with /home/cbritz/.wine/drive_c/Programme/Microsoft Office/WORDVIEW.EXE (I have configured binfmt support, so I can call the EXE directly) Expected behaviour: The viewer program starts, opens the doc file and displays it. What happens: The viewer program starts and does not open any file. I must manually select Z:\tmp\Example.doc from the application. Next try from command line: .wine/drive_c/Programme/Microsoft\ Office/WORDVIEW.EXE /tmp/Example.doc - Again the doc file doesn't open. It DOES WORK when I manually translate the path name to: .wine/drive_c/Programme/Microsoft\ Office/WORDVIEW.EXE Z:\tmp\Example.doc first. I expected naively that wine automatically translates the Unix scheme to it's own convention but this doesn's seem to be true. Is it possible to instruct wine to translate the path string before it passes it to the windows binary? If not, is there a workaround to do that trick? One solution would probably be to write a wrapper script that translates the path name before it is passed to wine. One discussion board entry I found indicates the CrossOver plugin does it that way. I might even volunteer for trying to write a patch to wine if someone could tell me where to start to look at in the code ;) But probably the solution is already out there and I just don't see it. Any help would be much appreciated! Regards Christian

2 4

bugs #3148 - Still in wine-20050725
by Hiji July 27, 2005

July 27, 2005

Can anyone help out with this bug? It's still in existence in the July Wine release. Basically, I select 3 files, and I click on the highlighted files to try to drag all 3. However, as soon as I click on them, they deselect, and one file is now selected. If I attempt to click+drag the one file, it gets stuck on the click+drag -- that is, I let get go of the mouse button and the highlighted file is still attached to the mouse arrow. Help! I want to use the latest Wine, but it's useless to me if I can't get proper mouse behavior. :S (I'm still stuck on wine-20041201 otherwise.) Hiji __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 2

Re: hhctrl: Add the WebBrowser implementation
by James Hawkins July 27, 2005

July 27, 2005

On 7/27/05, James Hawkins <truiken(a)gmail.com> wrote: > Hey, > > This patch includes these changes: > * no more HH_* macros, no more hhctrl.h > * uses proper ref counting > * stores pointers instead of using ptr arithmetic > * IOleClientSiteImpl frees itself so there is no mem leak > * uses the ICOM_THIS_MULTI macro > * misc cleanups > > Changelog > * Add the WebBrowser implementation. > Can you tell me what needs to be fixed to get this accepted? This is a bare-bones implementation of a embedded web browser, so the S_OKs and the E_NOTIMPL are necessary to make shdocvw happy, but we really don't need those particular api in HTML Help. -- James Hawkins

1 0

Re: hhctrl: Add the WebBrowser implementation
by Dmitry Timoshkov July 27, 2005

July 27, 2005

"James Hawkins" <truiken(a)gmail.com> wrote: > +#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) IMO using 'const' before the type looks more natural. Also adding 'const' to all type conversions wouldn't hurt: const impl* This = (const impl*)((const char*)(iface) - offsetof(impl,field)) > +static HRESULT STDMETHODCALLTYPE Site_SaveObject(IOleClientSite *iface) > +{ > + return E_NOTIMPL; > +} Any chance to add a FIXME to all not implemented interfaces even if you return S_OK in them? > +static IOleClientSiteVtbl MyIOleClientSiteTable = Please make all OLE vtables const and use const keyword for pointers to them in the structures of interface implementations. > + switch (dwAction) > + { > + case WB_GOBACK: > + IWebBrowser2_GoBack(pWebBrowser2); > + break; > + case WB_GOFORWARD: > + IWebBrowser2_GoForward(pWebBrowser2); > + break; > + case WB_GOHOME: > + IWebBrowser2_GoHome(pWebBrowser2); > + break; > + case WB_SEARCH: > + IWebBrowser2_GoSearch(pWebBrowser2); > + break; > + case WB_REFRESH: > + IWebBrowser2_Refresh(pWebBrowser2); If it's intented to not use 'break;' here a comment telling that wouldn't hurt. > + case WB_STOP: > + IWebBrowser2_Stop(pWebBrowser2); > + } default: here wouldn't hurt as well and would show some not expected/implemented cases with a FIXME message. -- Dmitry.

2 3