- Wine-Devel - list.winehq.org

Re: commctrl: modularize progress drawing
by Dimi Paun July 26, 2005

July 26, 2005

From: "Frank Richter" <frank.richter(a)gmail.com> > Frank Richter <frank.richter(a)gmail.com> > Split up the drawing code into a set of smaller functions and also moved > some common computations into helper functions. All that to facilitate > the implementation of the forthcoming theming support. > +static inline int PROGRESS_GetLedSize( PROGRESS_INFO *infoPtr, LONG style, It has become the norm lately to not have the ALLCAPS_ prefix for internal static functions, but rather have names_with_underscores to easily tell them apart from Win32 APIs. So for the above, I guess get_led_size() would be preferable. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

2 2

Adding a new include file (softpub.h)
by Paul Vriens July 26, 2005

July 26, 2005

Hi, for a patch to wintrust_main.c I need to define a GUID (WINTRUST_ACTION_GENERIC_VERIFY_V2). This GUID is present in softpub.h. The include file is not included in Wine right now. What are the 'rules' to add a new include file? Is it ok that have only this GUID in there ? Cheers, Paul. P.S. If somebody already has this one lying around, be my guest :-)

1 0

Re: [wintrust] Return TRUST_E_PROVIDER_UNKNOWN for WinVerifyTrust
by Rein Klazes July 26, 2005

July 26, 2005

On Thu, 14 Jul 2005 13:37:53 +0200 (CEST), you wrote: > Hi, > > currently we return ERROR_SUCCESS for WinVerifyTrust. Process Explorer > expects some data because of this. > > As no trust provider is implemented yet, return TRUST_E_PROVIDER_UNKNOWN > instead. Paul, Girotel was perfectly happy with the ERROR_SUCCESS without anymore "data" (none is actually returned), now it fails. I think that in this case ERROR_SUCCESS should be the default. If you cannot figure out what data your program expects, perhaps you can single out the specific ActionID to return a failure. Rein.

2 3

Re: [wined3d] per app settings regression
by Raphael July 26, 2005

July 26, 2005

On Monday 25 July 2005 20:41, Oliver Stieber wrote: > Hi, > This patch corrects a regression issue in > http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html > Hi You just sent the sme patch :) Maybe you forgot to attach the good one Regards, Raphael

2 1

[wined3d] regression
by Oliver Stieber July 26, 2005

July 26, 2005

Following this patch http://www.winehq.org/hypermail/wine-patches/2005/07/0575.html wined3d SegV's every time the dll is loaded. ___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com

3 4

Re: objsel: Add stubs for objsel.dll and objsel.h
by Thomas Weidenmueller July 26, 2005

July 26, 2005

Thomas Weidenmueller wrote: > The attached archive contains a stubbed objsel.dll and it's public > header file objsel.h Any comments why it got rejected? Best Regards, Thomas

2 1

Windows API
by Bennie Kahler-Venter July 26, 2005

July 26, 2005

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Anyone saw the article in June's Dr. Dobb's Journal, July 95 titled "Finding Binary Clones with Opstrings & Function Digests: Part I" by Andrew Schulman http://www.undoc.com Although just the first article, It already shows promise from wine's perspective. Generating hashes on the functions in the DLL's & EXE's while taking into consideration not to be fooled by the pointer diffs because of different positions in the binaries, Huge potential to find similar functions in all dll's instead of recoding them all. According to the article something Windows suffers from quite a bit... Just my 2c Tnx & Bi Bennie Kahler-Venter -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (GNU/Linux) iD8DBQFC5fc7jrc/ZmvwnjARAgsyAJ9EGFZjvY+bvS4MuUJuS9IZ9WZ59ACgkAr1 ynML4cy/z/JKviK17RrwiOE= =TlTz -----END PGP SIGNATURE-----

1 0

Re: hhctrl: Add the WebBrowser implementation
by Dmitry Timoshkov July 26, 2005

July 26, 2005

"James Hawkins" <truiken(a)gmail.com> wrote: > +#define HH_Alloc(size) ((LPVOID)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size)) > + > +#define HH_Free(buffer) \ > + if (buffer) \ > + HeapFree(GetProcessHeap(), 0, (HLOCAL)buffer); Alot of work has been done to avoid tests for NULL before HeapFree call, please do not introduce them again. Personally I don't see the point of HH_Alloc and HH_Free macros at all. > +#define HH_SafeRelease(x) \ > + if (x) \ > + { \ > + x->lpVtbl->Release(x); \ > + x = NULL; \ > + } Again, a direct access to a vtable. There is no much point in that macro either, do that check directly instead and get rid of hhctrl.h completely. -- Dmitry.

1 0

Bug in native user32
by Jacek Caban July 26, 2005

July 26, 2005

Hello. Fixing MSHTML tests I found a bug in Windows. In tests I passed const WNDCLASSEX, to RegisterClassEx what should work as its declaration is: ATOM WINAPI RegisterClassExW(const WNDCLASSEXW *); Changing passed WNDCLASS to nonconst makes it works. I wrote small tests (attached) showing that if hInstance of WNDCLASSEX is NULL, RegisterClassEx sets it to GetModuleHandle(NULL). It, of course, couses segmentation fault in case CMASSWNDEX is const. This problem seams to happen on XP, NT 4, 2k and 2k3. So the question is if we should clone this bug? Some applications may expect it, but other may crash. They will crash on Windows anyway... Or we should mark test as todo_wine and change it if we found application that depend on it? Thanks, Jacek Index: dlls/user/tests/class.c =================================================================== RCS file: /home/wine/wine/dlls/user/tests/class.c,v retrieving revision 1.19 diff -u -p -r1.19 class.c --- dlls/user/tests/class.c 15 Jun 2005 10:21:19 -0000 1.19 +++ dlls/user/tests/class.c 25 Jul 2005 16:14:10 -0000 @@ -301,6 +301,15 @@ static void test_instances(void) HINSTANCE user32 = GetModuleHandleA("user32"); HINSTANCE main_module = GetModuleHandleA(NULL); + WNDCLASSEXA clsex = { + sizeof(WNDCLASSEXW), + 0, + ClassTest_WndProc, + 0, 0, NULL, NULL, NULL, NULL, NULL, + "const_test", + NULL + }; + memset( &cls, 0, sizeof(cls) ); cls.style = CS_HREDRAW | CS_VREDRAW; cls.lpfnWndProc = ClassTest_WndProc; @@ -436,6 +445,10 @@ static void test_instances(void) ok( !GetClassInfo( 0, name, &wc ), "Class found with null instance\n" ); ok( GetLastError() == ERROR_CLASS_DOES_NOT_EXIST, "Wrong error code %ld\n", GetLastError() ); ok( UnregisterClassA( name, 0 ), "Unregister failed for null instance\n" ); + + ok( RegisterClassExA( &clsex), "RegisterClassExA failed\n"); + ok( clsex.hInstance == GetModuleHandle(NULL), "hInstance=%08lx\n, expected %08lx\n", + clsex.hInstance, GetModuleHandle(NULL)); /* registering for user32 always fails */ cls.lpszMenuName = "user32";

3 3

Re: [AppDB] fix situation when AppDB is not at DocumentRoot (patch 1 of 3) (gah! resend)
by Chris Morgan July 26, 2005

July 26, 2005

I ran into the same issue and was in the process of trying to fix it up. Maybe this is a better approach because it doesn't require any user intervention? The idea was to pass the relative path through that function to get the full local path. I can attach the rest of the patch if you'd like but it isn't in a finished state. Chris On 7/23/05, Tony Lambregts <tony.lambregts(a)gmail.com> wrote: > These patch are to meant address situations like mine when the AppDB is located > a http://localhost/appdb instead of http://localhost/. These patches can be > applied independatly from my other patches. > > Change Log: fix situation when AppDB is not at DocumentRoot. > > Files Changed: include/config.php.sample > > > > > > > > Index: include/config.php.sample > =================================================================== > RCS file: /home/wine/appdb/include/config.php.sample,v > retrieving revision 1.11 > diff -u -r1.11 config.php.sample > --- include/config.php.sample 23 Apr 2005 02:24:35 -0000 1.11 > +++ include/config.php.sample 23 Jul 2005 22:28:16 -0000 > @@ -17,6 +17,11 @@ > define("APPDB_OWNER_URL","http://www.winehq.org/"); // website of this product/company > define("APPDB_OWNER_EMAIL","appdb(a)winehq.org"); // e-mail of this product/company > define("BUGZILLA_ROOT","http://bugs.winehq.org/"); // path to bugzilla > +// the following is usefull if the location of your appdb is offset from the > +// DocumentRoot defined in httpd.config > +// For example: If you access the appdb from http://localhost/appdb > +// uncomment the following line . > +//define("APPDB_OFFSET","/appdb"); > > > /* > > >

1 0