- Wine-Devel - list.winehq.org

Bugzilla in CVS
by Jeremy Newman Dec. 1, 2004

Dec. 1, 2004

http://cvs.winehq.org/cvsweb/bugzilla/ I have imported our buzilla into CVS for anyone to start submitting patches on. If I remember correctly, it is a fairly straight branch of version 2.17.4. All I modified was the templates in: /template/en/default/global Enjoy!

2 1

Fwd: Re: Bug Busters
by Peter Hartshorn Dec. 1, 2004

Dec. 1, 2004

May I suggest that the times given are GMT and at least one days notice so everyone who wants to join in can, no matter where they are on the planet. On Wed, 1 Dec 2004 04:10 pm, James Hawkins wrote: > On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <adam(a)nemesys.ca> wrote: > > James Hawkins wrote: > > > I have a totally non-original idea for sessions called Bug Busters > > > where, at a designated time, a group of wine developers would get > > > together on #winehackers (or some other channel). We would pick a bug > > > (or maybe more) from wine's bug tracker and work together to fix the > > > bug(s). This would serve several good purposed. First, we would be > > > giving more attention to wine's bugzilla and getting rid of a lot of > > > those bugs. Second, many newcomers can witness and take part in the > > > wine development process. I'm sure everyone can remember how daunting > > > it is to jump into wine development. Anyway, if anyone has any ideas > > > or would like to take part in this, let me know and we'll get this > > > started. > > > > This is a good idea, same idea as Gentoo Bug Days, and those have been > > extremely successful. > > Awesome, I think it could be really successful with wine too. -------------------------------------------------------

1 0

Re: Resend [AppDB] show total number of maintainers and applications in the appMaintainers table
by Jeremy Newman Dec. 1, 2004

Dec. 1, 2004

This patch fails to apply to the tip. Update and resend. On Sun, 2004-11-21 at 09:50 -0700, Tony Lambregts wrote: > There was a bug in last one, use this instead. > > Change Log: Show the total number of maintainers and applications in the > appMaintainers table in the admin menu > > Files Changed: include/sidebar_admin.php include/util.php > > > Index: include/sidebar_admin.php > =================================================================== > RCS file: /home/wine/appdb/include/sidebar_admin.php,v > retrieving revision 1.4 > diff -u -r1.4 sidebar_admin.php > --- include/sidebar_admin.php 10 Nov 2004 16:36:25 -0000 1.4 > +++ include/sidebar_admin.php 21 Nov 2004 07:50:43 -0000 > @@ -19,7 +19,7 @@ > $g->add("List Users", $apidb_root."admin/"); > $g->add("View App Queue (".getQueuedAppCount().")", $apidb_root."admin/adminAppQueue.php"); > $g->add("View Maintainer Queue (".getQueuedMaintainerCount().")", $apidb_root."admin/adminMaintainerQueue.php"); > - $g->add("View Maintainers", $apidb_root."admin/adminMaintainers.php"); > + $g->add("View Maintainers (".getMaintainerCount().")", $apidb_root."admin/adminMaintainers.php"); > $g->done(); > > } > Index: include/util.php > =================================================================== > RCS file: /home/wine/appdb/include/util.php,v > retrieving revision 1.4 > diff -u -r1.4 util.php > --- include/util.php 9 Nov 2004 22:51:38 -0000 1.4 > +++ include/util.php 21 Nov 2004 07:50:43 -0000 > @@ -189,4 +189,13 @@ > return $ob->queued_maintainers; > } > > +/* get the total number of maintainers and applications in the appMaintainers table */ > +function getMaintainerCount() > +{ > + $qstring = "SELECT count(*) as maintainers FROM appMaintainers"; > + $result = mysql_query($qstring); > + $ob = mysql_fetch_object($result); > + return $ob->maintainers; > +} > + > ?> > > > >

1 0

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does
by pvriens＠xs4all.nl Dec. 1, 2004

Dec. 1, 2004

Hi, just wanted to mention the fact that after this fix, my ZooTycoon demo installs like a charm. It doesn't run yet, but I will look into this and hopefully come up with some answers/patches. I guess several Microsoft Game Installers will work as well now. Good stuff. Cheers, Paul Vriens.

1 0

Re: gdi/mfdrv BS_PATTERN brushes
by Huw D M Davies Dec. 1, 2004

Dec. 1, 2004

On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote: > > This fixes the problem that Emanuele Gisi reported last month in the Aloha > problem. With this patch BS_PATTERN brushes get created correctly and > don't cause a locking problem. > > Changelog: > Fix creation of BS_PATTERN brushes in mfdrv > > > Index: dlls/gdi/mfdrv/objects.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v > retrieving revision 1.14 > diff -u -r1.14 objects.c > --- dlls/gdi/mfdrv/objects.c 22 Nov 2004 18:19:59 -0000 1.14 > +++ dlls/gdi/mfdrv/objects.c 30 Nov 2004 06:10:03 -0000 > - mr->rdFunction = META_DIBCREATEPATTERNBRUSH; > + mr->rdFunction = META_CREATEPATTERNBRUSH; Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record under Windows? Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Bug Busters
by James Hawkins Dec. 1, 2004

Dec. 1, 2004

I have a totally non-original idea for sessions called Bug Busters where, at a designated time, a group of wine developers would get together on #winehackers (or some other channel). We would pick a bug (or maybe more) from wine's bug tracker and work together to fix the bug(s). This would serve several good purposed. First, we would be giving more attention to wine's bugzilla and getting rid of a lot of those bugs. Second, many newcomers can witness and take part in the wine development process. I'm sure everyone can remember how daunting it is to jump into wine development. Anyway, if anyone has any ideas or would like to take part in this, let me know and we'll get this started. -- James Hawkins

7 18

which classes support aggregation?
by James Hawkins Dec. 1, 2004

Dec. 1, 2004

IClassFactory->CreateInstance aggregation check: "The CreateInstance method of IClassFactory takes pUnkOuter as the second member. This parameter must be null unless the class supports aggregation, which many don't." Where can I find out which classes support aggregation? -- James Hawkins

3 2

implementing DllCanUnloadNow questions
by James Hawkins Dec. 1, 2004

Dec. 1, 2004

I sent this message a couple months ago, but I got no response so I'll try again. I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. Is LockServer(TRUE/FALSE) the same as this example? static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { IClassFactoryImpl *This = (IClassFactoryImpl *)iface; FIXME("(%p)->(%d),stub!\n",This,dolock); return S_OK; } If they are the same, what is needed to complete this stub? I would think that there would be a refCount variable that is incremented if dolock is true and decremented if dolock is false. Also, should the LockServer functions be listed in the spec files of the dlls? After implementing LockServer, it should be an easy matter to do a check for refCount == 0 to see if the dll can be unloaded or not. Am I heading in the right direction? -- James Hawkins

3 4

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does
by Robert Shearman Dec. 1, 2004

Dec. 1, 2004

Dmitry Timoshkov wrote: >Hello, > >there is at least one application which crashes in CreateThread due >to a race between a creating thread and a newly created one. The problem >is that the tid address passed to CreateThread resides in the memory >block allocated with VirtualAlloc which gets freed once the newly created >thread starts running, and when CreateThread code attempts to store thread >id it crashes. > >It appears that Windows always creates suspended threads in CreateThread >and a created thread gets resumed later. Here is a snippet of the log >running a simple test program under NT strace (the test app just creates >a thread): > >hThread = CreateThread(NULL, 0, thread_proc, NULL, 0, &tid); >CloseHandle(hThread); > >... >117 796 792 NtCreateThread (0x1f03ff, 0x0, -1, 1243704, 1244568, 1, ... 60, {796, 800}, ) == 0x0 >118 796 792 NtRequestWaitReplyPort (40, {28, 52, new_msg, 0, 2013529912, 2147348480, 902, 2086471576} "\0\0\0\0\1\0\1\0x\1\23\0\320<\23\0<\0\0\0\34\3\0\0 \3\0\0" ... {28, 52, reply, 0, 796, 792, 2138, 0} "\0\0\0\0\1\0\1\0\0\0\0\0\320<\23\0<\0\0\0\34\3\0\0 \3\0\0" ) == 0x0 >119 796 792 NtResumeThread (60, ... 1, ) == 0x0 >120 796 792 NtClose (60, ... ) == 0x0 >... > >Changelog: > Dmitry Timoshkov <dmitry(a)codeweavers.com> > Always create a suspended thread in CreateThread and resume it > if CREATE_SUSPENDED flag is not set as Windows does. > >--- cvs/hq/wine/dlls/kernel/thread.c 2004-09-22 16:48:59.000000000 +0900 >+++ wine/dlls/kernel/thread.c 2004-12-01 18:04:52.000000000 +0800 >@@ -164,7 +164,7 @@ HANDLE WINAPI CreateRemoteThread( HANDLE > if (flags & STACK_SIZE_PARAM_IS_A_RESERVATION) stack_reserve = stack; > else stack_commit = stack; > >- status = RtlCreateUserThread( hProcess, NULL, (flags & CREATE_SUSPENDED) != 0, >+ status = RtlCreateUserThread( hProcess, NULL, TRUE, > NULL, stack_reserve, stack_commit, > THREAD_Start, info, &handle, &client_id ); > if (status == STATUS_SUCCESS) >@@ -172,6 +172,19 @@ HANDLE WINAPI CreateRemoteThread( HANDLE > if (id) *id = (DWORD)client_id.UniqueThread; > if (sa && (sa->nLength >= sizeof(*sa)) && sa->bInheritHandle) > SetHandleInformation( handle, HANDLE_FLAG_INHERIT, HANDLE_FLAG_INHERIT ); >+ if (!(flags & CREATE_SUSPENDED)) >+ { >+ DWORD ret; >+ >+ status = NtResumeThread( handle, &ret ); >+ if (status) >+ { >+ NtTerminateThread( handle, -1 ); >+ RtlFreeHeap( GetProcessHeap(), 0, info ); >+ SetLastError( RtlNtStatusToDosError(status) ); >+ handle = 0; >+ } >+ } > } > else > > I think you should close the thread handle in the error case, otherwise it will be leaked. Rob

1 0

Debian Packages Almost Ready
by Scott Ritchie Dec. 1, 2004

Dec. 1, 2004

Debian packages are almost done. I have them up for testing. Add the following to /etc/apt/sources.list deb http://tuzakey.com/~scott/ binary/ deb-src http://tuzakey.com/~scott/ source/ My friend's webserver can't handle the huge bandwidth permanent hosting of packages like this will require, so if there's a way we could put them up on winehq it would be nice. I'd like to have an apt repository here, so installing the latest debian wine package would be as simple as adding something like the above line to sources.list and then doing things as normal. What would be ideal, of course, is if the package could be included in the Debian distribution itself. I've yet to hear back from Ove (the current maintainer of the package), and unless he's disappeared entirely there's really nothing that can be done until he decides to update the package or orphan it, as Debian maintainers have total control over their packages. Ubuntu is a different matter, however, and I may be able to get an Ubuntu version included much quicker. If you're a Debian/Ubuntu user, test out the packages and tell me if I left anything out. Thanks, Scott Ritchie

1 0