- Wine-Devel - list.winehq.org

Small WinMM janitorial project
by Steven Edwards Dec. 1, 2004

Dec. 1, 2004

Hi, With this patch it is possible to use a few Windows sound drivers under ReactOS but I have only submitted patches for one small part of this because its going to require a bit of rework of the existing WinMM code. This should fix 2 of the existing W->A CrossCall issues # dlls/winmm/winmm.c: winmm: waveInGetDevCapsW: illegal call to waveInGetDevCapsA # dlls/winmm/winmm.c: winmm: waveOutGetDevCapsW: illegal call to waveOutGetDevCapsA but before it can be merged we have to rewrite the Wine drivers to accept Unicode. I am planing on adding this as a subproject to the Janitorial page. Thanks Steven __________________________________ Do you Yahoo!? Meet the all-new My Yahoo! - Try it today! http://my.yahoo.com

1 0

Debugging of Windows App
by Bernard Gallet Nov. 30, 2004

Nov. 30, 2004

I am trying to debug a Windows app on Wine. I have the source code, it is compiled with Visual Studio 2002. I have not yet been able to get Line/File info. It is my understanding that winedbg does not recognize pdb, however, I am unable to link without one! Can somebody help? T IA, - Bernard GALLET -

2 1

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage
by Mike McCormack Nov. 30, 2004

Nov. 30, 2004

The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log. err:imagelist:ImageList_LoadImageW Error loading image! Mike Alexandre Julliard wrote: > ChangeSet ID: 14326 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/10/26 16:17:50 > > Modified files: > dlls/shell32/tests: shellpath.c > dlls/shell32 : version.h > > Log message: > Juan Lang <juan_lang(a)yahoo.com> > Update shell32's version to WinXP level. > > Patch: http://cvs.winehq.org/patch.py?id=14326 > > Old revision New revision Changes Path > 1.3 1.4 +0 -2 wine/dlls/shell32/tests/shellpath.c > 1.1 1.2 +4 -4 wine/dlls/shell32/version.h

6 6

Re: acmstream mem leak fix
by MichaelGuennewig＠gmx.de Nov. 30, 2004

Nov. 30, 2004

James Hawkins <truiken(a)gmail.com> writes: > Unless I'm mistaken, we don't want to free allocated memory only when > the call fails. Sorry, but you are wrong. When you always free the memory you will run into a segmentation fault when the application uses the returned stream. The problem is the same as with the icmstream patch you made. The current implementation will work correctly in all cases although it doesn't look very COM-like as Mike already pointed out for the icmstream patch. The methods you analyzed are only called internally from IClassFactory_fnCreateInstance in the factory.c file. The memory block which is allocated by LocalAlloc in the AVIFILE_CreateICMStream and AVIFILE_CreateACMStream is only returned to the application if the IAVIStream_QueryInterface call doesn't return an error. So when you always free the memory block you will most probably run into a segmentation fault. The proposed patch from Mike for the icmstream.c file should be adapted to this file when you don't like the LocalFree call there, but I'm sure that then people will ask why we don't call LocalFree in this method. So it would be perhaps fine when also some comments would be added to prevent another discussion about what's wrong or correct. When you don't understand the code feel free to write me as I'm the one who has produced it. Regards Michael Günnewig

1 0

<<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive
by Robert van Herk Nov. 30, 2004

Nov. 30, 2004

Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed just for picking a Windows folder, was split up. It was to be found in brsfolder.c, but I split this in: brsfolder.c brsfolder.h brsfolder_windows.c brsfolder_windows.h brsfolder_unix.c brsfolder_unix.h unixTools.c unixTools.h, Otherwise I found the code to be incomprehendible. Furthermore, winecfg now uses the wine_shell_browse_for_UNIX_directoryA to let the user pick a UNIX directory as root for his virtual drive mappings. Regards, Robert van Herk

1 0

Re: misc. crypt test mem leak fixes
by Dmitry Timoshkov Nov. 30, 2004

Nov. 30, 2004

"James Hawkins" <truiken(a)gmail.com> wrote: > Changelog > * misc. crypt test mem leak fixes Apparently lines with LocalAlloc were added by mistake instead of LocalFree. -- Dmitry.

2 1

Problem with file dialog
by Stefan Dösinger Nov. 30, 2004

Nov. 30, 2004

Hello, This patch breakes the file open/save dialog for me: http://www.winehq.org/hypermail/wine-cvs/2004/11/0086.html The 5 buttons(go up one folder, go to desktop, new folder, ...) appear above the directory selektor and have a height of only a few pixels, so the icons are not visible and it's hard to click the buttons(see the attached screenshot). Reversing lines 89-96 of the patch solves the problem. I don't send a patch, because I don't think simply reversing the lines is the correct solution. What is a correct fix for this? Cheers, Stefan

2 2

Porting SmartWin a Windows API GUI library...
by Thomas Hansen Nov. 30, 2004

Nov. 30, 2004

I'm the admin of http://smartwin.sourceforge.net and I've been thinking that if this library (SmartWin) could be ported to WineLib that would be really awesome... I would definitely take it right into the CVS (unless it breaks everything) and I'd make it a definitely focus trying to keep the compatibility towards WineLib in later releases... I assume it would be a nice project to do too. (not too much code, only about 15 000 lines with LOTS of comments) Not to mention the benefit it would give the community having a Windows API library being ported to Wine... Comments sombody...? Thomas Hansen -- http://smartwin.sourceforge.net THE template based C++ Windows API GUI Abstraction Library

2 1

Re: icmstream mem leak fix
by Mike McCormack Nov. 30, 2004

Nov. 30, 2004

Hi James, That looks kind of wrong, both the before and after... Interfaces should be released, not free'd... Secondly, freeing the interface if the Query works is almost definitely wrong, because ppv will likely point to the same memory as pstream. Mike James Hawkins wrote: > hr = IAVIStream_QueryInterface((IAVIStream*)pstream, riid, ppv); > - if (FAILED(hr)) > - LocalFree((HLOCAL)pstream); > + > + LocalFree((HLOCAL)pstream); > > return hr; > }

2 4

Re: Systray rewrite
by Grant Williamson Nov. 30, 2004

Nov. 30, 2004

Hi Mike, patching is clean on 20041019, however .. fails with make[2]: Entering directory `/tmp/wine-20041019/dlls/shell32' ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./shell32.spec shell.spec.o shell.o authors.o autocomplete.o brsfolder.o changenotify.o classes.o clipboard.o control.o cpanelfolder.o dataobject.o debughlp.o dialogs.o dragdrophelper.o enumidlist.o folders.o iconcache.o memorystream.o pidl.o regsvr.o shell32_main.o shelllink.o shellole.o shellord.o shellpath.o shellreg.o shellstring.o shfldr_desktop.o shfldr_fs.o shfldr_mycomp.o shlexec.o shlfileop.o shlfolder.o shlfsbind.o shlmenu.o shlview.o shpolicy.o shv_bg_cmenu.o shv_item_cmenu.o systray.o shell32.dll.dbg.o shres.res version.res -o shell32.dll.so -L../../dlls -Wb,-dole32 -lshlwapi -lcomctl32 -luser32 -lgdi32 -ladvapi32 -lkernel32 -L../../libs/wine -lwine -luuid -L../../libs/unicode -lwine_unicode -L../../libs/port -lwine_port shell32_main.o(.text+0x23c6): In function `DllMain': /usr/src/redhat/BUILD/wine-20041019/dlls/shell32/shell32_main.c:962: undefined reference to `SYSTRAY_Init' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [shell32.dll.so] Error 2 make[2]: Leaving directory `/tmp/wine-20041019/dlls/shell32' make[1]: *** [shell32] Error 2 make[1]: Leaving directory `/tmp/wine-20041019/dlls' make: *** [dlls] Error 2 Mike Hearn wrote: >Here it is, at last, just what the doctor ordered. All in a separate >wineshell process, and with cleaner code to boot. No thread safety >needed. Hopefully this is now satisfactory and can go in. > >The intention is that wineshell becomes a generic explorer-alike process >in terms of responsibility. For now, I have it being started >automatically by shell32 (to avoid the startup penalty), and shutting >down a few seconds after the last icon is gone like the wineserver. If >we start putting more stuff in there like a DDE server, we may have to >rethink that strategy. > >ChangeLog: >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > > >

1 0