- Wine-Devel - list.winehq.org

Fun desktop integration tasks
by Mike Hearn Nov. 28, 2004

Nov. 28, 2004

Hi everybody, I'm sitting waiting for a couple of compiles to finish, so I thought I'd put together a list of fun/interesting tasks people might like to have a go at related to better integrating Wine with the native desktop. None of these should be especially hard, and so would provide a good intro to Wine development for anybody who has been lurking on the sidelines and wants to get involved. As usual no guarantees these patches would be accepted, that's Alexandres call. But they probably would be, and you'll learn something while doing them! :) Task 1: Map CSIDL_PERSONAL (My Documents) to the $HOME directory if mapped. See the _SHGetDefaultValue function in dlls/shell32/shellpath.c for an explanation of how to do this. I think it'd be ok to grab $HOME using the UNIX getenv() and then using the libwine APIs to map them to a Win32 path. If the mapping fails (ie $HOME is not accessible given the users dosdevices) then just fail with a WARN(). Task 2: This is similar to above but with some extra work. Map the contents of the ~/Desktop directory to the Windows virtual Desktop folder. In file pickers and Explorer, the filesystem root is represented by a magic Desktop folder. In real Windows this reflects the icons that are on the desktop and is mapped to a real directory at some arbitrary point in the filing system. On Linux we have no such virtual root, however it'd be nice if icons that appeared in the KDE/GNOME desktop were put in their proper place. That way users won't be confused by the file being on their desktop but unavailable from their Windows applications file picker. This should not be too hard. The Desktop folder is implemented by a COM object in dlls/shell32/shfldr_desktop.c. You just need to read the $HOME/Desktop folder and put the items you find in there inside. Ignore .desktop files for now, they are a bit tricker to map and aren't especially useful for us anyway. You also want to map CSIDL_DESKTOP in dlls/shell32/shellpath.c, _SHGetDefaultValue. See above. Bonus points for fixing the desktop icon while you're at it (an arrow??!) Task 3: The freedesktop.org icon theme specification shows us how to find icons for many different types of thing. Implement support for loading and using the following icons from the icon theme (it should be OK to use native libraries for this like GdkPixbuf, just fall back to the compiled in defaults if it's missing): - folder - desktop - computer - unknown document - any others?? Don't do file types, as native icon<->file type association is done by mime types not extensions, and it'd make our file dialogs even slower than they already are. You may be tempted to use eg, libpng to implement this. Don't! Use GdkPixbuf instead, stock icons are allowed to be in many formats including SVG. Task 4: Try updating the menu mapping code to support the new XDG menu specification. Don't bother trying to make this work everywhere, it's a total nightmare. Just try supporting the new standards. Be warned: not every desktop/distro supports this yet! This one might be quite hard. Task 5: Try improving the winebrowser script to take into account the users preferred applications. At the moment it just tries every browser it knows about in a hard coded order. Hint: in modern GNOME desktops you can use the "gnome-open" program to make this automatic. There is a KDE equivalent. Task 6: Integrate Wine with XScreensaver, so installing Win32 screensavers makes them automatically appear in the list. You may need to write patches for xscreensaver to make this really slick. Have fun! thanks -mike

6 8

Re: Moved dll list from DEVELOPERS-HINTS into separated file
by Dimitrie O. Paun Nov. 28, 2004

Nov. 28, 2004

On Fri, Nov 26, 2004 at 10:04:49PM -0500, Jacek Caban wrote: > I saw in TODO list "Get rid of the list of DLLs, it's too big, and adds > too little information", > so I thought it could be moved into separated file dlls/DLL-LIST. I think this is a good idea: while I agree that the list is a bit much for DEVELOPERS-HINTS, it's still a nice overview of the dlls we have, and it would be a real pitty to lose. -- Dimi.

2 1

Adding debuginfo Support to Wine Makefiles
by Robert Shearman Nov. 28, 2004

Nov. 28, 2004

Hi, I want to add support generating .debug files that are linked from .so files so that we can have one set of binaries, no matter whether a person is a developer or end-user and yet have no additional disk space or bandwidth costs. This is really just a RFC about changes I've made to the DLL makefiles, before I start copying and pasting them to the other areas. Am I on the right lines here? Do I need to add a configure check for objcopy? Do I need a configure check for the --add-gnu-debuglink option? Rob

3 5

Re: Resend: Re-implement MSVCRT *printf functions
by Aneurin Price Nov. 28, 2004

Nov. 28, 2004

Any further comments on this?

4 6

Translate dir names into Spanish
by Joaquín Fernández Nov. 28, 2004

Nov. 28, 2004

Hi I have some programs in spanish for windows but when i install it i have problems with dir names, for example "Program Files" is "Archivos de programa", "Common Files" is "Archivos comunes", and so. Can i translate this names in source and compiling without problem?? which files i need update?? Can i translate Wine into spanish?? How? Regards Joaquín -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

1 0

Re: Unicodified fontdlg (next try)
by Robert Shearman Nov. 26, 2004

Nov. 26, 2004

Jacek Caban wrote: > Changelog: > Unicodified fontdlg > >------------------------------------------------------------------------ > >@@ -216,52 +213,60 @@ > */ > BOOL WINAPI ChooseFontA(LPCHOOSEFONTA lpChFont) > { >- LPCVOID template; >- HRSRC hResInfo; >- HINSTANCE hDlginst; >- HGLOBAL hDlgTmpl; >- >- if ( (lpChFont->Flags&CF_ENABLETEMPLATEHANDLE)!=0 ) >- { >- template=(LPCVOID)lpChFont->hInstance; >- } else >- { >- if ( (lpChFont->Flags&CF_ENABLETEMPLATE)!=0 ) >- { >- hDlginst=lpChFont->hInstance; >- if( !(hResInfo = FindResourceA(hDlginst, lpChFont->lpTemplateName, >- (LPSTR)RT_DIALOG))) >- { >- COMDLG32_SetCommDlgExtendedError(CDERR_FINDRESFAILURE); >- return FALSE; >- } >- } else >- { >- hDlginst=COMDLG32_hInstance; >- if (!(hResInfo = FindResourceA(hDlginst, "CHOOSE_FONT", (LPSTR)RT_DIALOG))) >- { >- COMDLG32_SetCommDlgExtendedError(CDERR_FINDRESFAILURE); >- return FALSE; >- } >- } >- if (!(hDlgTmpl = LoadResource(hDlginst, hResInfo )) || >- !(template = LockResource( hDlgTmpl ))) >- { >- COMDLG32_SetCommDlgExtendedError(CDERR_LOADRESFAILURE); >- return FALSE; >- } >+ CHOOSEFONTW chFontw; >+ LOGFONTW logFontw; >+ LPLOGFONTA lpLogFonta; >+ int len; >+ BOOL ret; >+ LPSTR lpszStyle; >+ LPCSTR lpTemplateName; >+ >+ memcpy(&chFontw, lpChFont, sizeof(CHOOSEFONTW)); >+ memcpy(&logFontw, lpChFont->lpLogFont, sizeof(LOGFONTA)); >+ chFontw.lpLogFont = &logFontw; >+ >+ MultiByteToWideChar(CP_ACP, 0, lpChFont->lpLogFont->lfFaceName, >+ LF_FACESIZE, chFontw.lpLogFont->lfFaceName, LF_FACESIZE); >+ >+ if(lpChFont->lpszStyle) { >+ len = MultiByteToWideChar(CP_ACP, 0, lpChFont->lpszStyle, -1, NULL, 0); >+ chFontw.lpszStyle = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len*sizeof(WCHAR)); > > Initialising the whole string to zero just before it is about to be overwritten seems needlessly wasteful on CPU cycles and memory bandwidth. You seem to do this in a few places. Yes, MultiByteToWideChar can, in some cases, leave the string without a null terminator, but that only happens when there is insufficient buffer. In this case, the only way that can happen is if another thread modifies the buffer between the previous MultiByteToWideChar and the next one here. If you wanted to be really careful, you could always add "chFontw.lpszStyle[len-1] = '\0';" after to call to MultiByteToWideChar. >+ MultiByteToWideChar(CP_ACP, 0, lpChFont->lpszStyle, -1, chFontw.lpszStyle, len); >+ HeapFree(GetProcessHeap(), 0, lpChFont->lpszStyle); > > You seem to be freeing a buffer that the user passed in. How do you know it was allocated with HeapAlloc? >+ } >+ >+ if(lpChFont->lpTemplateName) { >+ len = MultiByteToWideChar(CP_ACP, 0, lpChFont->lpTemplateName, -1, NULL, 0); >+ chFontw.lpTemplateName = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len*sizeof(WCHAR)); >+ MultiByteToWideChar(CP_ACP, 0, lpChFont->lpTemplateName, >+ -1, (LPWSTR)chFontw.lpTemplateName, len); >+ } >+ >+ ret = ChooseFontW(&chFontw); >+ >+ lpLogFonta = lpChFont->lpLogFont; >+ lpszStyle = lpChFont->lpszStyle; >+ lpTemplateName = lpChFont->lpTemplateName; >+ memcpy(lpChFont, &chFontw, sizeof(CHOOSEFONTA)); >+ lpChFont->lpLogFont = lpLogFonta; >+ lpChFont->lpszStyle = lpszStyle; >+ lpChFont->lpTemplateName = lpTemplateName; >+ memcpy(lpChFont->lpLogFont, &logFontw, sizeof(LOGFONTA)); >+ WideCharToMultiByte(CP_ACP, 0, logFontw.lfFaceName, >+ LF_FACESIZE, lpChFont->lpLogFont->lfFaceName, LF_FACESIZE, 0, 0); >+ >+ if(chFontw.lpszStyle) { >+ len = WideCharToMultiByte(CP_ACP, 0, chFontw.lpszStyle, -1, NULL, -1, 0, 0);; >+ WideCharToMultiByte(CP_ACP, 0, chFontw.lpszStyle, -1, lpChFont->lpszStyle, len, 0, 0); >+ HeapFree(GetProcessHeap(), 0, chFontw.lpszStyle); > } >- if (TRACE_ON(commdlg)) >- _dump_cf_flags(lpChFont->Flags); > >- if (lpChFont->Flags & (CF_SELECTSCRIPT | CF_NOVERTFONTS )) >- FIXME(": unimplemented flag (ignored)\n"); >+ if(chFontw.lpTemplateName) >+ HeapFree(GetProcessHeap(), 0, (LPBYTE)chFontw.lpTemplateName); > > You shouldn't need a cast here, unless lpTemplateName is a const. > >- return DialogBoxIndirectParamA(COMDLG32_hInstance, template, >- lpChFont->hwndOwner, FormatCharDlgProcA, (LPARAM)lpChFont ); >+ return ret; > } > >- > #define TEXT_EXTRAS 4 > #define TEXT_COLORS 16 > > > ... >@@ -1072,34 +1083,34 @@ > } > > /*********************************************************************** >- * FormatCharDlgProcA [internal] >+ * FormatCharDlgProc [internal] > */ >-INT_PTR CALLBACK FormatCharDlgProcA(HWND hDlg, UINT uMsg, WPARAM wParam, >+INT_PTR CALLBACK FormatCharDlgProc(HWND hDlg, UINT uMsg, WPARAM wParam, > LPARAM lParam) > { >- LPCHOOSEFONTA lpcf; >+ LPCHOOSEFONTW lpcf; > INT_PTR res = FALSE; > > if (uMsg!=WM_INITDIALOG) > { >- lpcf=(LPCHOOSEFONTA)GetPropA(hDlg, WINE_FONTDATA); >- if (!lpcf && uMsg != WM_MEASUREITEM) >+ lpcf=(LPCHOOSEFONTW)GetPropW(hDlg, strWineFontData); >+ if (!lpcf) > return FALSE; > if (CFn_HookCallChk32(lpcf)) >- res=CallWindowProcA((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); >+ res=CallWindowProcW((WNDPROC)lpcf->lpfnHook, hDlg, uMsg, wParam, lParam); > > This isn't something wrong with your patch, but is in the original code too. We shouldn't need to cast here, because if lpfnHook isn't using the right calling conventions or doesn't have the same number of parameters then we shouldn't be using CallWindowProc to start with. > if (res) > return res; > } > else > { >- lpcf=(LPCHOOSEFONTA)lParam; >+ lpcf=(LPCHOOSEFONTW)lParam; > if (!CFn_WMInitDialog(hDlg, wParam, lParam, lpcf)) > { > TRACE("CFn_WMInitDialog returned FALSE\n"); > return FALSE; > } > if (CFn_HookCallChk32(lpcf)) >- return CallWindowProcA((WNDPROC)lpcf->lpfnHook,hDlg,WM_INITDIALOG,wParam,lParam); >+ return CallWindowProcW((WNDPROC)lpcf->lpfnHook,hDlg,WM_INITDIALOG,wParam,lParam); > } > switch (uMsg) > { > > Rob

1 0

Re: profiling GTA4. question about polling
by Brian Gunlogson Nov. 26, 2004

Nov. 26, 2004

The patch you gave me is too incomplete to run GTA :( I can start a game, but once the loading screen says it is done, the game crashes. Looked at the console, it says, "fixme:drawStridedFast TODO". The crash happens at the end of drawStridedFast(), inside glDrawElements(). Your patch will really speed things up when it is finished. In a fresh CVS tree, I disabled drawStridedSlow and applied 2 polling patches submitted to wine-patches. The game works almost as fast as in Windows!! Brian G. --- Raphael <fenix(a)club-internet.fr> wrote: > Here is it. > > But i have some problems with hardware vertex buffers (using vbo extension) > i have some 'transparent" objects (ie graphics bugs) > Anyway, If you encounter same problems you can uncomment this line: > //useSoft |= (0 != (Usage & D3DUSAGE_WRITEONLY)); > (dls/d3d8/vertexbuffer.c at line 71) __________________________________ Do you Yahoo!? Yahoo! Mail - You care about security. So do we. http://promotions.yahoo.com/new_mail

2 2

Internet Explorer 6 Installer script
by Hajime Segawa Nov. 26, 2004

Nov. 26, 2004

I wrote a tiny shell script that can install IE6sp1 and WMP7. I hope this script can help you. RealPlayer 10, MSN Messenger 6.4, Yahoo!Japan Messenger seem to work with this configuration. http://sidenet.ddo.jp/winetips/config.html I took some screenshots. http://sidenet.ddo.jp/winetips/files/

2 2

dlls/mscms/profile.c breakage
by Gerald Pfeifer Nov. 25, 2004

Nov. 25, 2004

The following change to dlls/mscms/profile.c revision 1.6 date: 2004/11/21 15:48:18; author: julliard; state: Exp; lines: +135 -3 Implement and test GetColorProfileElementTag, GetCountColorProfileElements and IsColorProfileTagPresent. Stub GetStandardColorSpaceProfile{A,W}. breaks FreeBSD 4.10 (with XFree86-4.3.0) as follows: gmake[2]: Entering directory `/.amd_mnt/nashira/files5/test/wine/dlls/mscms' /sw/gcc-3.3.4/bin/gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o profile.o profile.c profile.c: In function `GetColorProfileElementTag': profile.c:142: error: `LCMSICCPROFILE' undeclared (first use in this function) profile.c:142: error: (Each undeclared identifier is reported only once profile.c:142: error: for each function it appears in.) profile.c:142: error: `cmsprofile' undeclared (first use in this function) profile.c:142: error: parse error before ')' token profile.c: In function `GetCountColorProfileElements': profile.c:174: error: `LCMSICCPROFILE' undeclared (first use in this function) profile.c:174: error: `cmsprofile' undeclared (first use in this function) profile.c:174: error: parse error before ')' token gmake[2]: *** [profile.o] Error 1 gmake[2]: Leaving directory `/.amd_mnt/nashira/files5/test/wine/dlls/mscms' Gerald -- Gerald Pfeifer (Jerry) gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

4 13

Major Winelib Problems
by Sam Lauber Nov. 25, 2004

Nov. 25, 2004

I followed the tutorial for Winelib on my Linux system, building notepad. I examined the file "./notepad2" with readelf, and it said "Not an ELF file", and I do not have an a.out system. I opened it with my text editor (attached is the text I saw) and I was disappointed. Instead of a real "port", it was just a shell script that launches wine on a Windows program encapsulated in a ELF shared object file. I'm not happy. Samuel Lauber -- _____________________________________________________________ Web-based SMS services available at http://www.operamail.com. >From your mailbox to local or overseas cell phones. Powered by Outblaze

5 5