October 2022 - Wine-GitLab - list.winehq.org

[PATCH 0/3] MR1079: wininet/netprofm: Connectivity improvements.
by Gabriel Ivăncescu Oct. 22, 2022

Oct. 22, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1079

3 10

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Oct. 22, 2022

Oct. 22, 2022

On Tue Oct 18 12:28:34 2022 +0000, Rémi Bernon wrote: > Can `current_modref` really still be NULL now if > `LdrGetProcedureAddress` also sets it? Seems like it, although I haven't verified it rigorously. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11165

1 0

[PATCH v2 0/4] MR1090: Draft: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

_mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mbctolowe… More information about application crash: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v2: msvcrt: implement missing _mbsupr_s_l CRT function to fix ChessBase 14 crash msvcrt: implement missing _mbslwr_s_l CRT function to fix ChessBase 14 crash msvcrt: implement missing _mbctoupper_l CRT function to fix ChessBase 14 crash msvcrt: implement missing _mbctolower_l CRT function to fix ChessBase 14 crash https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

2 4

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Oct. 22, 2022

Oct. 22, 2022

On Tue Oct 18 12:28:32 2022 +0000, Rémi Bernon wrote: > I think you can simplify this a bit, by doing `if ((current_modref = > get_modref(...)))`, after saving its previous value, and restoring it > before leaving the CS. > Then I'm not sure what side effects this could have, and maybe it'd be > better to have this specific change separate from the rest? How about ```c RtlEnterCriticalSection( &loader_section ); prev = current_modref; wm = get_modref( module ); if (wm) current_modref = wm; if (!wm) ret = STATUS_DLL_NOT_FOUND; else { ... } current_modref = prev; RtlLeaveCriticalSection( &loader_section ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11162

1 0

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Oct. 22, 2022

Oct. 22, 2022

On Tue Oct 18 15:32:53 2022 +0000, Jinoh Kang wrote: > Also note that the forward[1-3] DLLs are exactly designed to test > transitively forwarded exports. Correction: The importer DLL references not only the final DLL but also every intermediate DLL in the forward chain. Intermediate DLLs do not gain any new dependencies, even if they are used in the resolution process of forwarded exports. Only the earliest import DLLs gain dependencies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11161

1 0

[PATCH 0/2] MR1090: Draft: msvcrt: implement missing _mbctolower_l CRT function to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

_mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mbctolowe… More information about application crash: https://bugs.winehq.org/show_bug.cgi?id=45273 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

4 5

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Oct. 22, 2022

Oct. 22, 2022

> Then what happens here if `find_ordinal_export` finds another transitive forwarded export? Should we still keep the same `current_modref`? Yes, we should. The importer DLL references the eventual DLL the target object resides in, not any of the intermediate DLL in the forward chain. > Should we add the second forwarded module to the first one dependencies instead? No, we should only add the last non-forwarding module to the importer DLL's dependencies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11157

1 0

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Oct. 22, 2022

Oct. 22, 2022

On Tue Oct 18 15:31:21 2022 +0000, Jinoh Kang wrote: > > Then what happens here if `find_ordinal_export` finds another > transitive forwarded export? Should we still keep the same `current_modref`? > Yes, we should. The importer DLL references the eventual DLL the target > object resides in, not any of the intermediate DLL in the forward chain. > > Should we add the second forwarded module to the first one > dependencies instead? > No, we should only add the last non-forwarding module to the importer > DLL's dependencies. Also note that the forward[1-3] DLLs are exactly designed to test transitively forwarded exports. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11158

1 0

[PATCH v7 0/1] MR1080: Draft: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

With this commit the following functions were implemented: - _mbsupr_s_l - converts multibyte string to uppercase, by using specified locale that's passed in. - _mbslwr_s_l - converts multibyte string to lowercase, by using specified locale that's passed in. - _mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. - _mbctoupper_l - converts multibyte lowercase character to uppercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/strupr-s-… After applying the patch the crash of the ChessBase application was fixed. More information: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v7: msvcrt: implement missing CRT functions to fix ChessBase 14 crash https://gitlab.winehq.org/wine/wine/-/merge_requests/1080

4 4

Re: [PATCH 0/2] MR7: Draft: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Oct. 22, 2022

Oct. 22, 2022

@rbernon Thanks for your review! Right now I'm tentatively putting this MR on hold until I find a solution for a memory leak: a new (redundant) dependency edge is added every time the application calls `GetProcAddress()` on a forwarded ref. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_11151

1 0