October 2022 - Wine-GitLab - list.winehq.org

Re: [PATCH v16 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) Oct. 22, 2022

Oct. 22, 2022

On Sat Oct 22 13:16:09 2022 +0000, Bartosz Kosiorek wrote: > changed this line in [version 16 of the diff](/wine/wine/-/merge_requests/1120/diffs?diff_id=15105&start_sha=01947548572fd5e442ee7677a63d2ff3c0f166e2#18ec41aa1588580e1f59f4c1c498c00b98b78b89_1012_1012) true, fixes. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1120#note_11802

1 0

[PATCH v3 0/1] MR1128: msvcrt: Display message box in abort() in debug CRT only.
by Paul Gofman (＠gofman) Oct. 22, 2022

Oct. 22, 2022

As far as my testing goes, the message box is never shown on Windows when abort() is called with retail runtime is used, regardless of error mode and abort behaviour. That is not the case with _assert which still can show a dialog even in release mode. It happens rather often that an app meets the error condition during the process exit and that goes silent on Windows while we display the abort dialog on app's exit. The test program below shows that (and the same behaviour is, e. g., with ucrtbase vs ucrtbased). ``` #include <windows.h> #include <stdio.h> #include <stdlib.h> void CDECL _set_app_type(int app_type); #define D(name) static typeof(name) *p_##name #define L(name) p_##name = (void *)GetProcAddress(hdll, #name); if (!p_##name) printf("NULL %s.\n", #name) D(abort); D(_set_app_type); D(_set_abort_behavior); D(_set_error_mode); int main(int argc, char *argv[]) { HMODULE hdll = LoadLibraryA("msvcrt.dll"); printf("hdll %p.\n", hdll); L(_set_app_type); if (!p__set_app_type) if (!(p__set_app_type = (void *)GetProcAddress(hdll, "__set_app_type"))) printf("NULL p__set_app_type.\n"); L(abort); L(_set_abort_behavior); L(_set_error_mode); p__set_app_type(2); if (p__set_abort_behavior) p__set_abort_behavior(_WRITE_ABORT_MSG, _WRITE_ABORT_MSG); p__set_error_mode(_OUT_TO_MSGBOX); p_abort(); } ``` -- v3: msvcrt: Display message box in abort() for specific CRT versions only. https://gitlab.winehq.org/wine/wine/-/merge_requests/1128

4 4

[PATCH 0/1] MR1144: msvcrt: Fix _wputenv_s invalid argument handling.
by Piotr Caban (＠piotr) Oct. 22, 2022

Oct. 22, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1144

3 2

Re: [PATCH v2 0/2] MR1135: msvcrt: _[w]putenv_s return value fix
by Piotr Caban (＠piotr) Oct. 22, 2022

Oct. 22, 2022

On Sat Oct 22 06:40:16 2022 +0000, Chip Davis wrote: > I hate to be the bearer of bad news, since this was already merged, but > it looks like you missed these two. It's fixed by !1144. Thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1135#note_11796

1 0

[PATCH v2 0/2] MR1119: Add FSCTL_GET_REPARSE_POINT semi-stub and tests
by Joel Holdsworth (＠jhol) Oct. 22, 2022

Oct. 22, 2022

* Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39627 * Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53439 -- v2: ntdll: Add FSCTL_GET_REPARSE_POINT semi-stub https://gitlab.winehq.org/wine/wine/-/merge_requests/1119

3 3

[PATCH 0/1] MR1143: include: Add prototype for ReOpenFile().
by Mihail Ivanchev (＠mivanchev) Oct. 22, 2022

Oct. 22, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53821 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1143

3 2

[PATCH v4 0/3] MR1070: Draft: Add more tests for \Device\NamedPipe, \Device\NamedPipe\, and exotic pipe names
by Jinoh Kang (＠iamahuman) Oct. 22, 2022

Oct. 22, 2022

-- v4: ntdll/tests: Add more tests for \Device\NamedPipe and \Device\NamedPipe\. ntdll/tests: Add tests for pipe names. kernel32/tests: Add test for pipe name with a trailing backslash. https://gitlab.winehq.org/wine/wine/-/merge_requests/1070

3 4

Re: [PATCH v2 0/2] MR1135: msvcrt: _[w]putenv_s return value fix
by Chip Davis (＠cdavis5e) Oct. 22, 2022

Oct. 22, 2022

Chip Davis (@cdavis5e) commented about dlls/msvcrt/environ.c: > /********************************************************************* > * _wputenv_s (MSVCRT.@) > */ > -int CDECL _wputenv_s(const wchar_t *name, const wchar_t *value) > +errno_t CDECL _wputenv_s(const wchar_t *name, const wchar_t *value) > { > - int ret; > + errno_t ret = 0; > > TRACE("%s %s\n", debugstr_w(name), debugstr_w(value)); > > if (!MSVCRT_CHECK_PMT(name != NULL)) return -1; > if (!MSVCRT_CHECK_PMT(value != NULL)) return -1; I hate to be the bearer of bad news, since this was already merged, but it looks like you missed these two. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1135#note_11787

1 0

[PATCH v4 0/2] MR1015: wpcap: Convert Unix sockaddr to win32 before duplication
by Marc-Aurel Zent (＠marzent) Oct. 22, 2022

Oct. 22, 2022

Interpreting the fist two bytes of the `sockaddr` struct as `sa_family` produces incorrect behaviour on macOS and (presumbly) BSD. This change uses both Unix and Windows socket headers to convert the libpcap provided sockaddr before duplicating it. This fixes sockaddr being always NULL on macOS/BSD and ipv6 addresses not working in general since `AF_INET6` differs on Windows(23), macOS(30) and Linux(10) For reference https://www.ibm.com/docs/en/i/7.3?topic=family-af-inet-address and this is from the <sys/socket.h> on macOS ``` /* * [XSI] Structure used by kernel to store most addresses. */ struct sockaddr { __uint8_t sa_len; /* total length */ sa_family_t sa_family; /* [XSI] address family */ char sa_data[14]; /* [XSI] addr value (actually larger) */ }; ``` -- v4: wpcap: Convert unix sockaddr to win32 sockaddr https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

3 3

[PATCH v3 0/3] MR1070: Add more tests for \Device\NamedPipe, \Device\NamedPipe\, and exotic pipe names
by Jinoh Kang (＠iamahuman) Oct. 21, 2022

Oct. 21, 2022

-- v3: ntdll/tests: Add more tests for \Device\NamedPipe and \Device\NamedPipe\. ntdll/tests: Add tests for pipe names. https://gitlab.winehq.org/wine/wine/-/merge_requests/1070

3 6