October 2022 - Wine-GitLab - list.winehq.org

[PATCH 0/14] MR38: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h.
by Francisco Casas (＠fcasas) Nov. 16, 2022

Nov. 16, 2022

I believe this information could be very useful for newcomers to the HLSL compiler. Documentation often needs to reference other parts of the code, so it can be a problem to update these references if the referenced code is modified. However, I think that documentation in the data definitions (as opposed to documentation inside the functions) is easier to maintain, since each data type is declared in a single place, to which one often keeps going back for reference, so it is less probable to forget to update a comment. Also, it opens up the possibility of explaining **what** things are, instead of **how they are used**, in some cases, avoiding these references to other places in the code. I can think on the following additional benefits: * Updates in these documentation comments, when the way a field is used changes, or when new fields are added, can help making future commits more readable. * Some IDEs display the comments above the field/struct declaration when the cursor is over an use of this field/struct. A hopefully not deceiving sketch: ![Hopefully not deceiving sketch.](/uploads/3f9e65a0dc091904e8267e23e58e37be/field_level_doc.png) -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/38

5 45

[PATCH 0/14] MR912: Draft: Import OpenLDAP client libraries and use them in wldap32
by Hans Leidekker (＠hans) Nov. 15, 2022

Nov. 15, 2022

The commits in libs/ don't build until the last one so they should be squashed. I kept them separate to show the changes I made to upstream source. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/912

2 15

[PATCH v16 0/1] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Nov. 15, 2022

Nov. 15, 2022

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v16: comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

4 4

[PATCH v4 0/8] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()
by Paul Gofman (＠gofman) Nov. 9, 2022

Nov. 9, 2022

Various notes: - LowestStartingAddress is still unsupported; - Patch 5 ("wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent") is fixing existing WOW issue: NtAllocateVirtualMemoryEx() called from wow64 currently does not constraing the allocation to 32 bit address space (wow64_NtAllocateVirtualMemory() passes zero_bits for that). - I initially thought of using a single inter process APC but added a different one due to zero_bits handling which is easier to convert in the target process. -- v4: ntdll: Support specified alignment in NtAllocateVirtualMemoryEx(). ntdll: Pass alignemnt mask to map_view(). wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent. wow64: Support MEM_ADDRESS_REQUIREMENTS in wow64_NtAllocateVirtualMemoryEx(). ntdll/tests: Add tests for memory address requiements. ntdll: Support HighestEndingAddress in NtAllocateVirtualMemoryEx(). ntdll: Factor out allocate_virtual_memory(). ntdll: Pass limit instead of zero_bits to map_view(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

5 18

[PATCH v3 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon Nov. 9, 2022

Nov. 9, 2022

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. >From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v3: ntdll: Remove unnecessary signal_start_thread register spilling. ntdll: Remove unnecessary arch specific exit frame pointer. ntdll: Avoid calling pthread_exit on thread exit. ntdll: Create a pthread for the main thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

3 14

[PATCH 0/5] MR1131: wined3d: Dirty rect fixes.
by Zebediah Figura (＠zfigura) Nov. 9, 2022

Nov. 9, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1131

4 7

[PATCH 0/2] MR1129: wined3d: Set the window state thread description only if it's actually a new thread.
by Zebediah Figura (＠zfigura) Nov. 9, 2022

Nov. 9, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1129

4 4

[PATCH 0/5] MR1048: winegstreamer: Allow wg_parser_stream_get_buffer to wait on all streams.
by Rémi Bernon Nov. 8, 2022

Nov. 8, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1048

4 25

[PATCH 0/2] MR1166: ntdll: don't claim to have not found a library that is in place
by Konstantin Kharlamov (＠Hi-Angel) Nov. 8, 2022

Nov. 8, 2022

When `import_dll` function gets `STATUS_DLL_NOT_FOUND` from `load_dll()`, it has no way of distinguishing whether it's a dependency for the dll wasn't found, or the dll itself is missing. That results in confusing ERR messages, where a dll is found, but wine claims it isn't. Fix this by moving the print to the actual place that is aware of whether it's the parent or the child dll haven't been found. Log before: 0024:err:module:import_dll Library lib2.dll (which is needed by L"Z:\\tmp\\lib1.dll") not found 0024:err:module:import_dll Library lib1.dll (which is needed by L"Z:\\tmp\\a.exe") not found Log after: 0024:err:module:load_dll Library L"lib2.dll" (which is needed by L"Z:\\tmp\\foo\\lib1.dll") not found 0024:err:module:import_dll Loading library lib2.dll (which is needed by L"Z:\\tmp\\foo\\lib1.dll") failed (error c0000135). 0024:err:module:import_dll Loading library lib1.dll (which is needed by L"Z:\\tmp\\foo\\a.exe") failed (error c0000135). -------- While it's just about prints, but it costed me hours of wandering *(because if I know where to find the dependency dll, but I see that the main dll is also "not found" despite being "right there", I have to research the latter problem that looks more complicated. But given enough resources applied, it then turns out to be a faux)*. As a fun fact, I am apparently not the only one to have stumbled upon. Here's a screenshot of a `#english` chat where I asked about a commit title correctness. It's the last place where you'd expect to find someone familiar with WINE, and yet here's a person that had to deal with that exact error as well: ![Screenshot_20221026_023411](/uploads/55552d7c335ef5ce0b507f61adacbb00/Screenshot_20221026_023411.png) So, I think it's kinda serious problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1166

4 13

[PATCH 0/6] MR1158: winegstreamer: Add a skeleton MPEG layer-3 decoder filter.
by Anton Baskanov (＠baskanov) Nov. 7, 2022

Nov. 7, 2022

Development branch: https://gitlab.winehq.org/baskanov/wine/-/commits/l3codecx/ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=18773 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1158

4 8