October 2022 - Wine-GitLab - list.winehq.org

[PATCH 0/6] MR1111: winsock: Always use Unix SO_REUSEADDR on TCP sockets.
by Paul Gofman (＠gofman) Nov. 2, 2022

Nov. 2, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50955 The problem which this patchset aims to solve is (sometimes) huge timeout on TCP listening port availability on Linux after the listening socket was closed one or another way. By default, the listening port will also be blocked for the whole time accepted socket waits through lengthy timeouts (sometimes; most surely when the listening process with an active connection was force killed, but not limited to this condition). BSD SO_REUSEADDR socket option is aimed mainly to avoid that extra wait on binding already closed listening socket address. From [1]: "Indicates that the rules used in validating addresses supplied in a bind(2) call should allow reuse of local addresses. For AF_INET sockets this means that a socket may bind, except when there is an active listening socket bound to the address.". Unix SO_REUSEADDR does not really allow reusing address in the Winsock sense. It will just allow to ditch the timeout (which is always the case on Windows without any specific options). Unfortunately it is not the only effect of the option. It still won't allow listening on the address simultaneously (unlike Winsock SO_REUSEADDR which allows simultaneous listening), or binding to an address which is being listened. But it will allow to bind different sockets for the same address which is not the Winsock behaviour when Winsock SO_REUSEADDR is set. So the patchset enables SO_REUSEADDR on every TCP socket and introduces the bound address tracking which will allow to return an error from bind() when needed. Not related to this patchset, but Winsock SO_REUSEADDR is somewhat closer to BSD SO_REUSEPORT, although is different in a way that _REUSEPORT will load balance connections between listeners while with Winsock _REUSEADDR the connections will always go to the first listener. I hope that the bound addresses tracking introduced in these patches may be reused in the future. E. g., maybe it might be helpful on the way of implementing the todos introduced by my extended tests (those todos are not related to this patchset and exist both with and without it). 1. https://man7.org/linux/man-pages/man7/socket.7.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1111

6 28

[PATCH 0/1] MR1179: loader: Unbreak FreeBSD builds (ARRAY_SIZE undefined)
by Gerald Pfeifer (＠gerald) Nov. 2, 2022

Nov. 2, 2022

Commit af996344a815baa1278d32181ddfda5e889a16d9 used ARRAY_SIZE in FreeBSD-specifc code which, alas, is not available here, so revert that change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1179

4 5

[PATCH v2 0/2] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) Nov. 2, 2022

Nov. 2, 2022

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v3: Fix failed test. Don't know how to change the subject version number. -- v2: shell32: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 7

[PATCH v3 0/7] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) Nov. 2, 2022

Nov. 2, 2022

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. I don't know what to call this kind of callback, I just called it "user32 callback" for now because it's going through user32 but that's not really a good name. It also sadly necessitates a private \_\_wine export from user32, unless someone has a better idea for how to register the callbacks with user32. -- v3: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Convert kernel callbacks to user32 callbacks. winemac.drv: Convert kernel callbacks to user32 callbacks. wineandroid.drv: Convert kernel callbacks to user32 callbacks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 9

[PATCH v2 0/3] MR1178: kernelbase: Forward some directory info classes in GetFileInformationByHandleEx().
by Nikolay Sivov (＠nsivov) Oct. 28, 2022

Oct. 28, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53590 -- v2: kernelbase: Forward some more classes in GetFileInformationByHandleEx(). kernelbase: Make sure to provide a message for missing information classes in GetFileInformationByHandleEx(). kernelbase: Forward some directory info classes in GetFileInformationByHandleEx(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1178

2 3

[PATCH 0/7] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) Oct. 27, 2022

Oct. 27, 2022

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. I don't know what to call this kind of callback, I just called it "user32 callback" for now because it's going through user32 but that's not really a good name. It also sadly necessitates a private \_\_wine export from user32, unless someone has a better idea for how to register the callbacks with user32. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

3 8

[PATCH v2 0/7] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) Oct. 27, 2022

Oct. 27, 2022

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. I don't know what to call this kind of callback, I just called it "user32 callback" for now because it's going through user32 but that's not really a good name. It also sadly necessitates a private \_\_wine export from user32, unless someone has a better idea for how to register the callbacks with user32. -- v2: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Convert kernel callbacks to user32 callbacks. winemac.drv: Convert kernel callbacks to user32 callbacks. wineandroid.drv: Convert kernel callbacks to user32 callbacks. winevulkan: Convert kernel callbacks to user32 callbacks. user.exe16: Convert kernel callbacks to user32 callbacks. user32: Add user32 callback infrastructure. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

2 7

[PATCH v4 0/9] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) Oct. 27, 2022

Oct. 27, 2022

-- v4: msvcrt: Add _mbctokata_l implementation. msvcrt: Add _mbctohira_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

2 9

Re: [PATCH v8 0/2] MR1015: wpcap: Build devices in unixlib for find_all_devices - closed
by Marc-Aurel Zent (＠marzent) Oct. 27, 2022

Oct. 27, 2022

This merge request was closed by Marc-Aurel Zent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

1 0

Re: [PATCH v8 0/2] MR1015: wpcap: Build devices in unixlib for find_all_devices
by Marc-Aurel Zent (＠marzent) Oct. 27, 2022

Oct. 27, 2022

Yeah the commit above worked perfectly, didn't know even know you can do it like that on the PE side. Much nicer than the double calling and conversion of the Unix struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015#note_12353

1 0