October 2022 - Wine-GitLab - list.winehq.org

[PATCH v2 0/5] MR937: winegstreamer: Small refactor of wg_format video formats and major types.
by Rémi Bernon Oct. 11, 2022

Oct. 11, 2022

I'm going to need to add a few more compressed formats, WMV which is straightforward, but also AAC (so MPEG v2/v4 audio), and I think wg_format could be cleaned up a bit like this beforehand. Then, AAC could either be added as a separate `AUDIO_MPEG4` format, or, with an version field, to the (renamed) `AUDIO_MPEG` format, though it doesn't share any of the current `AUDIO_MPEG1` properties. FWIW GStreamer caps is `audio/mpeg` for both, with an `mpegversion` that can be 1, 2 or 4. Could be very well added as `AUDIO_AAC` too, I don't really mind. -- v2: winegstreamer: Reorder video format struct in wg_format. winegstreamer: Rename WG_MAJOR_TYPE_H264 to WG_MAJOR_TYPE_VIDEO_H264. winegstreamer: Rename WG_MAJOR_TYPE_WMA to WG_MAJOR_TYPE_AUDIO_WMA. winegstreamer: Rename WG_MAJOR_TYPE_MPEG1_AUDIO to WG_MAJOR_TYPE_AUDIO_MPEG1. winegstreamer: Move CINEPAK encoded format to a separate major type. https://gitlab.winehq.org/wine/wine/-/merge_requests/937

3 11

[PATCH 0/1] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) Oct. 11, 2022

Oct. 11, 2022

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. This introduces a regression that makes it possible to use \Device\NamedPipe (note the lack of trailing backslash) as RootDirectory as well, since Wine does not distinguish between \Device\NamedPipe (the device itself) and \Device\NamedPipe\ (the root directory of the filesystem). (Previous iteration of this patch did distinguish between the two, but the method in which it was implemented was deemed hacky.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/498

5 11

Re: [PATCH v3 0/2] MR897: oleaut32: dereference VT_RECORD|VT_BYREF in place.
by Kevin Puetz (＠puetzk) Oct. 11, 2022

Oct. 11, 2022

Revereted in 02ce1008b7876d9f86dfc5844c4be17307b8e055 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_10350

1 0

[PATCH v2 0/2] MR920: kernel32: Map system heap anywhere if the standard address is unavailable.
by Brendan Shanks (＠bshanks) Oct. 11, 2022

Oct. 11, 2022

`mscomctl.ocx` (part of the VB6 common controls) calls `HeapCreate(0x04000000,1,0)`, that flag is the old and undocumented `HEAP_SHARED`. `HEAP_CreateSystemHeap()` tries to map memory at `0x80000000`, this fails on Wow64 (and probably should for all 32-bit platforms for non-LAA EXEs). As a workaround, map the memory anywhere if it fails at `0x80000000`. I wasn't able to find much documentation about `HEAP_SHARED`, it dates back to Win9x and I guess Wine may have needed it for some native DLLs. It's not clear whether modern Windows really implements any shared heap functionality any more, every 'shared' heap created returns a different pointer (even in the same process). Maybe Wine should remove the functionality too? -- v2: kernel32: Remove shared heap functionality. ntdll: Remove shared heap functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/920

3 3

Re: [PATCH v5 0/1] MR1006: gdi32: Fix possible overflow - approved
by Alexandre Julliard (＠julliard) Oct. 11, 2022

Oct. 11, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1006

1 0

Re: [PATCH v2 0/1] MR994: gdi32/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) Oct. 11, 2022

Oct. 11, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/994

1 0

Re: [PATCH v4 0/2] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer. - approved
by Alexandre Julliard (＠julliard) Oct. 11, 2022

Oct. 11, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/957

1 0

Re: [PATCH v26 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub - approved
by Alexandre Julliard (＠julliard) Oct. 11, 2022

Oct. 11, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778

1 0

Re: [PATCH v2 0/1] MR1029: include: Add missing SP defines - approved
by Alexandre Julliard (＠julliard) Oct. 11, 2022

Oct. 11, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1029

1 0

Re: [PATCH v3 0/2] MR1026: shell32: Handle drive letters properly when parsing MyComputer. - approved
by Alexandre Julliard (＠julliard) Oct. 11, 2022

Oct. 11, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1026

1 0