October 2022 - Wine-GitLab - list.winehq.org

[PATCH v3 0/2] MR957: rpcrt4: MIDL_STUB_MESSAGE needs to keep a refcount on IRpcChannelBuffer.
by Kevin Puetz (＠puetzk) Oct. 11, 2022

Oct. 11, 2022

It's possible for a proxy to be released during the middle of an Invoke. A specific scenario where this happened was a single-shot event sink which, upon receiving the event it was waiting for, would immediately call DispEventUnadvise. This removed the proxy pointing to that sink from the connection point's list of subscribers and released it. For such cases all state used to complete the Invoke must be owned by the __proxy_frame kept on the stack; after calling NdrProxySendReceive (which pumps STA messages and permits reentrancy), anything inside *This could be use-after-free. MIDL_STUB_MESSAGE already had its own IRPCChannelBuffer *pRpcChannelBuffer, but lacked its own refcount. When this does crash, the exception is caught by RpcTryFinally, but still leads to leaks since NdrProxyFreeBuffer wasn't able to call IRPCChannelBuffer::FreeBuffer. To fix this, StdProxy_GetChannel() now calls AddRef() when setting __proxy_frame::_StubMsg::pRpcChannelBuffer and NdrProxyFreeBuffer() calls the corresponding Release(). -- v3: rpcrt4: Add a refcount owned by MIDL_STUB_MESSAGE. rpcrt4/tests: Add tests for lifetime of IRpcChannelBuffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/957

4 5

[PATCH 0/1] MR1006: gdi32: Fix possible overflow
by Mark Jansen (＠learn-more) Oct. 11, 2022

Oct. 11, 2022

According to the documentation of ScriptShape function, the psva argument should have the number of elements indicated by cMaxGlyphs. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1006

4 5

[PATCH 0/2] MR1030: Add stubs and tests for GetConsoleOriginalTitleA/W
by Hugh McMaster (＠hmc) Oct. 11, 2022

Oct. 11, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1030

3 3

[PATCH 0/1] MR1029: include: Add missing SP defines
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 11, 2022

Oct. 11, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49775 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1029

3 2

[PATCH v2 0/1] MR1011: user32: Correctly detect and assign an int resource
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 11, 2022

Oct. 11, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53646 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v2: user32: Correctly detect and assign an int resource https://gitlab.winehq.org/wine/wine/-/merge_requests/1011

3 3

[PATCH v25 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) Oct. 11, 2022

Oct. 11, 2022

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- v25: ntoskrnl.exe: KeInsertQueueDpc stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/778

3 2

[PATCH v22 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) Oct. 11, 2022

Oct. 11, 2022

this gets the YSDrv service to start successfully (with the MmAllocateContiguousMemorySpecifyCache semi-stub) this service is used by the nox android emulator -- v22: ntoskrnl: KeInsertQueueDpc stub https://gitlab.winehq.org/wine/wine/-/merge_requests/778

3 2

[PATCH 0/1] MR1028: nsi: Use the correct members for the error and discard counts.
by Huw Davies (＠huw) Oct. 11, 2022

Oct. 11, 2022

This is instead of !984. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1028

3 2

[PATCH v2 0/2] MR1026: shell32: Handle drive letters properly when parsing MyComputer.
by Gabriel Ivăncescu Oct. 11, 2022

Oct. 11, 2022

-- v2: shell32: Handle drive letters properly when parsing MyComputer. shell32/tests: Test drive letters parsing for My Computer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1026

2 3

[PATCH v3 0/6] MR1025: ntdll: Support memory address requirements in NtAllocateVirtualMemoryEx()
by Paul Gofman (＠gofman) Oct. 11, 2022

Oct. 11, 2022

Various notes: - LowestStartingAddress is still unsupported; - Patch 5 ("wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent") is fixing existing WOW issue: NtAllocateVirtualMemoryEx() called from wow64 currently does not constraing the allocation to 32 bit address space (wow64_NtAllocateVirtualMemory() passes zero_bits for that). - I initially thought of using a single inter process APC but added a different one due to zero_bits handling which is easier to convert in the target process. -- v3: ntdll: Support specified alignment in NtAllocateVirtualMemoryEx(). wow64: Set HighestEndingAddress in wow64_NtAllocateVirtualMemoryEx() if it is absent. wow64: Support MEM_ADDRESS_REQUIREMENTS in wow64_NtAllocateVirtualMemoryEx(). ntdll/tests: Add tests for memory address requiements. https://gitlab.winehq.org/wine/wine/-/merge_requests/1025

3 11