November 2022 - Wine-GitLab

[PATCH v5 0/10] MR1537: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) Nov. 25, 2022

Nov. 25, 2022

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default properties but this does not appear to be the case. I guess there's no reason to keep the checks for each member of the computed color struct? Perhaps keep the checks for E_INVALIDARG and S_OK? I haven't come across an application that uses the functions so I didn't implement them. For the rest of the properties, the if (0) test was added just to show that it crashes with a NULL value. Also, if the wrong type is passed, the function does not crash on Windows and the value remains unchanged, but it returns S_OK. -- v5: windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontEffect. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontStyle. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontSize. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontColor. windows.media/tests: Add Closed Caption Properties tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1537

5 18

[PATCH 0/2] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) Nov. 25, 2022

Nov. 25, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 5

[PATCH v2 0/11] MR1526: mshtml: Misc improvements.
by Gabriel Ivăncescu Nov. 25, 2022

Nov. 25, 2022

For the `performance.navigation` props, I store them in the timing that's already linked from the window, to prevent adding more code around that just for 2 props, so it keeps it simple. -- v2: include/mshtml: Add IHTMLXDomainRequest and factory interfaces and classes. mshtml: Don't check for doc_node from the doc obj when it can't be NULL. mshtml: Return proper error for invalid selectors in IE8 mode. mshtml: Treat edit mode as a reload. mshtml: Implement performance.navigation.type. mshtml: Implement performance.navigation.redirectCount. mshtml: Set `reload` load type to Gecko for document reloads. mshtml: Implement `onload` prop for input elements. mshtml: Send load event synchronously for image elements if set to same src. mshtml: Implement location.reload(). mshtml: Implement print events. https://gitlab.winehq.org/wine/wine/-/merge_requests/1526

3 18

[PATCH v2 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon Nov. 25, 2022

Nov. 25, 2022

-- v2: winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. mshtml: Free wine_get_dos_file_name memory with HeapFree. appwiz.cpl: Free wine_get_dos_file_name memory with HeapFree. https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

3 7

[PATCH v3 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon Nov. 25, 2022

Nov. 25, 2022

-- v3: winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. mshtml: Free wine_get_dos_file_name memory with HeapFree. appwiz.cpl: Free wine_get_dos_file_name memory with HeapFree. https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

2 4

[PATCH 0/3] MR1550: misc: Fix some invalid frees of wine_get_dos_file_name.
by Rémi Bernon Nov. 25, 2022

Nov. 25, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1550

1 3

[PATCH 0/6] MR1548: ntdll: Relax heap locking to access block information.
by Rémi Bernon Nov. 25, 2022

Nov. 25, 2022

We are currently locking the heap to iterate over the allocated regions, in order to check whether a pointer / block really belongs to one of them. This is not what native does it, as HeapFree / HeapReAlloc / HeapSize crashing on invalid pointers shows. This also makes it hard to improve the heap performance in multi-threaded scenarios. This series reduces the locking requirement by keeping the region header offset in each block, relaxing the pointer checks, and assuming a heap region stays valid until all of its blocks have been freed. This also removes the locking requirement when accessing block level information, such as block type or flags or block user info. I'm assuming here that concurrent calls to heap functions on a given block are undefined. Anything that involves modifying the block size, type or flags, walking the heap, or explicit validation still requires entering the heap lock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1548

1 6

[PATCH v2 0/1] MR1519: mshtml: Handle memory allocation failure in ConnectionPoint_Advise.
by Alex Henrie (＠alexhenrie) Nov. 25, 2022

Nov. 25, 2022

-- v2: mshtml: Handle memory allocation failure in ConnectionPoint_Advise. https://gitlab.winehq.org/wine/wine/-/merge_requests/1519

3 2

[PATCH 0/1] MR1544: wininet: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) Nov. 25, 2022

Nov. 25, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1544

3 2

[PATCH v4 0/5] MR1445: kernelbase: Fixes for the shared Software\Classes registry and Wow6432Node registry in general.
by Sven Baars (＠sbaars) Nov. 25, 2022

Nov. 25, 2022

This reimplements all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v4: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. kernelbase: Factor out the common parts of open_key() and create_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

3 7