November 2022 - Wine-GitLab

[PATCH v4 0/10] MR1537: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) Nov. 25, 2022

Nov. 25, 2022

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default properties but this does not appear to be the case. I guess there's no reason to keep the checks for each member of the computed color struct? Perhaps keep the checks for E_INVALIDARG and S_OK? I haven't come across an application that uses the functions so I didn't implement them. For the rest of the properties, the if (0) test was added just to show that it crashes with a NULL value. Also, if the wrong type is passed, the function does not crash on Windows and the value remains unchanged, but it returns S_OK. -- v4: windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontEffect. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontStyle. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontSize. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontColor. windows.media/tests: Add Closed Caption Properties tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1537

3 14

[PATCH 0/1] MR1546: programs/cmd: use OEM code page when reading a file
by eric pouech (＠epo) Nov. 25, 2022

Nov. 25, 2022

Calling GetConsoleCP() when ReadConsoleW() fails (potentially indicating that cmd.exe's instance isn't attached to a console) makes no sense. In details, since GetConsoleCP() returns 0 when not attached to a console to indicate error, we're in fact using CP_ACP. So fallback explicitely to OEM CP (which is the default for CUI programs). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1546

2 1

[PATCH v5 0/6] MR1301: Add ir50_32 video codec for winmm.
by Shaun Ren (＠shaunren) Nov. 25, 2022

Nov. 25, 2022

This video codec is used by games such as Richman 4, and Zwei: The Arges Adventure. The decoder logic is based on code from the FFmpeg project. -- v5: loader/wine.inf: Enable ir50_32 video codec. ir50_32: Implement decompression to 24-bit and 15-bit RGB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1301

5 11

[PATCH v3 0/10] MR1537: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) Nov. 25, 2022

Nov. 25, 2022

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default properties but this does not appear to be the case. I guess there's no reason to keep the checks for each member of the computed color struct? Perhaps keep the checks for E_INVALIDARG and S_OK? I haven't come across an application that uses the functions so I didn't implement them. For the rest of the properties, the if (0) test was added just to show that it crashes with a NULL value. Also, if the wrong type is passed, the function does not crash on Windows and the value remains unchanged, but it returns S_OK. -- v3: windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontEffect. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontStyle. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontSize. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontColor. windows.media/tests: Add Closed Caption Properties tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1537

3 12

[PATCH v2 0/10] MR1537: Draft: windows.media: Partially implement caption properties.
by Mohamad Al-Jaf (＠maljaf) Nov. 24, 2022

Nov. 24, 2022

As Wine currently does not have a way to set captions, returning the default value should suffice for most applications. It looks like Windows does not do error checking for the *value parameter. For the computed properties, they return E_INVALIDARG when all the captions are set as Default. But they return S_OK if any of the caption settings have been modified, regardless of whether a valid *value parameter is passed. I expected it to at least return the computed values for the default properties but this does not appear to be the case. I guess there's no reason to keep the checks for each member of the computed color struct? Perhaps keep the checks for E_INVALIDARG and S_OK? I haven't come across an application that uses the functions so I didn't implement them. For the rest of the properties, the if (0) test was added just to show that it crashes with a NULL value. Also, if the wrong type is passed, the function does not crash on Windows and the value remains unchanged, but it returns S_OK. -- v2: windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_RegionColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_BackgroundColor. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontEffect. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontStyle. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontSize. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontOpacity. windows.media: Partially implement IClosedCaptionPropertiesStatics_get_FontColor. windows.media/tests: Add Closed Caption Properties tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1537

2 12

[PATCH v4 0/1] MR1503: wineusb.sys: Move event handling to a single thread.
by Ivo Ivanov (＠logos128) Nov. 24, 2022

Nov. 24, 2022

Also fixes a segmentation fault when exiting winedevice.exe. I can file a separate bug report, but it seems related to Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 On my system the core dump can be provoked when using the bus_udev backend in winebus.sys ("Enable SDL" 0). It creates two hid devices - a mouse and a keyboard. Since it resides in the same winedevice.exe process as wineusb.sys, something similar to the above bug occurs when handling the SIGQUIT signal. The actual crash happens in the libusb event thread while waiting in pthread_cond_wait(). I'm using this for months without any issues (with a device driver which uses wineusb.sys for device access, etc.). -- v4: wineusb.sys: Move event handling to a single thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/1503

2 1

[PATCH 0/5] MR1540: localspl: Enable tests on modern Windows.
by Piotr Caban (＠piotr) Nov. 24, 2022

Nov. 24, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1540

3 6

Re: [PATCH v2 0/8] MR1489: DirectMusic: Don't force a calling convention on internal functions. - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2022

Nov. 24, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1489

1 0

Re: [PATCH v3 0/2] MR1528: winhttp: Improve WinHttpGetProxyForUrl() execution time when wpad is not available - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2022

Nov. 24, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1528

1 0

Re: [PATCH v3 0/7] MR1422: winhttp: Do not reference request from websocket. - approved
by Alexandre Julliard (＠julliard) Nov. 24, 2022

Nov. 24, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1422

1 0