November 2022 - Wine-GitLab

Re: [PATCH v2 0/1] MR1392: ntdll: Add native thread renaming for macOS. - approved
by Alexandre Julliard (＠julliard) Nov. 18, 2022

Nov. 18, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1392

1 0

Re: [PATCH v6 0/7] MR966: server: Some fixes for the shared Software\Classes registry. - approved
by Alexandre Julliard (＠julliard) Nov. 18, 2022

Nov. 18, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/966

1 0

Re: [PATCH v2 0/1] MR1424: quartz: Use a single message thread for all filter graphs. - approved
by Alexandre Julliard (＠julliard) Nov. 18, 2022

Nov. 18, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1424

1 0

Re: [PATCH v2 0/1] MR1432: configure: Override PKG_CONFIG_LIBDIR instead of PKG_CONFIG_PATH for 32-bit builds on 64-bit hosts. - approved
by Alexandre Julliard (＠julliard) Nov. 18, 2022

Nov. 18, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1432

1 0

Re: [PATCH v4 0/4] MR48: vkd3d-shader/hlsl: More miscelaneous fixes. - approved
by Alexandre Julliard (＠julliard) Nov. 18, 2022

Nov. 18, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/48

1 0

Re: [PATCH v10 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) Nov. 18, 2022

Nov. 18, 2022

On Fri Nov 18 20:57:32 2022 +0000, Esme Povirk wrote: > Is the duplication here OK? Seems like we'd need to recurse if the path > can contain curves or multiple segments. I suspect that in the long run we'll need to call GdipWidenPath here with a new GpPen. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16413

1 0

Re: [PATCH v10 0/9] MR1297: gdiplus: Add CustomLineCap implementation (including displaying).
by Esme Povirk (＠madewokherd) Nov. 18, 2022

Nov. 18, 2022

Esme Povirk (@madewokherd) commented about dlls/gdiplus/graphicspath.c: > + { > + tmp_points = heap_alloc_zero(custom->pathdata.Count * sizeof(GpPoint)); > + if (!tmp_points) { > + ERR("Out of memory\n"); > + return; > + } > + > + for (INT i = 0; i < custom->pathdata.Count; i++) > + { > + tmp_points[i].X = posx + custom->pathdata.Points[i].X * cosa + (custom->pathdata.Points[i].Y - 1.0) * sina; > + tmp_points[i].Y = posy + custom->pathdata.Points[i].X * sina - (custom->pathdata.Points[i].Y - 1.0) * cosa; > + } > + if ((custom->pathdata.Types[custom->pathdata.Count - 1] & PathPointTypeCloseSubpath) == PathPointTypeCloseSubpath) > + widen_closed_figure(tmp_points, 0, custom->pathdata.Count - 1, pen, pen_width, last_point); > + else > + widen_open_figure(tmp_points, 0, custom->pathdata.Count - 1, pen, pen_width, LineCapFlat, LineCapFlat, last_point); Is the duplication here OK? Seems like we'd need to recurse if the path can contain curves or multiple segments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1297#note_16412

1 0

[PATCH v5 0/9] MR1373: mshtml: Page-wide events implementation.
by Gabriel Ivăncescu Nov. 18, 2022

Nov. 18, 2022

This implements some events related to document/window load and unload / visibility changes. The latter is related in that native partially implements it, and only sends it when it is minimized or restored from being minimized, not on navigation or anything else. The main issue for me is the visibilitychange patch. Since we don't control the container hwnd, and it can even be in another process, there is no way to be notified cleanly when it changes its minimization state. We can't subclass it either, as the tests show, it's not subclassed. I implemented it now using an internal timer that polls for that, since it was the least invasive and works in all cases, including other process hwnd. Hooks wouldn't be able to do that, and are also more invasive IMO. I'm hoping for better ideas, though. -- v5: mshtml: Implement pagehide event. mshtml: Implement unload event. mshtml: Dispatch beforeunload event to the window. mshtml: Implement pageshow event. mshtml: Store the nsevent listener descs in a table. mshtml: Add visibilitychange event stub. mshtml: Dispatch Gecko events to the window if there's no node. mshtml: Do not register Gecko load event handler twice. mshtml: Allow EVENT_BIND_TO_TARGET to bind to the window. https://gitlab.winehq.org/wine/wine/-/merge_requests/1373

2 10

Re: [PATCH v2 0/1] MR1443: include: enum insted of macros for options flag in pathcch
by Nikolay Sivov (＠nsivov) Nov. 18, 2022

Nov. 18, 2022

This one depends on !1421, will have to rebased once !1421 is merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1443#note_16405

1 0

Re: [PATCH v3 0/1] MR1421: include: add c++ header guards in pathcch - approved
by Nikolay Sivov (＠nsivov) Nov. 18, 2022

Nov. 18, 2022

This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1421

1 0