September 2022 - Wine-GitLab

[PATCH v2 0/5] MR856: mshtml: url prop for Storage Events and improvements.
by Gabriel Ivăncescu Sept. 18, 2022

Sept. 18, 2022

-- v2: mshtml: Silence a FIXME when parameter is missing. mshtml: Create non-gecko events properly from type string. mshtml: Implement url prop for StorageEvent. include/mshtml: Move some forward interface declarations to match Windows SDK. mshtml: Override document.URL's name when adding it from the mshtml typelib. https://gitlab.winehq.org/wine/wine/-/merge_requests/856

2 8

[PATCH 0/3] MR883: kernelbase: Add OpenFileMappingFromApp().
by Nikolay Sivov (＠nsivov) Sept. 18, 2022

Sept. 18, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/883

2 3

Re: [PATCH v5 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Jinoh Kang (＠iamahuman) Sept. 18, 2022

Sept. 18, 2022

> You should only call `NtGetCurrentProcessorNumber()` once. Otherwise, the processor number can change if the thread is preempted and then re-scheduled to another processor. This leads to inconsistent values between the return value and the `process_number->Number` output. It's not that `KeGetCurrentProcessorNumberEx()` will be highly useful, since the driver can't block scheduling by raising IRQL to DISPATCH_LEVEL. Still, it's better to at least return consistent values even if they are stale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824#note_8782

1 0

Re: [PATCH v5 0/1] MR824: ntoskrnl: Implement KeGetCurrentProcessorNumberEx
by Jinoh Kang (＠iamahuman) Sept. 18, 2022

Sept. 18, 2022

Jinoh Kang (@iamahuman) commented about dlls/ntoskrnl.exe/ntoskrnl.c: > > +/*********************************************************************** > + * KeGetCurrentProcessorNumberEx (NTOSKRNL.EXE.@) > + */ > +ULONG WINAPI KeGetCurrentProcessorNumberEx(PPROCESSOR_NUMBER process_number) > +{ > + FIXME("%p semi-stub\n", process_number); > + > + if (process_number) > + { > + process_number->Group = 0; > + process_number->Reserved = 0; > + process_number->Number = NtGetCurrentProcessorNumber(); > + } > + > + return NtGetCurrentProcessorNumber(); You should only call `NtGetCurrentProcessorNumber()` once. Otherwise, the processor number can change if the thread is preempted and then re-scheduled to another processor. This leads to inconsistent values between the return value and the `process_number->Number` output. In general, you should treat `NtGetCurrentProcessorNumber()` as being volatile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/824#note_8781

1 0

[PATCH 0/1] MR882: concrt140: Use atomic write for releasing threadsafe_queue spin lock.
by Jinoh Kang (＠iamahuman) Sept. 18, 2022

Sept. 18, 2022

This fixes data race in ARM/ARM64 platforms, and prevents potential memory access reordering by the compiler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/882

2 1

[PATCH 0/1] MR881: kernelbase: Fix reading stale information from IOSB.
by Jinoh Kang (＠iamahuman) Sept. 18, 2022

Sept. 18, 2022

Ensure IOSB Information (InternalHigh) is loaded after Status (Internal) to avoid reading stale value from the Information (InternalHigh) field. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/881

2 1

[PATCH v5 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) Sept. 18, 2022

Sept. 18, 2022

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v5: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH v4 0/1] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) Sept. 18, 2022

Sept. 18, 2022

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v4: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

2 1

[PATCH 0/1] MR878: wininet: Use standard HTTP_ADD Flags
by Alistair Leslie-Hughes (＠alesliehughes) Sept. 18, 2022

Sept. 18, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/878

3 2

[PATCH 0/1] MR876: jscript: Fix GCC 12.2 warning.
by eric pouech (＠epo) Sept. 18, 2022

Sept. 18, 2022

When initializing a jsstr_inline_t with a len < 3, the size passed for the allocation is smaller then the size of the structure (as the later is rounded up to the alignment = 4 bytes). GCC 12.2 complains about this when dereferencing the pointer to the structure as the size passed for allocation is smaller than the size of the structure. The warning is fixed by using flexible array member in jsstr_inline_t. Given the rounding behavior in memory allocation, this should not change the size of allocated blocks. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/876

3 2