September 2022 - Wine-GitLab

Re: [PATCH v2 0/2] MR868: ntdll, libwine: Avoid comparing the result of pointer arithmetic to zero. - approved
by Alexandre Julliard (＠julliard) Sept. 16, 2022

Sept. 16, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/868

1 0

Re: [PATCH v7 0/4] MR852: ntdll: Speed up NtQueryVirtualMemory(MemoryWorkingSetExInformation) by conditional pread.
by Witold Baryluk (＠baryluk) Sept. 16, 2022

Sept. 16, 2022

@zfigura @iamahuman This is my first wine patch, I am not familiar with wine review process, and I am not sure who should review this (bot didn't assign anybody), but I would appreciate a review. Code should be obvious, but question for the last commit: should I open with `O_CLOEXEC` ? I do not think so, but would be good to confirm. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/852#note_8713

1 0

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) Sept. 16, 2022

Sept. 16, 2022

On Fri Sep 16 15:29:32 2022 +0000, Gabriel Ivăncescu wrote: > It worked properly earlier likely because there were no conflicts. Use > git locally as normal instead of the web interface to do it. yes I know that, but when I clicked the rebase button the pipeline started failing for no reason, now I have to rebase locally which I understand -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8706

1 0

[PATCH 0/3] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) Sept. 16, 2022

Sept. 16, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/871

4 5

[PATCH v2 0/5] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) Sept. 16, 2022

Sept. 16, 2022

-- v2: ntdll: Fill the IOSB in sock_transmit() only inside the "if (alerted)" block. ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block. ntdll: Fill the IOSB in sock_recv() only inside the "if (alerted)" block. ntdll: The async handle passed to set_async_direct_result() cannot be NULL. ws2_32/tests: Add more tests for iosb contents while a recv is pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/871

2 5

[PATCH v2 0/1] MR867: ntdll: Check for failure from get_initial_environment().
by Zebediah Figura (＠zfigura) Sept. 16, 2022

Sept. 16, 2022

Alternatively, since this is early in startup and we don't expect this malloc() to fail, we could simply remove the check from get_initial_environment() itself. -- v2: ntdll: Do not check for malloc() failure in get_initial_environment. https://gitlab.winehq.org/wine/wine/-/merge_requests/867

2 1

[PATCH v2 0/4] MR843: wmvcore: More wm async reader refactoring.
by Rémi Bernon Sept. 16, 2022

Sept. 16, 2022

-- v2: winegstreamer: Check for already opened stream in wm_reader_open*. winegstreamer: Use a dedicated CS to serialize async reader commands. winegstreamer: Introduce a new async_reader_deliver_sample helper. winegstreamer: Wake thread when async reader user clock is modified. https://gitlab.winehq.org/wine/wine/-/merge_requests/843

2 7

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Gabriel Ivăncescu Sept. 16, 2022

Sept. 16, 2022

On Fri Sep 16 15:03:29 2022 +0000, Etaash Mathamsetty wrote: > lol now another issue popped up, the rebase worked properly earlier > this gitlab is really weird, litterally nothing has worked correctly for me It worked properly earlier likely because there were no conflicts. Use git locally as normal instead of the web interface to do it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8699

1 0

Re: [PATCH v5 0/5] MR820: Implement roothandle parameter NtLoadKeyEx
by Santino Mazza (＠tati1454) Sept. 16, 2022

Sept. 16, 2022

On Fri Sep 16 15:28:23 2022 +0000, Huw Davies wrote: > My Windows SDK has `REG_APP_HIVE` defined to 0x10. It also has > `REG_PROCESS_PRIVATE` as 0x20, which is presumably what > `REG_PROCESS_APPKEY` gets mapped to. > If the tests aren't going to work on Win 7, then skip them as soon as > the first call returns `STATUS_INVALID_PARAMETER_6`. > Since you've found that the key return is only available for an app key, > then I don't think it makes sense to split this MR up as I'd previously > suggested. That means we need the filename logic back in. > A couple of notes on that: When passing strings to the server, we > typically don't nul-terminate them and pass the length instead. Also, > there is logic there already that copes with loading and saving branches > i.e. the `save_branch_info` stuff. Have you looked into adapting that? Oh interesting, where do you find those headers in the windwos sdk? I've tried to find something like that but I'm always afraid of breaking the clean room guidelines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/820#note_8698

1 0

Re: [PATCH v19 0/1] MR778: ntoskrnl: KeInsertQueueDpc stub
by Etaash Mathamsetty (＠etaash.mathamsetty) Sept. 16, 2022

Sept. 16, 2022

On Thu Sep 15 22:27:44 2022 +0000, Bernhard Kölbl wrote: > > Rebase failed: Rebase locally, resolve all conflicts, then push the > branch. Try again. lol now another issue popped up, the rebase worked properly earlier this gitlab is really weird, litterally nothing has worked correctly for me -- https://gitlab.winehq.org/wine/wine/-/merge_requests/778#note_8695

1 0