January 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR1961: d3d12/tests: Allow a broken Windows 10 1709 hresult. - approved
by Henri Verbeet (＠hverbeet) Jan. 25, 2023

Jan. 25, 2023

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1961

1 0

[PATCH 0/1] MR1982: notepad: Fix uninitialized upper 64-bits of `pos` in DoFind.
by Gabriel Ivăncescu Jan. 25, 2023

Jan. 25, 2023

`EM_GETSEL` fills a `DWORD` only, so using a `SIZE_T` would leave upper bits to contain random values. We could initialize it to 0, but instead, just get rid of all the pointer cast hacks and use a proper pointer to check if it was found or not. In fact, this removes the duplication with setting pos to ~0, too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1982

1 1

[PATCH v4 0/1] MR1937: kernelbase: Fix grouping repeat for number formatting.
by Gabriel Ivăncescu Jan. 25, 2023

Jan. 25, 2023

LOCALE_SGROUPING's string and the `Grouping` field in NUMBERFMTW are confusingly different. The former, which is what is fixed here, treats a '0' as a repeat of the previous grouping. But a 0 at the end of the `Grouping` field prevents it from repeating (it repeats by default otherwise) so it's the opposite. Note that without a '0' in the LOCALE_SGROUPING string, it shouldn't even repeat in the first place. This fixes the typical "3;0" default grouping, for example. See: https://learn.microsoft.com/en-us/windows/win32/intl/locale-sgrouping -- v4: kernelbase: Fix grouping repeat for number formatting. https://gitlab.winehq.org/wine/wine/-/merge_requests/1937

1 1

[PATCH v2 0/1] MR1965: d3d12/tests: Fix the expected dxgi adapter refcount check.
by Francois Gouget (＠fgouget) Jan. 25, 2023

Jan. 25, 2023

-- v2: d3d12/tests: Fix the expected dxgi adapter refcount check. https://gitlab.winehq.org/wine/wine/-/merge_requests/1965

3 4

[PATCH v3 0/1] MR1937: kernelbase: Fix grouping repeat for number formatting.
by Gabriel Ivăncescu Jan. 25, 2023

Jan. 25, 2023

LOCALE_SGROUPING's string and the `Grouping` field in NUMBERFMTW are confusingly different. The former, which is what is fixed here, treats a '0' as a repeat of the previous grouping. But a 0 at the end of the `Grouping` field prevents it from repeating (it repeats by default otherwise) so it's the opposite. Note that without a '0' in the LOCALE_SGROUPING string, it shouldn't even repeat in the first place. This fixes the typical "3;0" default grouping, for example. See: https://learn.microsoft.com/en-us/windows/win32/intl/locale-sgrouping -- v3: kernelbase: Fix grouping repeat for number formatting. https://gitlab.winehq.org/wine/wine/-/merge_requests/1937

1 2

[PATCH 0/2] MR1980: Reduce testbot errors in kernel32:debugger on Windows.
by eric pouech (＠epo) Jan. 25, 2023

Jan. 25, 2023

Relax some order of debug events in kernel32:debugger tests. This reduces a bunch of failures when run on Windows. Unfortunately, this is not sufficient to get rid of all of them (still timeout in some cases, BZ 53144, wrong exit codes...). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1980

2 2

[PATCH v3 0/2] MR58: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts.
by Francisco Casas (＠fcasas) Jan. 25, 2023

Jan. 25, 2023

Reinterpret min16float, min10float, min16int, min12int, and min16uint as their regular counterparts: float, float, int, int, uint, respectively. A proper implementation would require adding minimum precision indicators to all the dxbc-tpf instructions that use these types. Consider the output of fxc 10.1 with the following shader: ```hlsl uniform int i; float4 main() : sv_target { min16float4 a = {0, 1, 2, i}; min16int2 b = {4, i}; min10float3 c = {6.4, 7, i}; min12int d = 9.4; min16uint4x2 e = {14.4, 15, 16, 17, 18, 19, 20, i}; return mul(e, b) + a + c.xyzx + d; } ``` ``` ps_5_0 dcl_globalFlags refactoringAllowed | enableMinimumPrecision dcl_constantbuffer CB0[1], immediateIndexed dcl_output o0.xyzw dcl_temps 3 imad r0.xyz {min16u}, l(15, 17, 19, 0) {def32 as min16u}, cb0[0].xxxx {def32 as min16u}, l(56, 64, 72, 0) {def32 as min16u} utof r0.xyz {min16f}, r0.xyzx {min16u} imad r1.x {min16u}, cb0[0].x {def32 as min16u}, cb0[0].x {def32 as min16u}, l(80) {def32 as min16u} utof r0.w {min16f}, r1.x {min16u} mov r1.xyz {min16f}, l(0,1.000000,2.000000,0) {def32 as min16f} itof r1.w {min16f}, cb0[0].x add r0.xyzw {min16f}, r0.xyzw {min16f}, r1.xyzw {min16f} mov r2.y {min2_8f}, l(7.000000) {def32 as min2_8f} itof r2.z {min2_8f}, cb0[0].x add r0.yz {min16f}, r0.yyzy {min16f}, r2.yyzy {min2_8f as min16f} add r0.xyzw {min16f}, r0.xyzw {min16f}, l(15.400000, 9.000000, 9.000000, 15.400000) {def32 as min16f} mov o0.xyzw, r0.xyzw {min16f as def32} ret ``` However, if the graphics driver doesn't have minimum precision support, it ignores the minimum precision indicators and runs at 32-bit precision, which is equivalent as working with regular types. -- v3: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts. tests: Test minimum-precision numeric types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/58

4 7

[PATCH 0/5] MR63: hlsl: Recursive function calls.
by Zebediah Figura (＠zfigura) Jan. 25, 2023

Jan. 25, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/63

4 7

[PATCH v3 0/6] MR61: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h. (PART 2/2)
by Francisco Casas (＠fcasas) Jan. 25, 2023

Jan. 25, 2023

Second part of !50. -- v3: vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_scope. vkd3d-shader/hlsl: Add field-level documentation to function structs. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_buffer. vkd3d-shader/hlsl: Add documentation to small hlsl.h structs. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_deref. vkd3d-shader/hlsl: Add documentation to struct hlsl_reg. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/61

4 10

[PATCH 0/1] MR1929: comctl32: Use ICGetDisplayFormat to open the AVI codec and find the output format
by Torge Matthies (＠tmatthies) Jan. 25, 2023

Jan. 25, 2023

ICM_DECOMPRESS_GET_FORMAT does not work well with the BITMAPINFOHEADER from MS-CRAM, because a biBitCount of 24 (or anything above 8) indicates RGB555 encoding, which actually means the bit count is 16 bpp, but the decoder rejects any format that doesn't have biBitCount of exactly 8 or 16. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54024 Signed-off-by: Torge Matthies <tmatthies(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1929

4 10