January 2023 - Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) Jan. 5, 2023

Jan. 5, 2023

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- v2: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

4 7

[PATCH 0/2] MR1916: msvcirt: Fixes for streambuf::xsputn and ostream::opearator<<
by Piotr Caban (＠piotr) Jan. 5, 2023

Jan. 5, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54180 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1916

2 2

[PATCH 0/1] MR1914: winex11: Simplify confusing condition and error messages in wglShareLists.
by Alex Henrie (＠alexhenrie) Jan. 5, 2023

Jan. 5, 2023

Mathematically, ((a && b) || b) == b. Moreover, test_sharelists in dlls/opengl32/tests/opengl.c checks that wglShareLists can share lists from a source context that has been current. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1914

2 1

[PATCH v2 0/2] MR58: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts.
by Francisco Casas (＠fcasas) Jan. 5, 2023

Jan. 5, 2023

Reinterpret min16float, min10float, min16int, min12int, and min16uint as their regular counterparts: float, float, int, int, uint, respectively. A proper implementation would require adding minimum precision indicators to all the dxbc-tpf instructions that use these types. Consider the output of fxc 10.1 with the following shader: ```hlsl uniform int i; float4 main() : sv_target { min16float4 a = {0, 1, 2, i}; min16int2 b = {4, i}; min10float3 c = {6.4, 7, i}; min12int d = 9.4; min16uint4x2 e = {14.4, 15, 16, 17, 18, 19, 20, i}; return mul(e, b) + a + c.xyzx + d; } ``` ``` ps_5_0 dcl_globalFlags refactoringAllowed | enableMinimumPrecision dcl_constantbuffer CB0[1], immediateIndexed dcl_output o0.xyzw dcl_temps 3 imad r0.xyz {min16u}, l(15, 17, 19, 0) {def32 as min16u}, cb0[0].xxxx {def32 as min16u}, l(56, 64, 72, 0) {def32 as min16u} utof r0.xyz {min16f}, r0.xyzx {min16u} imad r1.x {min16u}, cb0[0].x {def32 as min16u}, cb0[0].x {def32 as min16u}, l(80) {def32 as min16u} utof r0.w {min16f}, r1.x {min16u} mov r1.xyz {min16f}, l(0,1.000000,2.000000,0) {def32 as min16f} itof r1.w {min16f}, cb0[0].x add r0.xyzw {min16f}, r0.xyzw {min16f}, r1.xyzw {min16f} mov r2.y {min2_8f}, l(7.000000) {def32 as min2_8f} itof r2.z {min2_8f}, cb0[0].x add r0.yz {min16f}, r0.yyzy {min16f}, r2.yyzy {min2_8f as min16f} add r0.xyzw {min16f}, r0.xyzw {min16f}, l(15.400000, 9.000000, 9.000000, 15.400000) {def32 as min16f} mov o0.xyzw, r0.xyzw {min16f as def32} ret ``` However, if the graphics driver doesn't have minimum precision support, it ignores the minimum precision indicators and runs at 32-bit precision, which is equivalent as working with regular types. -- v2: vkd3d-shader/hlsl: Reinterpret minimum precision types as their regular counterparts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/58

4 9

[PATCH v8 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) Jan. 5, 2023

Jan. 5, 2023

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v8: comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

3 21

Re: [PATCH v6 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 12:10:54 2023 +0000, Philip Karlsson Gisslow wrote: > I see, I changed it now. Excellent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20369

1 0

Re: [PATCH v6 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 12:04:49 2023 +0000, Bernhard Kölbl wrote: > Maybe something along the lines of: "msi: Initialize WINTRUST_DATA to > zero." ? I see, I changed it now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20368

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 11:45:30 2023 +0000, Philip Karlsson Gisslow wrote: > Thank you for taking the time Bernhard, I am not sure what I am missing, > the dot after the first sentence? I really want to get this right as I > would be happy to help out contributing more going forward. Maybe something along the lines of: "msi: Initialize WINTRUST_DATA to zero." ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20364

1 0

[PATCH 0/4] MR1913: Fix winedbg module's search path.
by eric pouech (＠epo) Jan. 5, 2023

Jan. 5, 2023

This series solves https://bugs.winehq.org/show_bug.cgi?id=54250 The two first patches address proper loading of modules in dbghelp. There are cases where the path sent in the dll load debug event isn't the real path to the loaded module. The two last patches are to expose the real path of the module for integration in when winedbg acts as a proxy to gdb. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1913

3 4

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 11:43:46 2023 +0000, Bernhard Kölbl wrote: > Just wanna take the time to point out that the commit message isn't > matching Wine's requirements > https://wiki.winehq.org/Submitting_Patches#The_commit_message . Thank you for taking the time Bernhard, I am not sure what I am missing, the dot after the first sentence? I really want to get this right as I would be happy to help out contributing more going forward. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20363

1 0