January 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 11:43:46 2023 +0000, Bernhard Kölbl wrote: > Just wanna take the time to point out that the commit message isn't > matching Wine's requirements > https://wiki.winehq.org/Submitting_Patches#The_commit_message . Thank you for taking the time Bernhard, I am not sure what I am missing, the dot after the first sentence? I really want to get this right as I would be happy to help out contributing more going forward. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20363

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Bernhard Kölbl Jan. 5, 2023

Jan. 5, 2023

Just wanna take the time to point out that the commit message isn't matching Wine's requirements https://wiki.winehq.org/Submitting_Patches#The_commit_message . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20362

1 0

Re: [PATCH v5 0/1] MR1907: user32: Set 32-bit base address.
by Patrick Szczepański Jan. 5, 2023

Jan. 5, 2023

@gverm Okey, it's done - sorry for bunch of force-updated commits, I just noticed how wine-team is paying attention to details and I'm trying to fit into the rules. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907#note_20361

1 0

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized - approved
by Hans Leidekker (＠hans) Jan. 5, 2023

Jan. 5, 2023

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

1 0

[PATCH v2 0/1] MR1912: winevulkan: Enable VK_EXT_hdr_metadata
by Joshua Ashton (＠joshua) Jan. 5, 2023

Jan. 5, 2023

This works fine with the new struct conversions, and is needed for HDR with native Vulkan games such as Doom Eternal and games using HDR with DXVK and VKD3D-Proton. -- v2: winevulkan: Enable VK_EXT_hdr_metadata. https://gitlab.winehq.org/wine/wine/-/merge_requests/1912

2 1

Re: [PATCH v4 0/1] MR1907: user32: Set 32-bit base address.
by Gijs Vermeulen (＠gverm) Jan. 5, 2023

Jan. 5, 2023

@PSzczepanski1996 You'll need to set the author of your commit to your real name as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907#note_20357

1 0

[PATCH 0/1] MR1909: comctl32/tests: Ignore some IME messages in monthcal tests.
by Nikolay Sivov (＠nsivov) Jan. 5, 2023

Jan. 5, 2023

Should fix test failures on some systems with enabled IME. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1909

3 2

[PATCH 0/1] MR1912: winevulkan: Enable VK_EXT_hdr_metadata
by Joshua Ashton (＠joshua) Jan. 5, 2023

Jan. 5, 2023

This works fine with the new struct conversions, and is needed for HDR with native Vulkan games such as Doom Eternal and games using HDR with DXVK and VKD3D-Proton. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1912

2 1

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) Jan. 5, 2023

Jan. 5, 2023

On Thu Jan 5 07:09:52 2023 +0000, Nikolay Sivov wrote: > @ripxorip please squash these commits locally and then force push to > have a single commit. Sure thing -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20355

1 0

[PATCH v3 0/3] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) Jan. 5, 2023

Jan. 5, 2023

This field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). -- v3: Sends the correct pointer to memset https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

3 4