October 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 2, 2023

Oct. 2, 2023

On Mon Oct 2 19:06:41 2023 +0000, YuriK7 wrote: > We tried to add the codec by adding > --enable-decoder=mpegvideo,--enable-decoder=mpeg1video,--enable-decoder=mpeg2video > and it still show the color bars... does it also need flags for the > demuxer and parser in order to work ? > In your gstkrkr code you say that "in GStreamer, decoding a mpeg video > requires three elements: mpegpsdemux ! mpegvideoparse ! > avdec_mpeg2video" are those enabled by default if the ffmpeg flags are > good ? We should enable them inside the GST_BAD_MESON_ARGS ? > avdec_mpeg2video seems to be in the libav plugin. > We made those changes to https://github.com/GloriousEggroll/proton-ge-custom/blob/master/Makefile.in mpegpsdemux is part of libgstmpegpsdemux.so. It's unrelated to ffmpeg, and it's present in Glorious-Eggroll already, nothing to do here. (However, it's absent from upstream Proton.) mpegvideoparse is in libgstvideoparsersbad.so. Likewise, this is part of GE but not Proton, and is not part of ffmpeg. avdec_mpeg2video is in libgstlibav.so, which is part of Proton - but the exact set of decoders it offers depends on which ffmpeg you have installed, and how it's configured. Did you rebuild ffmpeg and copy that into an existing Wine or Proton installation, without changing anything else? If yes, GStreamer probably didn't notice the update. `touch` libgstlibav.so, or delete your GStreamer plugin cache (probably at ~/.cache/gstreamer-1.0/registry.x86_64.bin or ~/steam/steamapps/compatdata/1234560/gstreamer-1.0/registry.x86_64.bin). You can also grep that registry file for avdec_mpeg2video: if that string is absent, then there's something wrong with your GStreamer or your ffmpeg, but if it does exist, the problem is on Wine's side (probably in this MR). (The cache is binary, but grep telling you whether the binary file matches is good enough.) Alternatively, I may simply be wrong; I've never compiled Proton, GE, or ffmpeg. Good call on trying mpeg2video; if it exists, it's probably better than plain mpegvideo. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47409

1 0

[PATCH 0/5] MR3996: dmsynth: Import and begin using FluidSynth.
by Rémi Bernon Oct. 2, 2023

Oct. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3996

2 10

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) Oct. 2, 2023

Oct. 2, 2023

On Sun Oct 1 23:56:05 2023 +0000, Alfred Agrell wrote: > Yes, that is consistent with my experience. I tried Azumanga (everything > looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine > 8.17 with this patch, and Debian's Wine 8.0; different output before the > crash, but they all segfault in > SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different > bug to me. > The color bars are not a Wine bug; they're protonmediaconverter. It does > that if it can't find a converted version of the media, which it can't > if you're running it outside Steam. gstkrkr fills that exact hole. > (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder > is selected instead of mediaconverter.) We tried to add the codec by adding --enable-decoder=mpegvideo,--enable-decoder=mpeg1video,--enable-decoder=mpeg2video and it still show the color bars... does it also need flags for the demuxer and parser in order to work ? In your gstkrkr code you say that "in GStreamer, decoding a mpeg video requires three elements: mpegpsdemux ! mpegvideoparse ! avdec_mpeg2video" are those enabled by default if the ffmpeg flags are good ? We should enable them inside the GST_BAD_MESON_ARGS ? avdec_mpeg2video seems to be in the libav plugin. We made those changes to https://github.com/GloriousEggroll/proton-ge-custom/blob/master/Makefile.in -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47406

1 0

Re: [PATCH v11 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) Oct. 2, 2023

Oct. 2, 2023

I've rebased again. I'm not really sure what to do with this. There seem to be outstanding test failures in mmdevapi. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3554#note_47403

1 0

[PATCH v2 0/5] MR3995: dmime: Preparatory cleanup of segment state.
by Rémi Bernon Oct. 2, 2023

Oct. 2, 2023

-- v2: dmime: Introduce a new segment_state_create constructor. dmime: Redirect IDirectMusicPerformance_PlaySegment to PlaySegmentEx. dmime: Implement some segment state default values. dmime: Get rid of the IDirectMusicSegmentState8Impl typedef. dmime: Rename DirectMusicSegmentState8 method prefix to segment_state. https://gitlab.winehq.org/wine/wine/-/merge_requests/3995

2 8

Re: [PATCH v11 0/4] MR3554: mmdevapi: fixes for Yousician
by David McFarland (＠corngood) Oct. 2, 2023

Oct. 2, 2023

On Mon Oct 2 18:16:53 2023 +0000, David McFarland wrote: > comment fixed. > > It would be nice if at least the lower bound could be read from the > native audio system, though I don't know how to do that > I like this idea, but I'm not sure how to pull it off either. I guess > the biggest downside to this implementation would be unnecessarily high latency? > My preference would be to leave that for a separate MR. I'm going to resolve this. Feel free to reopen if it's blocking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3554#note_47399

1 0

[PATCH v2 0/8] MR3993: windows.media.mediacontrol: Implement some ISystemMediaTransportControls properties.
by Mohamad Al-Jaf (＠maljaf) Oct. 2, 2023

Oct. 2, 2023

Called by Roon. I have more patches for this, but I split them up for easier review. -- v2: windows.media.mediacontrol: Implement some ISystemMediaTransportControls properties. windows.media.mediacontrol/tests: Add some ISystemMediaTransportControls properties tests. windows.media.mediacontrol: Implement ISystemMediaTransportControlsInterop::GetForWindow(). windows.media.mediacontrol/tests: Add ISystemMediaTransportControlsInterop::GetForWindow() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3993

3 11

[PATCH 0/5] MR3994: include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
by Alex Henrie (＠alexhenrie) Oct. 2, 2023

Oct. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3994

3 6

[PATCH v3 0/4] MR3983: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) Oct. 2, 2023

Oct. 2, 2023

Needed for Minecraft Windows 10. -- v3: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current(). windows.storage.applicationdata/tests: Add IApplicationDataStatics::get_Current() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3983

4 8

[PATCH v3 0/8] MR3956: uiautomationcore: Add support for raising events using the IProxyProviderWinEventHandler interface.
by Connor McAdams (＠cmcadams) Oct. 2, 2023

Oct. 2, 2023

-- v3: uiautomationcore: Add support for raising events passed to our IProxyProviderWinEventSink interface. uiautomationcore: Pass WinEvent data to IProxyProviderWinEventHandler::RespondToWinEvent. uiautomationcore: Add support for marking the root IAccessible as known on non-root IAccessibles upon proxy provider creation. uiautomationcore: Add support for ignoring ProviderOptions_UseComThreading when creating an HUIANODE. uiautomationcore: Create HUIANODE for WinEvents that should invoke IProxyProviderWinEventHandler::RespondToWinEvent. uiautomationcore: Check if we should try to invoke IProxyProviderWinEventHandler::RespondToWinEvent for registered UIA events. uiautomationcore: Introduce uia_event_for_each function for iterating through registered events. uiautomationcore/tests: Add another test for IProxyProviderWinEventHandler child HWND scope checking. https://gitlab.winehq.org/wine/wine/-/merge_requests/3956

3 10