October 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) Oct. 2, 2023

Oct. 2, 2023

Yes, currently MCI_MapMsgAtoW returns a tri-state. -1 = Memory allocation error 0 = No unmap required 1 = Unmap required. Since MCI_UnmapMsgAtoW handles all the cases where MCI_MapMsgAtoW allocates memory. Why not just call MCI_UnmapMsgAtoW to do its thing in all cases? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_47342

1 0

[PATCH 0/1] MR3991: gdi32: Pass default DEVMODE to winspool in CreateDC."
by Piotr Caban (＠piotr) Oct. 2, 2023

Oct. 2, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55670 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3991

3 2

[PATCH 0/5] MR3995: dmime: Preparatory cleanup of segment state.
by Rémi Bernon Oct. 2, 2023

Oct. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3995

2 6

[PATCH v2 0/4] MR3983: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) Oct. 2, 2023

Oct. 2, 2023

Needed for Minecraft Windows 10. -- v2: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current(). windows.storage.applicationdata/tests: Add IApplicationDataStatics::get_Current() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3983

4 7

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 1, 2023

Oct. 1, 2023

On Sun Oct 1 23:30:07 2023 +0000, YuriK7 wrote: > Thanks ! > The game I mentioned (touhou sky fight) is a weird case. It already > hangs (actually it just errors out and closes) without your patch on > vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they > updated it to 1.22. With the old gstreamer it used to be a skippable > black screen, however adding gstkrkr makes it crash. This merge doesn't > seem to change anything on that so be reassured, I guess I should open > either a wine issue or a gstreamer issue... > But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works > perfectly well with the new gstreamer + gstkrkr (the new version show a > color bars screen when the codec is missing, instead of playing the sound). Yes, that is consistent with my experience. I tried Azumanga (everything looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine 8.17 with this patch, and Debian's Wine 8.0; different output before the crash, but they all segfault in SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different bug to me. The color bars are not a Wine bug; they're protonmediaconverter. It does that if it can't find a converted version of the media, which it can't if you're running it outside Steam. gstkrkr fills that exact hole. (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder is selected instead of mediaconverter.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47318

1 0

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) Oct. 1, 2023

Oct. 1, 2023

On Sun Oct 1 14:18:55 2023 +0000, Alfred Agrell wrote: > Glorious-Eggroll has a MPEG demuxer, which Proton's GStreamer lacks, but > neither of them have any MPEG-1 video decoder. > From what I can google, the correct incantation is adding > --enable-decoder=mpegvideo to GE's ffmpeg configure line; if successful, > it should show up in GStreamer as avdec_mpeg2video. > If adding gstkrkr works even without this MR, my guess is that those > programs tell DirectShow to automatically pick the appropriate decoders, > which ends up using CLSID_decodebin_parser instead of > CLSID_CMpegVideoCodec; you were missing the codec, but nothing else. > If adding this MR makes it hang or otherwise screw up, that's definitely > something I should look into... Thanks ! The game I mentioned (touhou sky fight) is a weird case. It already hangs (actually it just errors out and closes) without your patch on vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they updated it to 1.22. With the old gstreamer it used to be a skippable black screen, however adding gstkrkr makes it crash. This merge doesn't seem to change anything on that so be reassured, I guess I should open either a wine issue or a gstreamer issue... But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works perfectly well with the new gstreamer + gstkrkr (the new version show a color bars screen when the codec is missing, instead of playing the sound). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47317

1 0

[PATCH v10 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) Oct. 1, 2023

Oct. 1, 2023

Used in some .NET apps for theming purposes. -- v10: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

3 2

[PATCH v3 0/11] MR3907: ntdll: Initial implementation of File{Rename,Link}InformationEx
by Joel Holdsworth (＠jhol) Oct. 1, 2023

Oct. 1, 2023

-- v3: ntdll: Add support for FILE_{RENAME,LINK}_POSIX_SEMANTICS. ntdll: Factored out get_inode_open_sharing. ntdll/test: Add tests for FILE_LINK_POSIX_SEMANTICS. ntdll/test: Add tests for FILE_RENAME_POSIX_SEMANTICS. ntdll: Add support for FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE. server: Don't allow read-only files to be replaced by File{Rename,Link}Information{,Ex}. ntdll/test: Add tests for FILE_LINK_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Add tests for FILE_RENAME_IGNORE_READONLY_ATTRIBUTE. ntdll/test: Use FileDispositionInformationEx to delete files and directories. ntdll: Initial implementation of FileLinkInformationEx. ntdll: Initial implementation of FileRenameInformationEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/3907

4 19

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 1, 2023

Oct. 1, 2023

On Sun Oct 1 13:54:50 2023 +0000, YuriK7 wrote: > Adding the gstkrkr .so files does indeed fix the issue even without this > merge an azumanga fighter and HaruToma 2. It didn't worked with touhou > sky fight but I couldn't test with your merge as it hangs with vanilla wine. > I thought wine-ge had all the plugins, as I used their libs to get rid > of the missing MPEG1 decoder issue. Do you know exactly which > plugin/part/flag they have to add ? Glorious-Eggroll has a MPEG demuxer, which Proton's GStreamer lacks, but neither of them have any MPEG-1 video decoder. >From what I can google, the correct incantation is adding --enable-decoder=mpegvideo to GE's ffmpeg configure line; if successful, it should show up in GStreamer as avdec_mpeg2video. If adding gstkrkr works even without this MR, my guess is that those programs tell DirectShow to automatically pick the appropriate decoders, which ends up using CLSID_decodebin_parser instead of CLSID_CMpegVideoCodec; you were missing the codec, but nothing else. If adding this MR makes it hang or otherwise screw up, that's definitely something I should look into... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47297

1 0

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) Oct. 1, 2023

Oct. 1, 2023

On Sun Oct 1 13:54:50 2023 +0000, Alfred Agrell wrote: > Yep, that one looks like a close relative of > https://bugs.winehq.org/show_bug.cgi?id=9127 (possibly even duplicate). > Last time I checked, Proton-GE didn't include any MPEG video decoder. > Probably because it's unnecessary - without Wine-side support, there's > no way to access that codec, so there's no point wasting space on it. > Once this thing is merged, that will become a bug on their end. Feel > free to report it. > If you want a faster solution, you can take the GStreamer plugin from > https://github.com/Alcaro/krkrwine/releases/tag/v1.0.0 and place it in > the GST_PLUGIN_SYSTEM_PATH. (I wouldn't recommend installing the rest of > that program, it's tested with Proton 8.0 only and may interact weirdly > with this MR.) Adding the gstkrkr .so files does indeed fix the issue even without this merge an azumanga fighter and HaruToma 2. It didn't worked with touhou sky fight but I couldn't test with your merge as it hangs with vanilla wine. I thought wine-ge had all the plugins, as I used their libs to get rid of the missing MPEG1 decoder issue. Do you know exactly which plugin/part/flag they have to add ? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47296

1 0