October 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4152: dnsapi: Handle IP address as DNS name in DnsQuery_UTF8().
by Paul Gofman (＠gofman) Oct. 23, 2023

Oct. 23, 2023

Fixes Tekken 8 (early access) being unable to find other players for match. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4152

3 4

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Paul Gofman (＠gofman) Oct. 23, 2023

Oct. 23, 2023

On Sat Oct 21 10:27:59 2023 +0000, Jinoh Kang wrote: > Okay, I've read the prior discussions regarding the rationale. > Still, I don't think you should change the System UUID for *existing* > prefixes. Perhaps we could use the registry to detect whether the > prefix is new, and use the new algorithm for new prefixes. We could > also record the UUID in the registry "permanently." Maintaining any way of backward compat on this ID doesn't look feasible. E. g., the current way with a bug reports bios hashtag in serial field on my desktop due to missing fields not being handled. This ID is already non-unique, and maintaining these algorithms backwards would take unreasonable amount of effort (with arguably no gains). Probably more important, /etc/machine-id can be changed anytime by user or system resintall, it is not true hardware id. If anything firmly relies on HW id to persist forever, it is broken already. Regarding the original discussion, I also don't really understand why we should necessarily obfuscate /etc/machine-id for uuid / serial reporting. App has access to the file anyway, and Wine neither sends the ID anywhere nor tracks the user, it is between the app and the user. On Windows fwiw it will get real motherboard serial and other information like that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49550

1 0

[PATCH 0/1] MR4156: ntdll/tests: Use win_skip() for missing APIs in test_query_process_debug_port_custom_dacl.
by Jinoh Kang (＠iamahuman) Oct. 23, 2023

Oct. 23, 2023

A missing API is a todo in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4156

2 1

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) Oct. 23, 2023

Oct. 23, 2023

On Sat Oct 21 10:25:18 2023 +0000, Jinoh Kang wrote: > This changes the system GUID. Some DRMs and copy protections like to > assume that things like System UUIDs are permanent and never change. > Changing this will break such apps and the user might have to > reinstall/re-purchase them again. Okay, I've read the prior discussions regarding the rationale. Still, I don't think you should change the System UUID for *existing* prefixes. Perhaps we could use the registry to detect whether the prefix is new, and use the new algorithm for new prefixes. We could also record the UUID in the registry "permanently." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49548

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) Oct. 23, 2023

Oct. 23, 2023

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/system.c: > system_args.version = system_version; > system_args.serial_len = get_smbios_string("/sys/class/dmi/id/product_serial", S(system_serial)); > system_args.serial = system_serial; > - get_system_uuid(&system_args.uuid); > + derive_machineid_to_uuid(&system_args.uuid); This changes the system GUID. Some DRMs and copy protections like to assume that things like System UUIDs are permanent and never change. Changing this will break such apps and the user might have to reinstall/re-purchase them again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49547

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by Jinoh Kang (＠iamahuman) Oct. 23, 2023

Oct. 23, 2023

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/system.c: > close( fd ); > } > } > > +static void derive_machineid_to_uuid( GUID *uuid ) > +{ > + static unsigned char wine_uuid[16] = { 0xe8, 0x65, 0x52, 0x8d, 0x0a, 0xa2, 0x45, 0x27, > + 0xa8, 0x3b, 0x15, 0xed, 0x41, 0xb5, 0xd0, 0x91 }; > + GUID machine_uuid; > + unsigned char out256[32]; /* returning first 128 bits only */ > + > + read_machine_id( &machine_uuid ); > + > + hmac_sha256( wine_uuid, sizeof(wine_uuid), (const unsigned char *)&machine_uuid, sizeof(machine_uuid), out256 ); > + > + memset( &machine_uuid, 0, sizeof(machine_uuid) ); This write is unused and will be optimized out by the compiler. Are you looking for something like [`explicit_bzero(3)`](https://man7.org/linux/man-pages/man3/bzero.3.html)? In that case, why is machine UUID considered sensitive enough to warrant erasure? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49546

1 0

[PATCH v18 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 23, 2023

Oct. 23, 2023

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v18: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_MPEG1 media type. winegstreamer: Use the new output_compressed property instead of mpegaudioparse in MPEG splitter. winegstreamer: Add output_compressed parameter to wg_parser_create(). winegstreamer: Implement parts of IAMStreamSelect::Info in CLSID_MPEG1Splitter. winegstreamer: Implement IAMStreamSelect::Count in CLSID_MPEG1Splitter. winegstreamer: Improve and clean up some debug logs. winegstreamer: Include the framerate when converting video format to GstCaps. winegstreamer: Seek to end of stream instead of to stream duration. winegstreamer: Clamp QoS events to stay inside the stream's running time. winegstreamer: Don't read format from unparsed MPEG audio. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

3 20

[PATCH v7 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu Oct. 23, 2023

Oct. 23, 2023

-- v7: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

3 4

Re: [PATCH v2 0/1] MR4143: uxtheme: Add ShouldAppsUseDarkMode.
by Louis Lenders (＠xe) Oct. 23, 2023

Oct. 23, 2023

>and a Wine-Bug: link in the commit message. How do I do that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4143#note_49536

1 0

[PATCH v3 0/2] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) Oct. 22, 2023

Oct. 22, 2023

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- v3: shell32: Increase timeout for long URLs https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 5