October 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Conor McCarthy (＠cmccarthy) Oct. 11, 2023

Oct. 11, 2023

I remember it took quite a bit of work to generate test data, but I don't remember how I did it. I'll try to find some source code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_48360

1 0

Re: [PATCH v44 0/7] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Oct. 11, 2023

Oct. 11, 2023

Okay, I will revert those specific tests. Generating the PE binaries won't be such a problem, however generating patch data that works on a generated PE is a problem. This would require writing implementations for most of mspatchc in order to properly generate patch data. I'm curious how the original author of the mspatcha implementation @cmccarthy generated the patch data Any help with this would be very valuable and appreciated. I am trying to fix a 15 year old bug report with these changes so that people can finally install software without the need for manually installing the native Microsoft mspatcha binary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_48358

1 0

[PATCH v2 0/1] MR4063: winex11.drv: Set _NET_WM_FULLSCREEN_MONITORS only when necessary.
by Zhiyi Zhang (＠zhiyi) Oct. 11, 2023

Oct. 11, 2023

If _NET_WM_FULLSCREEN_MONITORS is set then the property needs to be updated because it can't be deleted by sending a _NET_WM_FULLSCREEN_MONITORS client message to the root window according to the wm-spec version 1.5. Having the window spanning more than two monitors also needs the property set. In other cases, _NET_WM_FULLSCREEN_MONITORS doesn't need to be set. What's more, setting _NET_WM_FULLSCREEN_MONITORS adds a constraint on Mutter so that such a window can't be moved to another monitor by using the Shift+Super+Up/Down/Left/Right shortcut. So the property should be added only when necessary. -- v2: winex11.drv: Set _NET_WM_FULLSCREEN_MONITORS only when necessary. https://gitlab.winehq.org/wine/wine/-/merge_requests/4063

2 1

[PATCH 0/6] MR4075: wineps.drv: Use first page DEVMODE to determine number of copies and collation.
by Piotr Caban (＠piotr) Oct. 11, 2023

Oct. 11, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55718 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4075

4 8

[PATCH v2 0/6] MR4075: wineps.drv: Use first page DEVMODE to determine number of copies and collation.
by Piotr Caban (＠piotr) Oct. 11, 2023

Oct. 11, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55718 -- v2: wineps.drv: Use first page DEVMODE to determine number of copies and collation. gdi32: Add GdiGetDevmodeForPage implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/4075

3 7

Re: [PATCH v2 0/1] MR4065: xinput1_3: Hold module reference while the hid thread is running.
by Arek Hiler (＠ivyl) Oct. 11, 2023

Oct. 11, 2023

The failed 32bit tests are the following: ``` domdoc.c:2521: Test failed: Unexpected hr 0x1. filtergraph.c:635: Test failed: Got hr 0x40242. filtergraph.c:571: Test failed: Got hr 0x80004005. speech.c:1386: Test failed: Wait for block_thread failed. ``` Unrelated to the patch + they've been failing all across different MRs here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4065#note_48346

1 0

[PATCH 0/2] MR4074: gdi32: Fix METADC handling in PlayMetaFile.
by Piotr Caban (＠piotr) Oct. 11, 2023

Oct. 11, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4074

3 3

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) Oct. 11, 2023

Oct. 11, 2023

Hi Zhiyi, thanks for the clear explanation, I'll have a look into this and try to fix something up, but that'll be in the weekend/next week. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48343

1 0

Re: [PATCH v2 0/2] MR4058: gdi32/emf: Add SetBrushOrgEx() recording.
by Nikolay Sivov (＠nsivov) Oct. 11, 2023

Oct. 11, 2023

On Wed Oct 11 11:05:32 2023 +0000, Chip Davis wrote: > According to [docs][1], `SetBrushOrgEx()` is supposed to affect the > *next* brush that is selected into the device context. It might be > interesting, then, to see what happens when a brush is selected into the > DC after calling `SetBrushOrgEx()`. > [1]: https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-setbru… That's not reflected by EMF recording, and will need some rendering tests. It's best to have a bug report for that so it's not forgotten. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4058#note_48338

1 0

Re: [PATCH v3 0/2] MR3915: ddraw/tests: Test WS_EX_TOPMOST restoration. - approved
by Jan Sikorski (＠jsikorski) Oct. 11, 2023

Oct. 11, 2023

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3915

1 0