October 2023 - Wine-GitLab - list.winehq.org

[PATCH v9 0/8] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 10, 2023

Oct. 10, 2023

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v9: Revert "ntdll: Support relocating the main exe." quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_MPEG1 media type. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

4 10

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) Oct. 10, 2023

Oct. 10, 2023

``` + void *proc; + int i; + HMODULE uxtheme = GetModuleHandleA("uxtheme.dll"); + static const struct + { + const char *name; + int ordinal; + } + func[] = + { + {"DrawThemeBackgroundEx", 47}, + {"IsThemeDialogTextureEnabled", 132}, + {"IsThemePartDefined", 133}, + {"SetThemeAppProperties", 135} + }; ``` Let's put the static const test data first. And let's sort the declarations, like this. ``` + HMODULE uxtheme; + void *proc; + int i; + + uxtheme= GetModuleHandleA("uxtheme.dll"); ``` ``` + for (i = 0; i < ARRAY_SIZE(func); i++) + { + proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func->ordinal)); + ok(proc == GetProcAddress(uxtheme, func->name), "Expected %s at ordinal %u\n", func->name, func->ordinal); + } ``` You're not using i at all so you're just testing the first function. ```ok(proc == GetProcAddress(uxtheme, func->name), "Expected %s at ordinal %u\n", func->name, func->ordinal);``` "Expected %s at ordinal %u\n" -> "Expected %s at ordinal %d.\n" You can remove the ordinal tests for DrawThemeBackgroundEx() in test_DrawThemeBackgroundEx(). Thank you for working on this by the way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48211

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Gabriel Ivăncescu Oct. 10, 2023

Oct. 10, 2023

On Tue Oct 10 14:26:32 2023 +0000, Louis Lenders wrote: > Well, I don't know about coders etiquette but at the organization I work > it's not rude to ask an expert to fix a problem... Anyway I fixed up a > test, and Ill reopen the bug. @zhiyi, could you have a look at patch > below? I'm attaching it as a patch for now as I don't want to go through > gitlab horror again. > diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c > index 2e769625dab..0c1a1b28fee 100644 > --- a/dlls/uxtheme/tests/system.c > +++ b/dlls/uxtheme/tests/system.c > @@ -285,6 +285,31 @@ static LRESULT WINAPI > TestSetWindowThemeChildProcA(HWND hwnd, UINT message, WPAR > return ret; > } > > +static void test_ordinals(void) > +{ > + void *proc; > + int i; > + HMODULE uxtheme = GetModuleHandleA("uxtheme.dll"); > + static const struct > + { > + const char *name; > + int ordinal; > + } > + func[] = > + { > + {"DrawThemeBackgroundEx", 47}, > + {"IsThemeDialogTextureEnabled", 132}, > + {"IsThemePartDefined", 133}, > + {"SetThemeAppProperties", 135} > + }; > + > + for (i = 0; i < ARRAY_SIZE(func); i++) > + { > + proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func->ordinal)); > + ok(proc == GetProcAddress(uxtheme, func->name), "Expected %s at > ordinal %u\n", func->name, func->ordinal); > + } > +} > + > static void test_IsThemed(void) > { > BOOL bThemeActive; > @@ -2605,6 +2630,7 @@ START_TEST(system) > init_funcs(); > init_msg_sequences(sequences, NUM_MSG_SEQUENCES); > > + test_ordinals(); > test_IsThemed(); > test_IsThemePartDefined(); > test_GetWindowTheme(); You don't have to go through gitlab horror again, just force push to your branch with git with updated local branch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48210

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) Oct. 10, 2023

Oct. 10, 2023

patch is at https://testbot.winehq.org/GetFile.pl?JobKey=138590&StepKey=1 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_48209

1 0

[PATCH 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) Oct. 10, 2023

Oct. 10, 2023

https://bugs.winehq.org/show_bug.cgi?id=55742 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043

4 8

[PATCH 0/4] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu Oct. 10, 2023

Oct. 10, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

3 11

[PATCH 0/3] MR4038: ddraw: Always create surfaces with WINED3D_BIND_SHADER_RESOURCE if possible.
by Zebediah Figura (＠zfigura) Oct. 10, 2023

Oct. 10, 2023

Surfaces without DDSCAPS_TEXTURE can still be textured when used with a software device. wined3d currently doesn't care about the bind flags for surfaces set with wined3d_stateblock_set_texture(), but we currently set the right bind flags anyway. More saliently, I plan to change this fact, and internally translate those textures to SRVs, in order to simplify some internal code and make d3d1-9 support for the Vulkan backend easier. In this case we really will need WINED3D_BIND_SHADER_RESOURCE to be set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4038

4 7

[PATCH v3 0/4] MR4024: uiautomationcore: COM focus change event handler event advisement support.
by Connor McAdams (＠cmcadams) Oct. 10, 2023

Oct. 10, 2023

-- v3: uiautomationcore: Use EVENT_OBJECT_DESTROY to remove HWNDs from the COM API focus change HWND map. uiautomationcore: Use EVENT_OBJECT_FOCUS to advise HWND providers of focus change events in the COM API. uiautomationcore: Query EVENT_OBJECT_FOCUS HWND for a serverside provider if there is a registered focus change event handler. uiautomationcore/tests: Add tests for IUIAutomationFocusChangedEventHandler event advisement behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/4024

3 7

[PATCH v2 0/5] MR4064: dmime: Load and play .wav file-based segments.
by Rémi Bernon Oct. 10, 2023

Oct. 10, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9027 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34751 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45135 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48220 -- v2: dmime: Play direct sound buffer from DMUS_PMSGT_WAVE message. dmime: Implement IDirectMusicTrack_Play for the wave track. dmime: Implement GUID_(Download|Unload)FromAudioPath for wave track. dmime: Create a wave track when loading a segment from a .wav. dmime: Get rid of the IDirectMusicWaveTrack typedef. https://gitlab.winehq.org/wine/wine/-/merge_requests/4064

2 7

[PATCH v2 0/2] MR4047: Msxml copytests
by Daniel Lehman (＠dlehman25) Oct. 10, 2023

Oct. 10, 2023

-- v2: msxml6/tests: Copy namespaces as attributes tests. msxml4/tests: Copy namespaces as attributes tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4047

3 3