November 2023 - Wine-GitLab

[PATCH v3 0/1] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) Nov. 6, 2023

Nov. 6, 2023

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. ~~Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones.~~ Tweak the representation a bit so they are happy. -- v3: ntdll: Tweak the binary representation of SRWLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

3 6

[PATCH 0/9] MR4311: Draft: Ucrt
by Bartosz Kosiorek (＠gang65) Nov. 6, 2023

Nov. 6, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4311

3 12

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) Nov. 6, 2023

Nov. 6, 2023

On Mon Nov 6 14:46:29 2023 +0000, Yuxuan Shui wrote: > demonstrate the leak? or demonstrate the race condition? > in the first case, our unit test already does. in the second case, i > don't see how that's useful? the race condition is pretty clearly there, > simply based on the fact that the callback might be running when you try > to cancel it. https://gist.github.com/yshui/2f1c5c8ce9d80e9eef1db4eab51344d0 this demonstrate the `CloseThreadpool` vs running callback race. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_51113

1 0

[PATCH v5 0/7] MR435: vkd3d-shader/tpf: Support non-constant offset dereferences, v2, part 2.
by Francisco Casas (＠fcasas) Nov. 6, 2023

Nov. 6, 2023

This is the last thing needed to support non-constant offset dereferences in SM4. It allows to perform relative addressing on temps. Besides this, I have additional patches for relative addressing on uniforms, and input and output semantics, but these may not be useful for now, since we copy all these variables into temps instead of using them directly. -- v5: vkd3d-shader/tpf: Support relative addressing for indexable temps in SM4. vkd3d-shader/tpf: Move sm4_register_from_node() up. vkd3d-shader/tpf: Support writing relative addressing indexes. vkd3d-shader/tpf: Write register index addressing. vkd3d-shader/tpf: Encode dst and src registers using the same function. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/435

4 11

[PATCH 0/1] MR4304: ole32/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Nov. 6, 2023

Nov. 6, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4304

3 2

[PATCH 0/1] MR4307: winegstreamer: Remove unused heap.h include.
by Alex Henrie (＠alexhenrie) Nov. 6, 2023

Nov. 6, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4307

4 3

[PATCH v2 0/1] MR438: vkd3d-shader/tpf: Don't pass 0x4 as mask for vec4 constant src registers.
by Francisco Casas (＠fcasas) Nov. 6, 2023

Nov. 6, 2023

Evan Tang reported that new fixmes appeared on the shader_runner when running some of his tests after f50d0ae2cbc5ee2a26fedd7b8aac2def62decd6c. vkd3d:652593:fixme:shader_sm4_read_src_param Unhandled mask 0x4. The change to blame seems to be this added line in sm4_src_from_constant_value(). + src->swizzle = VKD3D_SHADER_NO_SWIZZLE; On tpf binaries the last 12 bytes of each src register in an instruction specify the swizzle, and there are 5 possible combinations: Dimension NONE -------- 00 Dimension SCALAR -------- 01 Dimension VEC4, with a 4 bit writemask: ---- xxxx 00 01 Dimension VEC4, with an 8 bit swizzle: xx xx xx xx 01 01 Dimension VEC4, with a 2bit scalar dimension number: ------ xx 10 01 So far, we have only seen src registers use 4 bit writemasks in a single case: for vec4 constants, and it is always zero. So we expect this: ---- 0000 00 01 Now, I probably wanted to initialize src->swizzle to zero when writing constants, but VKD3D_SHADER_NO_SWIZZLE is not zero, it is actually the default swizzle: 11 10 01 00 And the last 4 bits (0x4) get written in the mask part, which causes the reader to complain. -- v2: vkd3d-shader/tpf: Don't pass 0x4 as mask for vec4 constant src registers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/438

4 4

[PATCH v2 0/3] MR439: spirv: Use register sizes from the shader signature instead of the DCL instruction.
by Zebediah Figura (＠zfigura) Nov. 6, 2023

Nov. 6, 2023

More preparatory work to declare I/O variables from the signature. -- v2: vkd3d-shader/spirv: Use register counts from the signature and shader desc. vkd3d-shader: Store the control point counts in struct vkd3d_shader_desc. vkd3d-shader/spirv: Use the array sizes for shader phase builtins as well. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/439

2 3

[PATCH v2 0/1] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) Nov. 6, 2023

Nov. 6, 2023

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones. Tweak the representation a bit so they are happy. -- v2: ntdll: Tweak the binary representation of SRWLOCK. https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

2 4

[PATCH 0/1] MR4310: ntdll: Tweak the binary representation of SRWLOCK.
by Yuxuan Shui (＠yshui) Nov. 6, 2023

Nov. 6, 2023

There are applications that uses SRWLOCK in an invalid way and then checks its binary representation. Specifically they releases an unlocked SRWLOCK then check its bit pattern is all-ones. Tweak the representation a bit so they are happy. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4310

2 1