November 2023 - Wine-GitLab

[PATCH v5 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu Nov. 29, 2023

Nov. 29, 2023

Here's a list of usages of `base.outer_window` that may be impacted by the change and my analysis/fixes. Note that I specifically did not look for `document->outer_window` since that one was already holding it forever, so it's out of scope for this MR (whether it's correct or not, the behavior is the same after this MR). I also didn't consider some cases that already **did not check** for it being NULL or not, because they would have crashed earlier before anyway (they'd still crash now if outer window gets killed, but it's out of scope of the MR as I said). For those that says "Handled" it means I've added checks so that the behavior is same as before, i.e. detached inner windows behave as if outer window is NULL. * `htmldoc.c/HTMLDocument_get_mimeType`: Changed so it doesn't rely on outer window. * `htmldoc.c/HTMLDocument7_get_defaultView`: This is actually fixed by these patches. * `htmlform.c/HTMLFormElement_submit`: Handled. * `htmlstorage.c/send_storage_event`: Fixed in a separate patch with tests, since it follows the outer window. * `htmlwindow.c/check_target_origin`: This (along with many other methods) can't have it NULL anymore or detached, since the caller must hold a ref to the outer window, and they're not called from our objects holding ref to inner window only. * `htmlwindow.c/HTMLWindowSP_QueryService`: This uses the outer window to obtain the browser and the doc obj, so it's fine. * `mutation.c/set_document_mode`: Handled. * `navigate.c/BindCallbackRedirect_Redirect`: Handled. * `navigate.c/nsAsyncVerifyRedirectCallback_OnRedirectVerifyCallback`: Handled. * `navigate.c/nsChannelBSC_init_bindinfo`: Uses the outer window to obtain the browser and doc obj to set a flag, so it's harmless and probably correct this way. * `navigate.c/handle_navigation_error`: Handled. * `navigate.c/handle_extern_mime_navigation`: Handled. * `omnavigator.c/OmHistory_get_length`: This is actually fixed by these patches. * `script.c/ActiveScriptSite_GetItemInfo`: Handled. * `script.c/ActiveScriptSiteWindow_GetWindow`: Handled. -- v5: mshtml/tests: Fix XHR leak in test_window_refs. mshtml: Get rid of outer_window member in HTMLDocumentNode. mshtml/tests: Improve the iframe navigation test. mshtml: Remove the inner window ref from the doc only when it is actually mshtml: Don't check for NULL outer_window from within HTMLWindow* methods. mshtml: Don't attempt to send storage events after outer window is destroyed. mshtml: Keep the inner window's outer_window pointer alive until it is mshtml: Don't rely on the outer_window in document.mimeType. https://gitlab.winehq.org/wine/wine/-/merge_requests/4380

2 11

[PATCH v3 0/1] MR4319: gdiplus: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Nov. 29, 2023

Nov. 29, 2023

-- v3: gdiplus: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4319

4 4

[PATCH v5 0/1] MR4545: mf: tests: Add test cases for evr events.
by Yuxuan Shui (＠yshui) Nov. 29, 2023

Nov. 29, 2023

-- v5: mf/tests: Add test cases for evr events. https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

2 2

[PATCH v4 0/1] MR4545: mf: tests: Add test cases for evr events.
by Yuxuan Shui (＠yshui) Nov. 29, 2023

Nov. 29, 2023

-- v4: mf/tests: Add test cases for evr events. https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

2 2

[PATCH v3 0/1] MR4545: mf: tests: Add test cases for evr events.
by Yuxuan Shui (＠yshui) Nov. 29, 2023

Nov. 29, 2023

-- v3: mf: tests: Add test cases for evr events. https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

4 4

[PATCH v5 0/4] MR487: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles, version 3.
by Francisco Casas (＠fcasas) Nov. 29, 2023

Nov. 29, 2023

Supersedes !482. Instead of only storing the value that each variable's component has at the moment of the instruction currently handled by copy-prop, we store the trace of all the historic values with their timestamps, i.e. the instruction index on which the value was stored. This allow us to query the value that the variable's component had at the time of a swizzle's load instead of the swizzle instead, which also preempts copy-prop from getting stuck in an infinite loop, as which the added tests. -- v5: vkd3d-shader/hlsl: Use values at the time of the swizzle's load in copy-propagation. vkd3d-shader/hlsl: Record trace of stored values in copy-propagation. vkd3d-shader/hlsl: Move index_instructions() up. tests: Test current failure when propagating swizzles. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/487

4 7

[PATCH v2 0/1] MR4545: mf: tests: Add test cases for evr events.
by Yuxuan Shui (＠yshui) Nov. 29, 2023

Nov. 29, 2023

-- v2: mf: tests: Add test cases for evr events. https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

2 3

[PATCH 0/1] MR4545: mf: tests: Add test cases for evr events.
by Yuxuan Shui (＠yshui) Nov. 29, 2023

Nov. 29, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4545

3 3

[PATCH 0/3] MR4441: Adding tests for CreateProcess and std handles.
by eric pouech (＠epo) Nov. 29, 2023

Nov. 29, 2023

Various new tests for CreateProcess showing a couple of issues in current implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4441

5 12

[PATCH 0/1] MR4544: shell32: Add stub for SHSetTemporaryPropertyForItem.
by Louis Lenders (＠xe) Nov. 29, 2023

Nov. 29, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55536 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4544

2 1