November 2023 - Wine-GitLab

Re: [PATCH v3 0/2] MR488: vkd3d: Improve the EnqueueMakeResident stub - approved
by Alexandre Julliard (＠julliard) Nov. 27, 2023

Nov. 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/488

1 0

[PATCH 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Petrichor Park (＠petrathekat) Nov. 27, 2023

Nov. 27, 2023

Currently, if a probe fails, it will print the line number of the [test] block the probe is in, not the line number of the probe itself. This makes it somewhat difficult to debug. This commit makes it print the line number of the probe as well. CC @zfigura -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499

2 1

[PATCH v3 0/6] MR4507: Add coml2 and start migrating a few functions from ole32
by Fabian Maurer (＠DarkShadow44) Nov. 27, 2023

Nov. 27, 2023

Split off from https://gitlab.winehq.org/wine/wine/-/merge_requests/3106 -- v3: coml2: Move WriteClassStg from ole32 coml2: Move WriteClassStm from ole32 coml2: Move ReadClassStg from ole32 coml2: Move ReadClassStm from ole32 coml2: Move GetConvertStg from ole32 https://gitlab.winehq.org/wine/wine/-/merge_requests/4507

6 15

[PATCH 0/1] MR4524: dmime: Add Release() on some codepath.
by eric pouech (＠epo) Nov. 27, 2023

Nov. 27, 2023

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4524

3 4

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) Nov. 27, 2023

Nov. 27, 2023

On Mon Nov 27 20:35:08 2023 +0000, Gabriel Ivăncescu wrote: > Yeah. As I said below, I can easily just get rid of the tests and do the > right thing with a comment. Silently dropping events sounds like a bad > idea to me, it will make it hard to debug if something broken ever > depends on it. And it's not like it's more code, either, so better make > it correct. My guess is that you wouldn't be able to reproduce that with JS. If that's the case, then web pages can't depend on that (otherwise we'd have a way to crash web browser from JS). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53978

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Jacek Caban (＠jacek) Nov. 27, 2023

Nov. 27, 2023

> As for the "hide problems in the future", I actually think the exact opposite. Right now, we use the document's outer_window in same way, except it's completely broken and can access invalid memory if the outer window happens to die, which would be very hard to debug (especially considering most apps using mshtml are bloated and slow with millions of frameworks). Yes, it would be nice to fix that. One fix for that is to simply reset the pointer to NULL. My understanding is that the actual reason we can't do that is iframe navigation test and we already know that the test works because on native, the document interface doesn't change. So what you do is essentially working around that problem, not fixing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53977

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu Nov. 27, 2023

Nov. 27, 2023

On Mon Nov 27 17:34:03 2023 +0000, Jacek Caban wrote: > This should really use `!iface_cmp()` to make sure it's not one more > instance of wrappers that native uses in similar places. However, trying > to do that crashes on native, which is just one more reason to believe > that detached documents are broken there and trying too hard to mimic it > does not make sense. I think that you're misinterpreting some quirks > that are not really interested in the first place. I suggest to drop > those tests and just do the right thing: don't send any events on > detached document, maybe even fail early on an attempt to use such storage. Yeah. As I said below, I can easily just get rid of the tests and do the right thing with a comment. Silently dropping events sounds like a bad idea to me, it will make it hard to debug if something broken ever depends on it. And it's not like it's more code, either, so better make it correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53976

1 0

Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu Nov. 27, 2023

Nov. 27, 2023

And of course the gitlab subscription reply doesn't work via email… Well that's why I wanted it before code freeze, so any possible regressions are detected now. Isn't that the point? For storage events, yeah I can easily get rid of the test and just keep the current "correct" behavior with a comment. I'd rather keep that than silently drop events (or even if it's logged, it's not that obvious), because that's 1) incorrect and 2) it's extremely hard to debug if something broken ever depends on it. Plus, it's not like sending the events is extra code than silently dropping them, most of the patch is in the tests. As for the "hide problems in the future", I actually think the exact opposite. Right now, we use the document's outer_window in same way, except it's completely broken and can access invalid memory if the outer window happens to die, which would be very hard to debug (especially considering most apps using mshtml are bloated and slow with millions of frameworks). What problem would this hide? The things that *are* different than before (e.g. parentWindow), are tested so they're fixed and correct, with the others being same as before, except not randomly crashing in some cases. Maybe it's not by itself a strong argument, but outer_window on document is now just simply broken and I'd like to fix that before the code freeze. Another reason is that such things would also be very hard to figure out if something even depends on (lack of events especially if it's corner case like this). Considering it also fixes a broken reference from outer_window that's completely arbitrary right now, I think that's reasonable enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380#note_53975

1 0

[PATCH v3 0/1] MR496: vkd3d-shader: Handle 'linear centroid' modifier.
by Nikolay Sivov (＠nsivov) Nov. 27, 2023

Nov. 27, 2023

-- v3: vkd3d-shader/hlsl: Handle 'linear centroid' modifier. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/496

2 1

[PATCH v3 0/3] MR4479: winegstreamer: Implement wg_muxer_finalize.
by Ziqing Hui (＠zhui) Nov. 27, 2023

Nov. 27, 2023

-- v3: winegstreamer: Implement wg_muxer_finalize. winestreamer: Implement {Begin,End}Finalize for media sink. winegstreamer: Avoid media sink command leaking. https://gitlab.winehq.org/wine/wine/-/merge_requests/4479

4 5