November 2023 - Wine-GitLab

[PATCH 0/1] MR4418: cmd: Delay variable substitution until after the if clause is parsed.
by Alex Henrie (＠alexhenrie) Nov. 22, 2023

Nov. 22, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4418

3 6

[PATCH 0/1] MR4471: msvcrt: Hold _ENV_LOCK when accessing environment variables.
by Piotr Caban (＠piotr) Nov. 22, 2023

Nov. 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4471

3 4

[PATCH 0/3] MR487: vkd3d-shader/hlsl: Fix infinite loops when applying copy-prop to swizzles, version 3.
by Francisco Casas (＠fcasas) Nov. 22, 2023

Nov. 22, 2023

Supersedes !482. Instead of only storing the value that each variable's component has at the moment of the instruction currently handled by copy-prop, we store the trace of all the historic values with their timestamps, i.e. the instruction index on which the value was stored. This allow us to query the value that the variable's component had at the time of a swizzle's load instead of the swizzle instead, which also preempts copy-prop from getting stuck in an infinite loop, as which the added tests. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/487

3 7

[PATCH 0/1] MR4469: wineusb.sys: Add support for URB_FUNCTION_VENDOR_DEVICE.
by Hans Leidekker (＠hans) Nov. 22, 2023

Nov. 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4469

3 2

[PATCH v3 0/1] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) Nov. 22, 2023

Nov. 22, 2023

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `if (name->str && !name->len)` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v3: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

3 13

[PATCH 0/1] MR4475: gdiplus: Avoid computation overflow and underflow by using hypotf
by Bartosz Kosiorek (＠gang65) Nov. 22, 2023

Nov. 22, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45123 By using sqrt(a * a + b * b), for large (or small) a or b, there is a possibility of overflow (underflow), although the result itself is not that big to cause overflow. To overcome this problem, there are implementations of hypotenuse that do not use power of 2, and use other methods to calculate the result. To calculate a ⊕ b, you can easily use hypotf(a,b). https://en.cppreference.com/w/cpp/numeric/math/hypot -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4475

2 1

Re: [PATCH v3 0/2] MR4440: regsvr32: Explicitly output of unix fd.
by Jacek Caban (＠jacek) Nov. 22, 2023

Nov. 22, 2023

Jacek Caban (@jacek) commented about programs/regsvr32/regsvr32.c: > Unregister = TRUE; > break; > case 's': > + SetThreadLocale(MAKELCID(MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US), SORT_DEFAULT)); We're using the same thread later to call arbitrary DLL code later, so changing locale here doesn't seem right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4440#note_53347

1 0

[PATCH 0/1] MR4474: winhttp: Use an unsigned integer for number values in query_headers().
by Hans Leidekker (＠hans) Nov. 22, 2023

Nov. 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4474

2 1

[PATCH v4 0/11] MR4439: mfplat: Implement MFInitAMMediaTypeFromMFMediaType and related functions.
by Rémi Bernon Nov. 22, 2023

Nov. 22, 2023

IMFMediaType_(Get|Free)Representation is called by Samurai Maiden, MFInitAMMediaTypeFromMFMediaType could be useful to simplify DMO / MFT transforms implementations. -- v4: mfplat: Implement IMFMediaType_(Get|Free)Representation. mfplat: Implement MFCreateAMMediaTypeFromMFMediaType. mfplat: Implement MFInitAMMediaTypeFromMFMediaType. mfplat: Use bits per pixel in uncompressed formats metadata. mfplat: Only convert MEDIASUBTYPE for the formats which need it. mfplat/tests: Add IMFMediaType_GetRepresentation tests. mfplat/tests: Add tests for MFCreateAMMediaTypeFromMFMediaType. mfplat/tests: Add tests for MFInitAMMediaTypeFromMFMediaType. mfplat: Add MFInitAMMediaTypeFromMFMediaType stub. mfplat: Add MFCreateAMMediaTypeFromMFMediaType stub. mfplat: Add support for internal MFVideoFormat_A2B10G10R10. https://gitlab.winehq.org/wine/wine/-/merge_requests/4439

3 13

[PATCH v3 0/10] MR4439: mfplat: Implement MFInitAMMediaTypeFromMFMediaType and related functions.
by Rémi Bernon Nov. 22, 2023

Nov. 22, 2023

IMFMediaType_(Get|Free)Representation is called by Samurai Maiden, MFInitAMMediaTypeFromMFMediaType could be useful to simplify DMO / MFT transforms implementations. -- v3: mfplat: Implement IMFMediaType_(Get|Free)Representation. mfplat: Implement MFCreateAMMediaTypeFromMFMediaType. mfplat: Implement MFInitAMMediaTypeFromMFMediaType. mfplat: Use bits per pixel in uncompressed formats metadata. mfplat: Only convert MEDIASUBTYPE for the formats which need it. mfplat/tests: Add IMFMediaType_GetRepresentation tests. mfplat/tests: Add tests for MFCreateAMMediaTypeFromMFMediaType. mfplat/tests: Add tests for MFInitAMMediaTypeFromMFMediaType. mfplat: Add MFInitAMMediaTypeFromMFMediaType stub. mfplat: Add MFCreateAMMediaTypeFromMFMediaType stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/4439

3 16