November 2023 - Wine-GitLab

[PATCH 0/1] MR4472: user32/tests: Add a trailing linefeed to ok() and skip() calls.
by Francois Gouget (＠fgouget) Nov. 22, 2023

Nov. 22, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4472

3 2

[PATCH 0/1] MR486: tests: Introduce an OpenGL shader runner.
by Henri Verbeet (＠hverbeet) Nov. 22, 2023

Nov. 22, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/486

3 5

[PATCH v5 0/3] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) Nov. 22, 2023

Nov. 22, 2023

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v5: vkd3d-shader/hlsl: Implement atan2. vkd3d-shader/hlsl: Implement atan. vkd3d-shader/hlsl: Implement acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

4 7

[PATCH v5 0/3] MR3876: Zero-width character handling in GetTextExtentExPoint[AWI]
by Torge Matthies (＠tmatthies) Nov. 22, 2023

Nov. 22, 2023

Certain characters are considered by GetTextExtentExPointA/W/I to have no width, even if they have a non-zero width and a shape in the font. This MR attempts to bring Wine's implementation of these functions closer to native behavior. One remaining difference is caused by GetGlyphIndicesA/W returning 0 instead of 0xffff for some characters, for some reason. This also affects the handling by GetTextExtentExPointA/W/I of affected characters. I have compared this with both Uniscribe and DWrite behavior and neither of them match this behavior, so it seems to be a peculiarity of these older functions. Remaining differences are probably caused by differences in the fallback fonts used when a character is missing from the selected font. Notably, on my system there doesn't seem to be a fallback font for `\t`/`\n`/`\r` that marks those characters as zero-width, and since applications are likely to depend on the metrics of those characters (I know of at least one), I have opted to explicitly make them zero-width in this MR, even though that is technically not what Windows does. -- v5: win32u: Handle glyphs that are marked by the font as zero-width in GetTextExtentExPoint[AWI]. win32u: Use maximum of (A, A+C, A+C+B) width for character fit test in GetTextExtentExPoint[AWI]. gdi32/tests: Add test for width of carriage return and line feed. https://gitlab.winehq.org/wine/wine/-/merge_requests/3876

3 4

[PATCH v6 0/4] MR478: vkd3d-shader/hlsl: Parse integers with the 'u' postfix.
by Francisco Casas (＠fcasas) Nov. 22, 2023

Nov. 22, 2023

-- v6: vkd3d-shader/hlsl: Discern between signed and unsigned ints when parsing. tests: Test overloads with signed and unsigned numeric values. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/478

5 8

Re: [PATCH v3 0/1] MR3844: odbccp32: Handle memory allocation failure in SQLGetInstalledDriversW (cppcheck). - closed
by Alexandre Julliard (＠julliard) Nov. 22, 2023

Nov. 22, 2023

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3844

1 0

Re: [PATCH v3 0/1] MR3844: odbccp32: Handle memory allocation failure in SQLGetInstalledDriversW (cppcheck).
by Alexandre Julliard (＠julliard) Nov. 22, 2023

Nov. 22, 2023

Closing for the same reason as !3846. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3844#note_53312

1 0

Re: [PATCH v3 0/1] MR3847: winmm: Handle memory allocation failure in WINMM_OpenDevice (cppcheck). - closed
by Alexandre Julliard (＠julliard) Nov. 22, 2023

Nov. 22, 2023

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3847

1 0

Re: [PATCH v3 0/1] MR3847: winmm: Handle memory allocation failure in WINMM_OpenDevice (cppcheck).
by Alexandre Julliard (＠julliard) Nov. 22, 2023

Nov. 22, 2023

Closing for the same reason as !3846. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3847#note_53310

1 0

Re: [PATCH v3 0/1] MR3846: winmm: Handle memory allocation failure in MMDRV_InitPerType (cppcheck).
by Alexandre Julliard (＠julliard) Nov. 22, 2023

Nov. 22, 2023

Like Huw said, this is mostly a matter of taste, so it's better not to change existing code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3846#note_53309

1 0